Solved Multiple commands.

Hi guys, new developer here, Basically, I want 2 commands,
but, the second command in my code just doesn't do anything, no message ingame, no console error.

Code:

Code:java

package me.RandomGuy.Commands;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class main extends JavaPlugin implements Listener {
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] a) {
        Player player = (Player) sender;
        if (cmd.getName().equalsIgnoreCase("confuseme")) {
            if (player.hasPermission("commands.confuseme")) {
                player.sendMessage(ChatColor.GREEN
                        + "Don't get too sick! /confusemestop to end this madness");
                player.addPotionEffect(new PotionEffect(PotionEffectType.SPEED,
                        600, 2));
                player.addPotionEffect(new PotionEffect(
                        PotionEffectType.BLINDNESS, 600, 1));
                player.addPotionEffect(new PotionEffect(
                        PotionEffectType.CONFUSION, 600, 2));
                player.addPotionEffect(new PotionEffect(PotionEffectType.JUMP,
                        600, 2));
            } else {
                player.sendMessage(ChatColor.DARK_PURPLE + "Commands"
                        + ChatColor.GREEN + ">" + ChatColor.RED
                        + "You need rank" + ChatColor.DARK_AQUA + "Helper"
                        + ChatColor.RED + "to use this command!");
            }
            if (cmd.getName().equalsIgnoreCase("confusemestop")) {
                if (player.hasPermission("Commands.confuseme")) {
                    player.getActivePotionEffects().clear();
                    player.sendMessage(ChatColor.RED + "Stopped madness");
                } else {
                    player.sendMessage(ChatColor.DARK_PURPLE + "Commands"
                            + ChatColor.GREEN + ">" + ChatColor.RED
                            + "You need rank" + ChatColor.DARK_AQUA + "Helper"
                            + ChatColor.RED + "to use this command!");
                }
        }
    }
        return false;
    }}
 

How would I go about this?

 

Your second command is not nested properly (it is nested in the first command) RandomGuy137

 

Hm, How would i go about fixing this? Do I need another:

1. public boolean onCommand(CommandSender sender, Command cmd, String label,
2. String[] a) {

 

Is It? I see three '}' like there should be... (Near return false)
EDIT: Ohh I see, you're correct about that. Sorry.


RandomGuy137 You have put the commands into the plugin.yml correct...?

 

Yes

 

Xyplo After a bit of cleanup:

Code:java

package me.RandomGuy.Commands;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class main extends JavaPlugin implements Listener 
{
 
    public void onEnable() 
    {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label,String[] a) 
    {
        Player player = (Player) sender;
        if (cmd.getName().equalsIgnoreCase("confuseme")) 
        {
            if (player.hasPermission("commands.confuseme")) 
            {
                player.sendMessage(ChatColor.GREEN
                        + "Don't get too sick! /confusemestop to end this madness");
                player.addPotionEffect(new PotionEffect(PotionEffectType.SPEED,
                        600, 2));
                player.addPotionEffect(new PotionEffect(
                        PotionEffectType.BLINDNESS, 600, 1));
                player.addPotionEffect(new PotionEffect(
                        PotionEffectType.CONFUSION, 600, 2));
                player.addPotionEffect(new PotionEffect(PotionEffectType.JUMP,
                        600, 2));
            } 
            else 
            {
                player.sendMessage(ChatColor.DARK_PURPLE + "Commands"
                        + ChatColor.GREEN + ">" + ChatColor.RED
                        + "You need rank" + ChatColor.DARK_AQUA + "Helper"
                        + ChatColor.RED + "to use this command!");
            }
            if (cmd.getName().equalsIgnoreCase("confusemestop"))
            {
                if (player.hasPermission("Commands.confuseme")) 
                {
                    player.getActivePotionEffects().clear();
                    player.sendMessage(ChatColor.RED + "Stopped madness");
                } 
                else 
                {
                    player.sendMessage(ChatColor.DARK_PURPLE + "Commands"
                            + ChatColor.GREEN + ">" + ChatColor.RED
                            + "You need rank" + ChatColor.DARK_AQUA + "Helper"
                            + ChatColor.RED + "to use this command!");
                }
            }
        }
        return false;
    }
}

You now see that

Code:java

if(cmd.getName().equalsIgnoreCase("confusemestop"))

is inside

Code:java

if (cmd.getName().equalsIgnoreCase("confuseme"))
{
    ...
}

 

OMG THANKS!

 

Solved?

Put the thread as solved.

 

Wait,, fireblast709 it's the same results as before..

yup, definitely wont work.

timtower do you know?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

RandomGuy137 Can you post the updated code.

 

I used what you sent

Oh.. fireblast709

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

RandomGuy137 I didn't fix any of that, I merely pointed at the mistakes

 

Oh, my bad. Could you? fireblast709
I'm unsure, Kinda.

 

One alternative way of doing this is to just have the /confuseme command, then when someone runs it, add them to a list of players (or player names if you want to be more efficient) currently being confused. If a player uses the command and is already in the set of people currently being confused, run the /confusemestop code instead. E.g.

Code:java

private HashSet<String> confused;
 
public void onEnable() {
  // Do stuff
  confused = new HashSet<String>();
}
 
public boolean onCommand(...) {
  if (cmd.getName().equalsIgnoreCase("confuseme") {
    if (confused.contains(sender.getName()) {
      confused.remove(sender.getName());
      // confusemestop code
    else {
      confused.add(sender.getName());
      // confuseme code
    }
  }
}

 

If you don't know why the code still doesn't work despite fireblast709 telling you its caused by your second command check being inside your first one, I suggest reading a Java tutorial about how if statements work.

 

I'm experienced in java actually sir, What I didn't understand is how the commands worked.
It's solved now anyway, I just re-did it all.

 

regardless of knowing how commands work, normal and nested if statements and how they operate do not change