Help with adding a potion effect to a player

Hello. I've tried to make a plugin that changes the effects of a Golden Apple, but it doesn't work. All it does so far is add speed for 1 second. Here's my code:

Code:java

public class Candy extends JavaPlugin implements Listener{
 
 
    public void onEnable(){
        getServer().getPluginManager().registerEvents(this, this);
    }
 
 
 
    @EventHandler
    public void onPlayerItemConsume(PlayerItemConsumeEvent e){
        if(e.getItem().getType() == Material.GOLDEN_APPLE ){
 
        }
        Player p = e.getPlayer();
        ItemMeta pm = (ItemMeta) e.getItem().getItemMeta();
        if(pm.getDisplayName().equalsIgnoreCase("Candy")){
        p.sendMessage(ChatColor.YELLOW + "You ate " + ChatColor.GOLD + "candy! Enjoy your effects. ;)");
        p.addPotionEffect(new PotionEffect(PotionEffectType.JUMP, 10, 3));
        p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10, 10));
        p.addPotionEffect(new PotionEffect(PotionEffectType.CONFUSION, 10, 0));
        }
        if(!p.hasPermission("candy.eat")){
            p.sendMessage(ChatColor.RED + "You are not Super+! Donate for it here " + ChatColor.GREEN + " [url]http://vontagemc.enjin.com/shop[/url]");
 
 
 
        }
 
        }
        }
 

Any help would be appreciated. Thanks!

 

First of all, how does your item looks like? And where the code that creates apple?
Secondary,

Code:

[LIST]


[*]

p.addPotionEffect(new PotionEffect(PotionEffectType.JUMP, 10, 3));




[*]

p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10, 10));




[*]

p.addPotionEffect(new PotionEffect(PotionEffectType.CONFUSION, 10, 0));

[*]will be almost unnoticiable, since duration is in ticks. 20 ticks = 1 second, 10 ticks = 0,5 sec, so you giving effects for less then 0.5 seconds.


[/LIST]

p.s. I'm not going to fix large spaces in my posts anymore. It's this forum's bug and not my problem.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It will just be a golden apple. Also, it doesn't create an apple. You have to manually get an apple.

 

CreeperFan12346
Try to organize things better, I had to do a lot of reworking.

Code:java

    @EventHandler
    public void onPlayerItemConsume(PlayerItemConsumeEvent e){
        if(e.getItem().getType().equals(Material.GOLDEN_APPLE) && e.getItem().hasItemMeta() && e.getItem().getItemMeta().hasDisplayName() && e.getItem().getItemMeta().getDisplayName().equals("Candy")){
            Player p = e.getPlayer();
            if(p.hasPermission("candy.eat")){
                p.sendMessage(ChatColor.RED + "You are not Super+! Donate for it here " + ChatColor.GREEN + "[url]http://vontagemc.enjin.com/shop[/url]");
                e.setCancelled(true);
            }else{
                p.sendMessage(ChatColor.YELLOW + "You ate " + ChatColor.GOLD + "candy! Enjoy your effects.");
                p.addPotionEffect(new PotionEffect(PotionEffectType.JUMP, 10, 3));
                p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10, 10));
                p.addPotionEffect(new PotionEffect(PotionEffectType.CONFUSION, 10, 0));
            }
        }
    }

 

CreeperFan12346
Second parameter of contructor of PotionEffect is time in ticks. So it's really acting for half a second.

 

Oh.

I've tried a lot. Still doesn't work.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Are you changing any of your code at all? Take in part as they have said, the 2nd parameter represents the server ticks. 20 equals one second. So if you want speed to last for 10 seconds, do this:
p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10 * 20, 10));

 

CreeperFan12346
Cancel the event and then add the potion effects and remove the golden apple from the player's inventory.

 

How would I do that? (I'm a beginner at java)

 

Bump

I've tried it, it doesn't work.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I think I found your issue. You make an if statement checking if it's a golden apple that was consumed, but you don't put anything inside of it. Instead, you put it outside of the if statement, and it doesn't get ran.

Code:java

if(e.getItem().getType() == Material.GOLDEN_APPLE ){
 
}

Throw all of your code into that if statement.

 

I tried that as well. Still doesn't work.

 

Does the display name of the golden apple equal any capitalization variation of Candy? That is literally my last guess (for now).

 

Nope.

 

Is the name of the golden apple colored? Is the name of the golden apple surely "candy". You said that you do not create the item, but they have to get it. The item won't just name itself. If the name is colored, then that must be taken into account when comparing the current item with "Candy".

 

Assuming they have an apple with the exact name "Candy", then do the code TheOatBaron did, but swap what is inside the if and else statements, and fix the effects. It should work.

Code:java

 @EventHandler
public void onPlayerItemConsume(PlayerItemConsumeEvent e){
if(e.getItem().getType().equals(Material.GOLDEN_APPLE) && e.getItem().hasItemMeta() && e.getItem().getItemMeta().hasDisplayName() && e.getItem().getItemMeta().getDisplayName().equals("Candy")){
Player p = e.getPlayer();
if(p.hasPermission("candy.eat")){
p.sendMessage(ChatColor.YELLOW + "You ate " + ChatColor.GOLD + "candy!"+ ChatColor.YELLOW+ " Enjoy your effects.");
p.addPotionEffect(new PotionEffect(PotionEffectType.JUMP, 3, 200));
p.addPotionEffect(new PotionEffect(PotionEffectType.SPEED, 10, 200));
p.addPotionEffect(new PotionEffect(PotionEffectType.CONFUSION, 1, 200));
 
}else{
p.sendMessage(ChatColor.RED + "You are not Super+! Donate for it here " + ChatColor.GREEN + "[url]http://vontagemc.enjin.com/shop[/url]");
e.setCancelled(true);
}
}
}

^ Use that code