Enums - Getters and Setters

I wanted to start using enums for global variables and I wanted to create clean getters and setters for variables, but I can't seem to find a way to do so.. Here's what I have so far

Code:java

public enum GlobalVariables {
    PLAYERSMAX(20);
 
    private int i;
 
    private GlobalVariables(int i) {
        this.i = i;
    }
 
 
    public static int getValue(GlobalVariables type) {
        return valueOf(type);
    }
 
 
    public void setValue(GlobalVariables type, int value) {
        // umm.. wut?
    }
}

 

Code:

public int getValue(){
    return i;
}
 
public void setValue(int i){
    this.i = i;
}

 

Garris0n
Yeah, but I wanted a method that was more simple than that. Because GlobalVariable.VARIABLE.getValue(); is just messy to me.

 

MrSparkzz That's the standard way it works but if you insist...

PHP:

public enum GlobalVariables {
    MAX_PLAYERS(20);
 
    private int i;
 
    private GlobalVariables(int i) {
        this.i = i;
    }
 
    public int getValue() {
        return i;
    }
 
    public void setValue(int i) {
        this.i = i;
    }
 
    public static int getValue(GlobalVariable type) {
        return type.getValue();
    }
 
    public static void setValue(GlobalVariable type, int i) {
        type.setValue(i);
    }
}

Now try and tell me that GlobalVariables.getValue(GlobalVariables.MAX_PLAYERS); isn't more messy

Also, static imports.

 

Why would you have a setter for a enum? It sort of defeats the purpose...

 

You would prefer

Code:

GlobalVariable.getValue(GlobalVariable.VARIABLE)

to

Code:

GlobalVariable.VARIABLE.getValue()

Uh...okay.

 

SuperOmegaCow
If you want to store additional information it can be useful, for example:

Code:

enum Weekday{
  MONDAY("Montag"), TUESDAY("..."), WEDNESDAY("..."), THURSDAY("..."), FRIDAY("..."), SATURDAY("..."), SUNDAY("...");
 
  private String inGerman;
 
  Weekday(String inGerman){
    this.inGerman = inGerman;
  }
 
  //get-set
}

I'm glad this feature exists, I use it in a plugin I'm developing atm.

 

oaschi Yes, but the code you've shown can do with a setter method and work exactly the same, yes? The point SuperOmegaCow is trying to make is that enums are constants - so why would you need to change what they represent? i.e. MONDAY is never going to change from Montag to something else, is it? So why do you need the setter?

 

AdamQpzm
I should read more precisely, I thought he was asking why someone would make an instance variable in an enum.
I agree that setters are not needed in enums.

 

Create a class with static fields.