Skull Problem. Help?!

Ok, so, I been working on this for about 2 days trying to get this right and I think this is a good time to post this because i'm going to eat. I have an issue with just one thing! When I add the code "if (!(skulltype.equals(SkullType.ZOMBIE)))return;" After I add this, the whole thing beneath that code doesn't work and I get no errors. If you know this, please help me! Thanks!

Code:

Code:java

@SuppressWarnings("deprecation")
    @EventHandler
    public void onBlockPlace(BlockPlaceEvent e){
        Block block = e.getBlock();   
        if (!(block.getState() instanceof Skull)){
            return;
        }
 
        Skull skull = (Skull) block.getState();
        SkullType skulltype = skull.getSkullType();
 
        if (e.getBlock().getType() == Material.SKULL_ITEM){
            if (!(skulltype.equals(SkullType.ZOMBIE)))return;
            int x = e.getBlock().getLocation().getBlockX();
            int y = e.getBlock().getLocation().getBlockY();
            int z = e.getBlock().getLocation().getBlockZ();
            Location loc = new Location(e.getBlockPlaced().getWorld(), x, y-1, z);
            Location loc2 = new Location(e.getBlockPlaced().getWorld(), x, y-2, z);
            int b = loc.getBlock().getTypeId();
            int b2 = loc2.getBlock().getTypeId();
 
            if (b == 88){
                if (b2 == 88){
                    LivingEntity p = e.getBlockPlaced().getWorld().spawnCreature(e.getBlockPlaced().getLocation(), EntityType.PIG_ZOMBIE);
                    p.setMaxHealth(100.0);
                    p.setHealth(100.0);
                    return;
                }
            }
        }
    }

 

I believe the problem instead lies within the line above --

Code:java

if (e.getBlock().getType() == Material.SKULL_ITEM){

It should be comparing against Material.SKULL, as SKULL_ITEM is referring to the item rather than the block. Also, it's not really necessary to have it there as you already checked before.

Code:java

if (!(block.getState() instanceof Skull)){
    return;
}

 

Barnyard_Owl

Alrighty. This is what I got and It still doesn't work. Sorry if I coded it wrong. I changed it up a bit.

Code:java

@SuppressWarnings("deprecation")
    @EventHandler
    public void onBlockPlace(BlockPlaceEvent e){
        Block block = e.getBlock();   
        if (!(block.getState() instanceof Skull)){
            return;
        }
 
        Skull skull = (Skull) block.getState();
        SkullType skulltype = skull.getSkullType();
 
        if (skulltype.equals(SkullType.ZOMBIE)){
            int x = e.getBlock().getLocation().getBlockX();
            int y = e.getBlock().getLocation().getBlockY();
            int z = e.getBlock().getLocation().getBlockZ();
            Location loc = new Location(e.getBlockPlaced().getWorld(), x, y-1, z);
            Location loc2 = new Location(e.getBlockPlaced().getWorld(), x, y-2, z);
            int b = loc.getBlock().getTypeId();
            int b2 = loc2.getBlock().getTypeId();
 
            if (b == 88){
                if (b2 == 88){
                    LivingEntity p = e.getBlockPlaced().getWorld().spawnCreature(e.getBlockPlaced().getLocation(), EntityType.PIG_ZOMBIE);
                    p.setMaxHealth(100.0);
                    p.setHealth(100.0);
                    return;
                }
            }
        }
    }

Bump.

Bumped. Anyone, really? Just one thing

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You should try and change it to:

Code:java

if(e.getBlock().getType == Material.SKULL_ITEM, 1, (short) 2);

Not sure if it works, but I guess you could give it a try.
The (short) 2 in the code makes it a Zombie head instead of a regular skull head.

 

It says "The method SKULL_ITEM(int, short) is undefined for the type Material"
Anyone else?

Bump. again.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bumped. Sigh....

 

Jetsinsu The suggestion by CodePlaysMC makes no sense and won't work - can I see whatever the most recent copy was before you implemented the suggested changes?

 

AdamQpzm

Code:

Code:java

@SuppressWarnings({ "deprecation", "unused" })
    @EventHandler
    public void onBlockPlace(BlockPlaceEvent e){
        if (!(e.getBlock().getState() instanceof Skull)){
            return;
        }
 
        Block block = e.getBlock();   
        Skull skull = (Skull) block.getState();
        SkullType skulltype = skull.getSkullType();
 
        if (skull.equals(SkullType.ZOMBIE)){
            int x = e.getBlock().getLocation().getBlockX();
            int y = e.getBlock().getLocation().getBlockY();
            int z = e.getBlock().getLocation().getBlockZ();
            Location loc = new Location(e.getBlockPlaced().getWorld(), x, y-1, z);
            Location loc2 = new Location(e.getBlockPlaced().getWorld(), x, y-2, z);
            int b = loc.getBlock().getTypeId();
            int b2 = loc2.getBlock().getTypeId();
 
            if (b == 88){
                if (b2 == 88){
                    LivingEntity p = e.getBlockPlaced().getWorld().spawnCreature(e.getBlockPlaced().getLocation(), EntityType.ZOMBIE);
                    p.setMaxHealth(100.0);
                    p.setHealth(100.0);
                    return;
                }
            }
        }
    }

 

if(skulltype.equals(SkullType.ZOMBIE)) would make more sense

 

DxDy

It doesn't work. I tried it. If you wold like to add me on skype, my name is Belinkster.

 

Jetsinsu Print out what the value of skulltype is and then come back to us

 

AdamQpzm

Idk if I should have found that rude or confusing. Lol

 

Jetsinsu It wasn't intended as either of them - if you're saying that the value of skulltype isn't SkullType.ZOMBIE it would be good to find out what the actual value is, no?

 

Basic problem solving skills. You do have an error. You don't know what it is. The thing you know is: My Statement inside the if does not return true (ie equals does not return true).

Hence you'll print out skull-type to see what actually is inside that variable at the time of the comparison.

You should have appreciated that statement by AdamQpzm as helpful and well-intentioned

 

DxDy

Hmmm.

AdamQpzm

So the value of the skull for zombies? Like "Material.SKULL, 1, (short)2);" ?

 

Jetsinsu Nope, just put this in right after SkullType skulltype = etc

Code:

System.out.println(skulltype);

 

System.out.println(skulltype.toString());

edit: ninja'd by AdamQpzm^^

 

DxDy

O. I'm pretty new to that. What does it exactly do.

 

Jetsinsu It prints the value of skulltype to your console

 

System.out.println prints a message to the standard output (in your case: your console window (simplified)), skulltype.toString() will get you the name of the enum constant the skulltype currently has.

 

AdamQpzm

It keeps saying Skeleton when I place down Zombie head.

 

Jetsinsu Well that definitely sounds wrong, doesn't it? What does it print out when you place a skeleton skull? How about other types of skull? Failing that, try printing out the byte data value for different skulls when placing them

DxDy Fun fact: Did you know that PrintStream's println(Object) method calls String.valueOf(Object) which ends up calling the object's toString() method if the object isn't null? The only real difference is that System.out.println(Object) is null-safe, but System.out.println(Object.toString()) isn't.

 

AdamQpzm

I like this game, it's fun.

 

I did know that it called the method, but to be honest I completely forgot about null-safety in the spur of the moment

 

AdamQpzm

All I got is this..... System.out.println(skull.getData().toString());

 

Jetsinsu Fair enough. And what prints when you try to place a zombie skull and what prints when you try to print a skeleton skull?

 

AdamQpzm

Both says, SKULL(1) facing SELF

AdamQpzm

Do you know what is wrong?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Jetsinsu Nope. I'd have to run my own tests, which I'm not able to do right now.