Solved Plugin not working no ERRORS

I have been working on my plugin but there is something wrong with it!
it doesn't give me an error!
but it just doesn't work!
here is my code:

Code:java

package me.timmaker.dmrtje.commands;
 
import me.timmaker.dmrtje.Dmrtje;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
 
public class openAttractieCommand implements CommandExecutor{
 
    private Dmrtje plugin = Dmrtje.getInstance();
    private String ErrorPrefix = ChatColor.DARK_RED + "[" + ChatColor.RED + "Error" + ChatColor.DARK_RED + "] " + ChatColor.RED;
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if (cmd.getName().equalsIgnoreCase("openattractie")) {
            if (args.length == 0) {
                sender.sendMessage(ErrorPrefix + "JE MOET WEL EEN NAAM OPGEVEN!");
                return true;
 
            }if (args.length == 1 || args.length > 1) {
 
                StringBuilder sb = new StringBuilder();
                for (int i = 0; i < args.length; i++) {
                    sb.append(args[i]);
                    sb.append(" ");
                }
 
                String msg = sb.toString().trim();
                if (!plugin.attracties.contains(msg)) {
                    sender.sendMessage(ErrorPrefix + "Deze attractie bestaat niet!");
                    return true;
                }if (plugin.attracties.contains(msg) && plugin.attracties.getBoolean(msg, true)) {
                    sender.sendMessage(ErrorPrefix + "Deze attractie is al geopend!");
                    return true;
                }if (plugin.attracties.contains(msg) && plugin.attracties.getBoolean(msg, false)) {
                    sender.sendMessage(msg);
                    Bukkit.broadcastMessage(msg);
                    return true;
                }return true;
            }
        }
        return true;
    }
 
}[/i]

Sorry for the dutch sentences thats cause i'am dutch!

 

Dmrtje No errors + doesn't work = debug code. Put in some println statements in there to see what's reached and what's not.

 

Note: Please follow Java conventions, make the first letter of your class name capital, OpenAttractieCommand.

Firstly, are you even setting the executor this class in the main class onEnable() method?
this.getCommand("openattractie").setExecutor(new OpenAttractieCommand());

Secondly, are you sure the command is in the plugin.yml file?

Thirdly, initiate the "plugin" object in a constructor.

Code:

public OpenAttractieCommand() {
    this.plugin = Dmrtjie.getInstance();
}

Fourthly, you're always returning true, only return true if the command IS openattractie, otherwise return false.

Lastly and probably the main reason, the boolean inside the if statement is always false.
Are you sure "attracties" list contains the message and the config contains their message? You haven't done anything to handle if all the if statements are false. It should be structured like this:

Code:

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if (cmd.getName().equalsIgnoreCase("openattractie")) {
            if (args.length == 0) {
                sender.sendMessage(ErrorPrefix + "JE MOET WEL EEN NAAM OPGEVEN!");
            } else if (args.length > 0) {
                StringBuilder sb = new StringBuilder();
                for (int i = 0; i < args.length; i++) {
                    if (i == args.length - 1) sb.append(args[i]);
                    else sb.append(args[i] + " ");
                }
 
                String msg = sb.toString();
                if (!plugin.attracties.contains(msg)) {
                    sender.sendMessage(ErrorPrefix + "Deze attractie bestaat niet!");
                } else if (plugin.attracties.getBoolean(msg, true)) {
                    sender.sendMessage(ErrorPrefix + "Deze attractie is al geopend!");
                    return true;
                } else if (plugin.attracties.contains(msg) && plugin.attracties.getBoolean(msg, false)) {
                    sender.sendMessage(msg);
                    Bukkit.broadcastMessage(msg);
                } else {
                    sender.sendMessage(ErrorPrefix + "Invalid message.");
                }
            }
            return true;
        }
        return false;
    }

 

KingFaris11 Yeah i know i should do that The first letter capital but it is just private so...

and here is my main class

Code:java

package me.timmaker.dmrtje;
 
import me.timmaker.dmrtje.commands.addAttractieCommand;
import me.timmaker.dmrtje.commands.delAttractieCommand;
import me.timmaker.dmrtje.commands.openAttractieCommand;
import me.timmaker.dmrtje.commands.sluitAttracieCommand;
import me.timmaker.dmrtje.logger.DmrtjeLogger;
import me.timmaker.dmrtje.resources.MyConfig;
import me.timmaker.dmrtje.resources.MyConfigManager;
 
import org.bukkit.plugin.java.JavaPlugin;
 
 
 
public class Dmrtje extends JavaPlugin{
 
    MyConfigManager configManager;
    public MyConfig attracties;
 
    private static Dmrtje instance;
 
    public void onEnable() {
        DmrtjeLogger.printInfo("Is sucesvol opgestart!");
 
        instance = this;
 
        //CONFIGS!
 
        configManager = new MyConfigManager(this);
 
        attracties = configManager.getNewConfig("Attracties.Dmrtje");
 
        //COMMANDS!
 
        getCommand("addattractie").setExecutor(new addAttractieCommand());
        getCommand("delattractie").setExecutor(new delAttractieCommand());
 
        getCommand("openattractie").setExecutor(new openAttractieCommand());
        getCommand("sluitattractie").setExecutor(new sluitAttracieCommand());
    }
 
    public void onDisable() {
        DmrtjeLogger.printInfo("Is succesvol gestopt!");
    }
 
    public static Dmrtje getInstance() {
        return instance;
    }
 
 
}
 

and my plugin.yml

Code:

name: Dmrtje
version: 0.0.1
main: me.timmaker.dmrtje.Dmrtje
description: De Dmrtje Theme park Plugin!
 
commands:
    openattractie:
        usage: /<command> <attractie naam>
        description: Opent een attractie!
    addattractie:
        usage: /<command> <attractie naam>
        description: Voegt een attractie toe!
    delattractie:
        usage: /<command> <attractie naam>
        description: verwijdert een attractie!
    sluitattractie:
        usage: /<command> <attractie naam>
        description: Sluit een attractie!

and finaly for me there is no code in what you posted

 

Test using my code. Your one looks correct, except I don't think you can have spaces in the usage for commands in terms of <>. Make it <attractienaam> not <attractie naam>.

 

i did this and i is going till the first if statement after the StringBuilder

yes it can the other commands work.

KingFaris11 Btw there is something not correct with your code...
it goed straigth to the else statement

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Dmrtje Which else statement? There are a few of them.

KingFaris11 If args.length isn't equal to 0, it has to be greater than zero I also love how you've taken his StringBuilder and coverted it to the more inefficient String concatenation yet kept the variable named sb ^^

 

AdamQpzm The last one

 

Dmrtje In that case: plugin.attracties.contains(msg) returns true, and plugin.attracties.getBoolean(msg) returns false.

 

AdamQpzm ooooow in that way

basicly what i want to do is i want to check if the file contains the msg and if the word behind it is equal to true or false if it is equal to false then i want to broadcast a message and set it to true
else if it is false i want to send the sender i message that it is already opend.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

To your first point, you never know. <- That's a joke by the way.
Second point, I didn't do this on an IDE so I couldn't be bothered to change the variable name since it'd mean that I'd have to change the others. Also, I prefer using String since imo it's more easily customised when changing spaces into commas as you can't use ".trim()" for commas can you?

 

KingFaris11 Huh? Using a StringBuilder in a loop is much more efficient, and you always get a String at the end. I don't know of any reason to concatenate Strings as opposed to something like StringBuilder other than lack of knowledge. Feel free to provide a case where you believe it's better.

 

.trim() is for removing spaces at the end of the String right?

And the way i posted at the main post?
just to be sure

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I don't see why you'd need to be efficient in a command like this. That's basically my main point.

 

KingFaris11 Because it's not overly difficult and the benefits + getting into a good habit are worth it, in my opinion. Especially considering that it was already in the more efficient version, no need to change it back, is there?

Dmrtje If you mean your StringBuilder then yes it looks fine. And yes, trim() will return the String but without the starting & ending spaces.

 

Could you maybe help me with what i am trying cause it isn't working.

 

Just to point out you can change

Code:java

if(args.length==1|| args.length>1{

)
to

Code:java

}if(args.length>=1){

I haven't looked into the actually problem yet but I will.

EDIT: Have you made sure your command executors are setup correctly? Have you made the class an instance?

EDIT 2:

Code:java

 
getCommand("addattractie").setExecutor(new addAttractieCommand());
getCommand("delattractie").setExecutor(new delAttractieCommand());
getCommand("openattractie").setExecutor(new openAttractieCommand());
getCommand("sluitattractie").setExecutor(new sluitAttracieCommand());

Try changing it to

getCommand("commandName").setExecutor(new commandClass(this));

 

Have you checked the values for this?

 

i didn't tought about that and Yes i have

 

Check my latest edit.

 

22vortex22 why should i add the this?

 

Because it is what I use and it works

 

22vortex22 Did you test it?
and where uses it this?

 

I told you where to use it and what I meant was that when I compared your executor to my other plugins I noticed yours do not have (this). Just try it out and see if it works.

 

22vortex22,
i does totally nothing except that if the msg is false that it sends me the usage of the command

 

Add some debug code then

 

It is solved it FINALY!!!!

final code:

Code:java

package me.timmaker.dmrtje.commands;
 
import me.timmaker.dmrtje.Dmrtje;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
 
public class OpenAttractieCommand implements CommandExecutor {
 
    private Dmrtje plugin;
 
    private String OpenPrefix = ChatColor.DARK_GREEN + "[" + ChatColor.GREEN
            + "Open" + ChatColor.DARK_GREEN + "] " + ChatColor.WHITE;
    private String ErrorPrefix = ChatColor.DARK_RED + "[" + ChatColor.RED
            + "Error" + ChatColor.DARK_RED + "] " + ChatColor.RESET;
 
    public OpenAttractieCommand(Dmrtje dmrtje) {
        this.plugin = Dmrtje.getInstance();
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        if (cmd.getName().equalsIgnoreCase("openattractie")) {
            if (sender.isOp() || sender.hasPermission("dmrtje.attractie.open")) {
                if (args.length == 0) {
                    sender.sendMessage(ErrorPrefix
                            + "JE MOET WEL EEN NAAM OPGEVEN!");
                    return true;
                } else if (args.length >= 1) {
                    StringBuilder sb = new StringBuilder();
                    for (int i = 0; i < args.length; i++) {
                        sb.append(args[i]);
                        sb.append(" ");
                    }
 
                    String msg = sb.toString().trim();
                    if (!plugin.attracties.contains(msg)) {
                        sender.sendMessage(ErrorPrefix
                                + "DEZE ATTRACTIE BESTAAT NIET!");
                        return true;
                    } else if (plugin.attracties.contains(msg)) {
                        if (plugin.attracties.getBoolean(msg) == false) {
                            Bukkit.broadcastMessage(OpenPrefix
                                    + "De attractie "
                                    + msg.replaceAll("&", "§") + " is geopend!");
                            plugin.attracties.set(msg, true);
                            plugin.attracties.saveConfig();
                            return true;
                        } else {
                            sender.sendMessage(ErrorPrefix
                                    + "Deze attractie is al geopend!");
                            return true;
                        }
                    }
                }
            } else
                sender.sendMessage(ErrorPrefix
                        + "Jij mag dit command niet uitvoeren!");
        }
        return false;
    }
}[/i]