KitPvP Golden Apple Drop Not Working

Hello guys! I recently got help from another member on the forums, and when I tried to do what he told me, it didn't work. I am making a kitpvp plugin for my server, but I want it so that when you die, you drop a golden apple that when you pickup, it automagically gives you the golden apple effects. Here is my code:

Code:java

package com.invictuspvp.InvictusPvP;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.GameMode;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
    public static Main plugin;
    public int number = 15;
 
    public void onEnable() {
        Bukkit.broadcastMessage(ChatColor.GREEN + "UPDATE NOTES");
        Bukkit.broadcastMessage(ChatColor.YELLOW
                + "In v1.2 of InvictusPvP Kits, by jeezerman and PistonGaming, we have successfully:");
        Bukkit.broadcastMessage(ChatColor.WHITE
                + "- Added custom names to each item");
        Bukkit.broadcastMessage(ChatColor.WHITE + "- Added permissions");
        Bukkit.broadcastMessage(ChatColor.WHITE + "- Fixed a few bugs");
    }
 
    @EventHandler
    public void onDeath(PlayerDeathEvent event) {
        event.getEntity()
                .getWorld()
                .dropItem(event.getEntity().getLocation(),
                        new ItemStack(Material.GOLDEN_APPLE, 1));
    }
 
    @SuppressWarnings("deprecation")
    public boolean onCommand(CommandSender sender, Command cmd,
            String commandLabel, String[] args) {
        Player p = (Player) sender;
        PlayerInventory inv = p.getInventory();
        if (cmd.getName().equalsIgnoreCase("archer")) {
            List<String> ls = new ArrayList<String>();
            p.sendMessage(ChatColor.GREEN + "You have selected the Archer kit!");
            p.setGameMode(GameMode.SURVIVAL);
            inv.clear();
            inv.setHeldItemSlot(1);
            p.setHealth(20);
            p.setFoodLevel(20);
            inv.setHelmet(setName(new ItemStack(Material.IRON_HELMET),
                    "Archer Helmet", ls));
            inv.setChestplate(setName(new ItemStack(Material.IRON_CHESTPLATE),
                    "Archer Chestplate", ls));
            inv.setLeggings(setName(new ItemStack(Material.IRON_LEGGINGS),
                    "Archer Leggings", ls));
            inv.setBoots(setName(new ItemStack(Material.IRON_BOOTS),
                    "Archer Boots", ls));
            ItemStack archeraxe = new ItemStack(Material.GOLD_AXE, 1);
            archeraxe.addUnsafeEnchantment(Enchantment.DAMAGE_ALL, 2);
            archeraxe.addUnsafeEnchantment(Enchantment.DURABILITY, 10);
            inv.addItem(archeraxe);
            ItemStack archerbow = new ItemStack(Material.BOW, 1);
            archerbow.addUnsafeEnchantment(Enchantment.ARROW_INFINITE, 1);
            inv.addItem(archerbow);
            ItemStack archerrod = new ItemStack(Material.FISHING_ROD, 1);
            inv.addItem(archerrod);
            ItemStack arrow = new ItemStack(Material.ARROW, 1);
            inv.addItem(arrow);
        }
        if (cmd.getName().equalsIgnoreCase("warrior")) {
            List<String> ls = new ArrayList<String>();
            p.sendMessage(ChatColor.GREEN
                    + "You have selected the Warrior kit!");
            p.setGameMode(GameMode.SURVIVAL);
            inv.clear();
            inv.setHeldItemSlot(1);
            p.setHealth(20);
            p.setFoodLevel(20);
            inv.setHelmet(setName(new ItemStack(Material.IRON_HELMET),
                    "Warrior Helmet", ls));
            inv.setChestplate(setName(new ItemStack(Material.IRON_CHESTPLATE),
                    "Warrior Chestplate", ls));
            inv.setLeggings(setName(new ItemStack(Material.IRON_LEGGINGS),
                    "Warrior Leggings", ls));
            inv.setBoots(setName(new ItemStack(Material.IRON_BOOTS),
                    "Warrior Boots", ls));
            ItemStack warriorsword = new ItemStack(Material.IRON_SWORD, 1);
            warriorsword.addUnsafeEnchantment(Enchantment.DAMAGE_ALL, 1);
            warriorsword.addUnsafeEnchantment(Enchantment.DURABILITY, 10);
            inv.addItem(warriorsword);
            ItemStack archerrod = new ItemStack(Material.FISHING_ROD, 1);
            inv.addItem(archerrod);
        }
        if (cmd.getName().equalsIgnoreCase("knight")) {
            List<String> ls = new ArrayList<String>();
            p.sendMessage(ChatColor.GREEN + "You have selected the Knight kit!");
            p.setGameMode(GameMode.SURVIVAL);
            inv.clear();
            inv.setHeldItemSlot(1);
            p.setHealth(20);
            p.setFoodLevel(20);
            inv.setHelmet(setName(new ItemStack(Material.IRON_HELMET),
                    "Knight Helmet", ls));
            inv.setChestplate(setName(new ItemStack(Material.IRON_CHESTPLATE),
                    "Knight Chestplate", ls));
            inv.setLeggings(setName(new ItemStack(Material.IRON_LEGGINGS),
                    "Knight Leggings", ls));
            inv.setBoots(setName(new ItemStack(Material.IRON_BOOTS),
                    "Knight Boots", ls));
            inv.getHelmet().addUnsafeEnchantment(
                    Enchantment.PROTECTION_ENVIRONMENTAL, 1);
            inv.getChestplate().addUnsafeEnchantment(
                    Enchantment.PROTECTION_ENVIRONMENTAL, 1);
            inv.getLeggings().addUnsafeEnchantment(
                    Enchantment.PROTECTION_ENVIRONMENTAL, 1);
            inv.getBoots().addUnsafeEnchantment(
                    Enchantment.PROTECTION_ENVIRONMENTAL, 1);
            ItemStack knightsword = new ItemStack(Material.DIAMOND_SWORD, 1);
            knightsword.addUnsafeEnchantment(Enchantment.DURABILITY, 10);
            inv.addItem(knightsword);
            ItemStack knightrod = new ItemStack(Material.FISHING_ROD, 1);
            inv.addItem(knightrod);
            ItemStack knightbow = new ItemStack(Material.BOW, 1);
            knightbow.addUnsafeEnchantment(Enchantment.ARROW_DAMAGE, 1);
            knightbow.addUnsafeEnchantment(Enchantment.ARROW_INFINITE, 1);
            inv.addItem(knightbow);
            ItemStack arrow = new ItemStack(Material.ARROW, 1);
            inv.addItem(arrow);
        }
        if (cmd.getName().equalsIgnoreCase("kits")) {
            p.sendMessage(ChatColor.RED + "" + ChatColor.BOLD + ""
                    + ChatColor.STRIKETHROUGH
                    + "---------------------------------------------");
            p.sendMessage(ChatColor.GREEN + "Default Kit(s): "
                    + ChatColor.WHITE + "Archer, Warrior");
            p.sendMessage(ChatColor.GREEN + "Donor Kit(s): " + ChatColor.WHITE
                    + "Knight");
            p.sendMessage(ChatColor.DARK_GREEN + "To change kit, type "
                    + ChatColor.WHITE + "/[kit]");
            p.sendMessage(ChatColor.RED + "" + ChatColor.BOLD + ""
                    + ChatColor.STRIKETHROUGH
                    + "---------------------------------------------");
        }
        return false;
    }
 
    private ItemStack setName(ItemStack is, String name, List<String> lore) {
        ItemMeta im = is.getItemMeta();
        if (name != null) {
            im.setDisplayName(name);
        }
        if (lore != null) {
            im.setLore(lore);
        }
        is.setItemMeta(im);
        return is;
    }
}
 

 

I can't even find when you are supposed to be adding the effects, you drop the apple but then you do nothing with it

 

I know I don't know how to do it at all. Some guy said it would work, but looking at the code all it does is "drop" a golden apple, which doesn't acutally work.

 

So the apple isn't even dropped is what you are asking to be solved?

EDIT: You haven't even registered the events, you can do that with

Code:java

        getServer().getPluginManager().registerEvents(this, this);
 

 

Well that is the first thing. But the important thing is: how to add effects to it so it automatically gives me golden apple effects, instead of me having to eat it, and also are there plugins premade to do this? an example is on playastro.net or on CanadianFries YouTube channel.

 

Listen to PlayerPickupItemEvent or PlayerItemPickupEvent idk. Then check if the type is GOLDEN_APPLE, if so, add the potion effects using event.getPlayer().addPotionEffect(new PotionEffect(BLAH, BLAH, BLAH));

 

Thank you! But still, the apple wont drop. DId I even add the EventHandler correctly? Could you make an example?

 

So you did register the event as the person previously said? Yes you did EventHandler correctly. This may not work as the player may instantly pick it up and then their inventory is cleared as they die. Maybe make a scheduler and spawn the item 10 ticks after they die.

 

Yay! Thank you for tghat Now it dropss!

Okay so, to make this clear: I added the Register Event, and now the apple drops. So, when someone kills me, an apple should be there. Whoever picks the apple up (whether it be the person who killed the other person or just some random player) should get golden apple effects for blank amount of time. Is this possible? Again, look on playastro.net or CanadianFries channel for an example.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Camaflicks Yes it is very possible, right now the apple will drop but not do anything to the person that picked it up because you haven't done anything with the PlayerPickupItemEvent yet, you will have to check the item that the player picked up and the apply the effect

 

Awesome! Thank you for all the help man! This was a little more difficult than I expected, but probably since I haven't dealt much with EventHandlers. Do you recommend any tutorials for me to get good at EventHandlers? Anyways, thank you so much! Now I can finish my plugin

 

There are a few good tutorials out there now these days I believe, I started with basic java and got into Bukkit a few months later.

The best two channels out there seem to be (in my opinion)
Pogostick: https://www.youtube.com/user/PogoStick29Dev/playlists Has a ton of stuff you can learn there!
BCBroz: https://www.youtube.com/playlist?list=PL4A0C6138F3F5AA41

Glad I could help

Camaflicks You realize there is an exact plugin like this right? http://dev.bukkit.org/bukkit-plugins/gappledrop/

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

One last question before I annyot you How do I check if it is a golden apple? Or where can I found out? Should I check the bukkit documentation?

 

Camaflicks

Code:java

ItemStack apple = new ItemStack(Material.GOLD_APPLE,1,(short)1);
//Drop item apple = god apple/super golden apple/enchanted golden apple

 

I hate myself :/ Well, on the bright side I learned more about coding!

 

Haha what a coincidence, the author of that plugin's my friend, he's an amateur at plugin developing so don't worry. I'll make sure he doesn't abandon it.

 

Than

Thanks! Funny

 

Camaflicks yeah, seems you learned quite a bit! Have fun learning and see you some other time!

 

KingFaris11
No one likes you, smart one > And yes, I'll keep it updated.

 

Cya

Did you know that I love you? LOL Thnx for the plugin

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Camaflicks
Lol no problem. Lots of people love me.