Solved player interact event doesn't work

i'am making a clock that makes people disappear

Code:java

 @EventHandler
public void interactEvent(PlayerInteractEvent e)
{
Player p = e.getPlayer();
if(p.getItemInHand() == null|| p.getItemInHand().equals(Material.AIR)) return;
ItemMeta meta1 = p.getItemInHand().getItemMeta();
meta1.setDisplayName(ChatColor.YELLOW + "Hide Players");
ItemMeta meta2 = p.getItemInHand().getItemMeta();
meta2.setDisplayName(ChatColor.YELLOW + "Show Players");
if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK)
{
if(p.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.YELLOW + "Show Players"))
{
p.getItemInHand().setItemMeta(meta1);
for(Player player : p.getWorld().getPlayers())
{
p.showPlayer(player);
}
}
if(p.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.YELLOW + "Hide Players"))
{
p.getItemInHand().setItemMeta(meta2);
for(Player player : p.getWorld().getPlayers())
{
p.hidePlayer(player);
}
}
}
}

but the interact event doesn't work right and it doesn't give an error

show doesn't work

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Tell us more about what's not working, and try debugging it first.

 

mythbusterma if i switched to Show Players then nothing happens if i right click

 

superjesse07 Loop through all the players on the server instead of in the world.
ex:

Code:java

for(Player allP : Bukkit.getOnlinePlayers()){
//Show
p.showPlayer(allP);
//Hide
p.hidePlayer(allP);
}

 

The code inside "if(p.getItemInHand().getMetaData.....)" is unrechable because there's no way the item's display name could be "ChatColor.YELLOW + 'Hide Players'" without first creating an object with that metadata.

 

FabeGabeMC still doesn't work he doesn't get that i have a item in my hand with the name Show Players

 

Did you register your event?
Dd you try debugging like just a broadcast if the interract event is being used?

 

if the watch is named Hide Players it works fine

 

superjesse07 Ah i noticed.
Make sure you set the meta first before the event triggers.
Are you trying to do this with a specific item or something? That might be the case.
Also, create the item if this (^^) is the case.

 

CraftBang id did this and both messages show up

Code:

        p.sendMessage("hi2");
        if(p.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.YELLOW + "Hide Players"))
        {
            p.sendMessage("hi");
            p.getItemInHand().setItemMeta(meta2);
            for(Player player : Bukkit.getOnlinePlayers())
            {
                p.hidePlayer(player);
            }
    }

@CraftBang @FabeGabeMC @mythbusterma found it first the code looks for a item named show players then it looks for an item named hide players i just needed to put else by the second if and then it doesn't happen

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Try use Actions.Right_click...... before checking item in hand