get blocks between two locations

i found this code on bukkit

Code:java

 public static List<Block> blocksFromTwoPoints(Location loc1, Location loc2, World w)
{
List<Block> blocks = new ArrayList<Block>();
 
int minx = Math.min(loc1.getBlockX(), loc2.getBlockX()),
miny = Math.min(loc1.getBlockY(), loc2.getBlockY()),
minz = Math.min(loc1.getBlockZ(), loc2.getBlockZ()),
maxx = Math.max(loc1.getBlockX(), loc2.getBlockX()),
maxy = Math.max(loc1.getBlockY(), loc2.getBlockY()),
maxz = Math.max(loc1.getBlockZ(), loc2.getBlockZ());
for (int x = minx; x<=maxx;x++) {
for (int y = miny; y<=maxy;y++) {
for (int z = minz; z<=maxz;z++) {
Block b = w.getBlockAt(x, y, z);
 
blocks.add(b);
}
}
}
 
return blocks;
}

but when i use it it makes a line of blocks to north
these are my location's
point1:
x: 886
y: 64
z: 297
point2:
x: 885
y: 64
z: 297
this is the loop where i set the blocks

Code:java

 for (Block b : blocksFromTwoPoints(point1, point2,p.getWorld())) {
b.setType(Material.IRON_BLOCK);
}

bumb

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Hello superjesse07.

I usually do the following when I need to select an area:

Code:java

public static List<Block> select(Location loc1, Location loc2, World w){
 
        //First of all, we create the list:
        List<Block> blocks = new ArrayList<Block>();
 
        //Next we will name each coordinate
        int x1 = loc1.getBlockX();
        int y1 = loc1.getBlockY();
        int z1 = loc1.getBlockZ();
 
        int x2 = loc2.getBlockX();
        int y2 = loc2.getBlockY();
        int z2 = loc2.getBlockZ();
 
        //Then we create the following integers
        int xMin, yMin, zMin;
        int xMax, yMax, zMax;
        int x, y, z;
 
        //Now we need to make sure xMin is always lower then xMax
        if(x1 > x2){ //If x1 is a higher number then x2
            xMin = x2;
            xMax = x1;
        }else{
            xMin = x1;
            xMax = x2;
        }
 
        //Same with Y
        if(y1 > y2){
            yMin = y2;
            yMax = y1;
        }else{
            yMin = y1;
            yMax = y2;
        }
 
        //And Z
        if(z1 > z2){
            zMin = z2;
            zMax = z1;
        }else{
            zMin = z1;
            zMax = z2;
        }
 
        //Now it's time for the loop
        for(x = xMin; x <= xMax; x ++){
            for(y = yMin; y <= yMax; y ++){
                for(z = zMin; z <= zMax; z ++){
                    Block b = new Location(w, x, y, z).getBlock();
                    blocks.add(b);
                }
            }
        }
 
        //And last but not least, we return with the list
        return blocks;
    }

Goodluck with your plugin!

 

jeussa thanks for you're code wen i tried it it still maked the long iron block line but now i have found the problem

Code:java

 final Location point1 = new Location(p.getWorld(), main.getConfig().getDouble(i + ".point1.x"), main.getConfig().getDouble(i + ".point1.y"), main.getConfig().getDouble(i + ".point1.z"));
final Location point2 = new Location(p.getWorld(), main.getConfig().getDouble(i + ".point2.x"), main.getConfig().getDouble(i + ".point2.y"), main.getConfig().getDouble(i + ".point1.2"));

the second one is wrong i need to learn that you don't copy thing's wen you're coding
i feel so stupid right now