PlayerInteractEvent (RIGHT_CLICK_BLOCK) doesn't work while holding a block item?

Hi. I've stumbled upon something strange with PlayerInteractEvent that I can't work out. When using:

Code:java

 
if(event.getAction() == Action.RIGHT_CLICK_BLOCK) {
    //do something when you right click a block
}
 

it will allow you to right click a block while holding items but not blocks. For example:

You can click a sign with your hands, clay, diamond sword, stick, diamond leggings (items) but not with a block (dirt, slab, cactus etc.).

Not sure if this is just bad coding on my behalf or an error with the craftbukkit version I'm using. It is very odd .

Thanks!

 

ThunderWaffeMC How did you test exactly?

 

Hmm.. Have you tried checking BlockPlaceEvent even though you aren't placing a block?

 

Not sure how I can check a BlockPlaceEvent for this?

Code:java

 
    public void playerInteractEvent(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        player.sendMessage("1"); //stops here when having a block in hand
        if(event.getAction() == Action.RIGHT_CLICK_BLOCK) {
            Block block = event.getClickedBlock();
            player.sendMessage("2"); //executes here when having an item or nothing in hand
            if(block.getType() == Material.SIGN || block.getType() == Material.WALL_SIGN || block.getType() == Material.SIGN_POST) {
            }
        }
    }
 

No idea why!

 

The clicked block would be event.getPlacedAgainst() which returns a Block.


I see the issue, though. You are missing the '@EventHandler' annotation above your method.

 

ThunderWaffeMC Does that mean you get the 1 message when you have a block in hand, or no message at all? If you do get the 1 message, I would suggest you output the event.getAction() so that you can see what's going on

 

Not the issue here. That was just an example ^.

 

ThunderWaffeMC It's good practice to copy the @EventHandler too, so that then other developers don't do what ZeusAllMighty11 did and assume that's the problem No discredit to Zeus of course, it's such a common mistake that it's an easy assumption to make.

 

Hmm.... It executed clicking a sign with a block as right click air but clicking another block with a block as right click block. Any ideas?

Edit: Can ZeusAllMighty11 look into this?

 

ThunderWaffeMC Hmm. Are you sure that the block you were right clicking on is actually selected?

 

Without moving, clicking with a diamond sword on a sign returns right click block. Clicking with a dirt block on a sign returns right click air. Although, clicking another block with a dirt block returns right click block.

 

The event fires just fine for me when I have a block inhand.

Code:

@EventHandler
public void onClick(PlayerInteractEvent e)
{
    Player p = e.getPlayer();
    
    if(p.getItemInHand() != null && p.getItemInHand().getType() == Material.DIRT)
    {
        System.out.println("Woohoo");
    }
 
}

 

ZeusAllMighty11 The problem ThunderWaffeMC is having is that it is apparently firing the RIGHT_CLICK_AIR rather than RIGHT_CLICK_BLOCK

 

This only fires when the block I'm clicking is a sign.

So in conclusion....
Right clicking a block while holding a block triggers right click block - working
Right clicking a sign while holding an item triggers right click block - working
Right clicking a sign while holding a block triggers right click air - BAD (not working, should trigger right click block)

ZeusAllMighty11 AdamQpzm

Edit: tried with latest recommended build and latest beta build. Same thing for both. I really don't understand but I'm taking a guess that there's something wrong with CraftBukkit.

 

Might be unrelated, but I saw strange behavior with right clicking signs while holding blocks too. What I noticed is if the block cannot be placed (standing too close, or object in the way) I wasnt getting expected results. If the block could be placed it would trigger.

Just something for you to test against your situation.

 

ThunderWaffeMC I'm not able to test it out right now, so I don't know what to tell you. It's possible that it's a bug, or maybe you'll need to go with the BlockPlaceEvent suggestion as above. In my mind though, the RIGHT_CLICK_BLOCK should happen

 

ZeusAllMighty11 Something new as well: if I stand back away from the sign a block or two then it returns right click block. It's just when I'm up close to the sign while holding a block it returns as right clicking air (that's when the block doesn't place when you right click because there's no room between you and the sign for a new block BUT if I right click with a sign up close (still a block) then it returns as right click block no matter how far away I am from the sign). Hopefully you can do something about this!

Edit: So apparently it's only returning as right clicking air when I'm in the way of the block being placed if you right click a sign. That's why it only works a block or two away but it also works when I'm standing right on the sign because the block is placed behind me.

 

I had a feeling thats what was up. I have no solution, I just learned to live with it.

Maybe someone else can help with a workaround fix.

 

Well I would definitely like a solution (if not a fix) for this in the future :/

 

ThunderWaffeMC Maybe you could check that, when they click on air, whether there's a sign within a certain range of their line of sight? Or maybe you'll have to learn to live with it, as BillyGalbreath suggested.