Solved Help with Error

I am creating a plugin that will show your balance once you click on a custom created Villager.
I was thrown a error which I can't resolve, the entire plugin looks fine and I don't receive any errors in Eclipse at all.

Here is the error I receive

Code:java

7:57:11 PM [javastacktrace] java.lang.NullPointerException
7:57:11 PM [javastacktrace]    at me.Jaaakee224.VillagerClick.VillagerClick.setupVault(VillagerClick.java:28) ~[?:?]
7:57:11 PM [javastacktrace]    at me.Jaaakee224.VillagerClick.VillagerClick.onEnable(VillagerClick.java:21) ~[?:?]
7:57:11 PM [javastacktrace]    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:250) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:350) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:389) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at org.bukkit.craftbukkit.v1_7_R1.CraftServer.loadPlugin(CraftServer.java:439) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at org.bukkit.craftbukkit.v1_7_R1.CraftServer.enablePlugins(CraftServer.java:375) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at net.minecraft.server.v1_7_R1.MinecraftServer.m(MinecraftServer.java:342) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at net.minecraft.server.v1_7_R1.MinecraftServer.g(MinecraftServer.java:319) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at net.minecraft.server.v1_7_R1.MinecraftServer.a(MinecraftServer.java:275) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at net.minecraft.server.v1_7_R1.DedicatedServer.init(DedicatedServer.java:175) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]
7:57:11 PM [javastacktrace]    at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:424) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-42-g0551358-b3015jnks]

VillagerClick (Main Class)

Code:java

package me.Jaaakee224.VillagerClick;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.event.Listener;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class VillagerClick extends JavaPlugin {
 
public static Economy econ = null;
public ConsoleCommandSender console;
 
 
@Override
public void onEnable() {
Bukkit.getServer().getPluginManager().registerEvents((Listener) new Events(), this);
 
setupVault(getServer().getPluginManager());
}
 
private void setupVault(PluginManager pm) {
Plugin vault = pm.getPlugin("Vault");
if (vault != null && vault instanceof net.milkbowl.vault.Vault) {
console.sendMessage("Loaded Vault v" + vault.getDescription().getVersion());
setupEconomy();
}
}
 
private boolean setupEconomy(){
if (Bukkit.getPluginManager().getPlugin("Vault") == null) { return false; }
console.sendMessage("Currently trying to find an economy..");
RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(Economy.class);
if (economyProvider != null) {
econ = economyProvider.getProvider();
} else {
console.sendMessage("Failed to find an economy!");
return false;
}
console.sendMessage("Economy enabled!");
return (econ != null);
}
}

Events Class

Code:java

package me.Jaaakee224.VillagerClick;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Villager;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEntityEvent;
import static me.Jaaakee224.VillagerClick.VillagerClick.*;
 
public class Events implements Listener {
 
@EventHandler
public void onPlayerClickVillager(PlayerInteractEntityEvent e) {
if(e.getRightClicked() instanceof Villager) {
Villager v = (Villager) e.getRightClicked();
String vName = v.getCustomName();
if(vName.equalsIgnoreCase("Credits")) {
e.getPlayer().sendMessage(ChatColor.GREEN + "You currently have " + econ.getBalance(e.getPlayer().getName() + " Credits."));
 
}
}
}
}

Please help, all this code is the only code in the entire project. Thank you

 

From what I can tell, your errors are on line 21 & line 28 of "VillagerClick"

Code:java

Line 21: Bukkit.getServer().getPluginManager().registerEvents((Listener) new Events(), this);
Line 28: if (vault != null && vault instanceof net.milkbowl.vault.Vault) {

I am led to think that you're not properly pointing to your listener class, which would throw the NullPointer, and that you aren't correctly looking for Vault, but, then again, I'm not the best with external plugin, so, don't take my word.

 

ZapChance What do you think can provide a fix?

 

Jaaakee224

Don't cast listener, and add this to your event class.

Code:text

private mainclass plugin;
 
public eventclass(mainclass plugin) {
    this.plugin = plugin;
}

 

ZapChance Doesn't fix it and I get the same error as before.

ZapChance Also, removing the cast to Listener will make it so the event won't work at all.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@Jaaakee224
try this:
In Events put

Code:java

public Events(VillagerClick plugin) {
plugin.getServer().getPluginManager().registerEvents(this, plugin);
}

and then replace that statement on line 21 with

Code:java

new Events(this);

You don't need a cast, if it implements it already is an instance of Listener.

That's the way I do it.
Also, replace the net.milkbowl.vault.Vault with Vault and import net.milkbowl.vault.Vault (

Code:java

import net.milkbowl.vault.Vault;

)

 

captianwolfkid

If I used

Code:java

    import net.milkbowl.vault.Vault;

What would I do with line 15 & 37

Code:java

public static Economy econ = null;

Code:java

RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(Economy.class);

Once I use the import you said it gives me an error on those lines by Eclipse.

 

Jaaakee224
try to setup your economy first then register your events

 

bump

 

You never initialize "console."

 

mmiillkkaa this?

Code:java

public ConsoleCommandSender console;

 

Jaaakee224 Yes.

 

mmiillkkaa I don't think its that because I use it with other plugins and it works fine.

 

Jaaakee224 It is not initialized and is therefore null. I recommend you replace it with Logger.

 

mmiillkkaa

Does this look good?

Code:java

package me.Jaaakee224.VillagerClick;
 
import java.util.logging.Logger;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.event.Listener;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class VillagerClick extends JavaPlugin {
 
    public static Economy econ = null;
    public Logger log;
 
 
    @Override
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents((Listener) new Events(), this);
 
        setupVault(getServer().getPluginManager());
    }
 
    private void setupVault(PluginManager pm) {
        Plugin vault = pm.getPlugin("Vault");
        if (vault != null && vault instanceof net.milkbowl.vault.Vault) {
            log.info("Loaded Vault v" + vault.getDescription().getVersion());
            setupEconomy();
        }
    }
 
    private boolean setupEconomy(){
        if (Bukkit.getPluginManager().getPlugin("Vault") == null) { return false; }
        log.info("Currently trying to find an economy..");
        RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(Economy.class);
        if (economyProvider != null) {
            econ = economyProvider.getProvider();
        } else {
            log.info("Failed to find an economy!");
            return false;
        }
        log.info("Economy enabled!");
        return (econ != null);
    }
}

 

Jaaakee224 Now give log a value.

 

mmiillkkaa Okay, so now what?

 

Jaaakee224 Now you're done.

 

mmiillkkaa Still getting the same error though.

 

Jaaakee224 Then you didn't give log a value. Post your latest code.

 

mmiillkkaa I don't see a big reason to put a value on Log, I've used the same code for other plugins which have worked.

Latest Code

Code:java

package me.Jaaakee224.VillagerClick;
 
import java.util.logging.Logger;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.event.Listener;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class VillagerClick extends JavaPlugin {
 
    public static Economy econ = null;
    public static Logger log;
 
 
    @Override
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents((Listener) new Events(), this);
 
        setupVault(getServer().getPluginManager());
        log = this.getLogger();
    }
 
    private void setupVault(PluginManager pm) {
        Plugin vault = pm.getPlugin("Vault");
        if (vault != null && vault instanceof net.milkbowl.vault.Vault) {
            log.info("Loaded Vault v" + vault.getDescription().getVersion());
            setupEconomy();
        }
    }
 
    private boolean setupEconomy(){
        if (Bukkit.getPluginManager().getPlugin("Vault") == null) { return false; }
        log.info("Currently trying to find an economy..");
        RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(Economy.class);
        if (economyProvider != null) {
            econ = economyProvider.getProvider();
        } else {
            log.info("Failed to find an economy!");
            return false;
        }
        log.info("Economy enabled!");
        return (econ != null);
    }
}

 

Jaaakee224 You use log before you set its value. Put

Code:java

log = this.getLogger()

at the top of onEnable instead of at the bottom.

 

mmiillkkaa Done

 

Jaaakee224 Does it work?

 

mmiillkkaa seems to load properly, but this happens

Code:

11:38:24 AM [INFO] [VillagerClick] Enabling VillagerClick v1.0
11:38:24 AM [INFO] [VillagerClick] Loaded Vault v1.2.31-b411
11:38:24 AM [INFO] [VillagerClick] Currently trying to find an economy..
11:38:24 AM [INFO] [VillagerClick] Failed to find an economy!

 

Jaaakee224 Do you have an economy plugin installed?

 

mmiillkkaa Yes.

 

Jaaakee224 Which?

 

mmiillkkaa http://dev.bukkit.org/bukkit-plugins/gem-economy/

 

Jaaakee224 Make sure that plugin is setting up the vault connector properly before you attempt to connect to the economy. Check if the plugin (GemEconomy) is already loaded. If not, wait for it to be loaded. You can listen to the PluginEnableEvent and check if the plugin being enabled is GemEconomy. After you find the plugin has been enabled, setup the economy.