Help With Battle Plugin

So, I wanted to make a Battle plugin, and currently adding the Custom things about it, which i was doing the medic. (Medic Desc: 'Everyone within a 6 block range will heal half-heart/0.5s.')
So, I am using this code, please tell me what i am doing wrong, Thanks.
Code:

Code:java

@SuppressWarnings("deprecation")
    @EventHandler
    public void playerMoveEvent(PlayerMoveEvent e){
        Player player = e.getPlayer();
        for(Entity ent : player.getNearbyEntities(6, 6, 6)){
        if(ent instanceof Player){
            final Player entP = (Player) ent;
        if(Class.getChosenClass(entP).equalsIgnoreCase("MEDIC")){
            getServer().getScheduler().scheduleAsyncRepeatingTask(this, new Runnable(){
 
                public void run() {
                    if(entP.getHealth() == 20) return;
                    else{
                    entP.setHealth(entP.getHealth() + 1);
                    entP.sendMessage("Yes You Have Been Healed");
                }
                }
            }, 0L, 10L);
        }
        }
        }
    }

(Just FYI, notice the 'Class.getChoosenClass', I used a capital C, so it didn't get confused with class)

 

Why are you initiating a repeating task every time a player moves?! Why not just run it onEnable, PlayerMoveEvent is called every time someone moves there camera or just moves in general. Are you getting any errors?

 

good point, just didn't know where to put the start of it, and yes i am getting errors:

Code:

[18:31:38] [Server thread/ERROR]: Could not pass event PlayerMoveEvent to Battle v0.1
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:481) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:466) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:227) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.PacketPlayInFlying.a(SourceFile:137) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.PacketPlayInPositionLook.handle(SourceFile:20) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:655) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
Caused by: java.lang.NullPointerException
    at me.James.Battle.Main.ListenerClass.playerMoveEvent(ListenerClass.java:135) ~[?:?]
    at sun.reflect.GeneratedMethodAccessor23.invoke(Unknown Source) ~[?:?]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    ... 13 more

i'm not sure if putting it in the onEnable will fix the errors, but i'll see, if you see anything else that isn't correct, just reply back, Thanks

 

Can you show me line 135 of ListenerClass.java or actually the whole class with a comment next to 135.

 

Well, i think a onPlayerJoin would be better cause i can get the player when they join, and it runs as soon as they join.

Sure,

Code:java

package me.James.Battle.Main;
 
 
import java.util.ArrayList;
import java.util.List;
 
 
 
 
 
 
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class ListenerClass extends JavaPlugin implements Listener {
 
@EventHandler
public void Death(PlayerDeathEvent e){
Player player = e.getEntity();
if(!(player.getKiller() instanceof Player)) return;
else{
Player killer = player.getKiller();
if(killer.getItemInHand().getType().equals(Material.WOOD_SWORD) || killer.getItemInHand().getType().equals(Material.STONE_SWORD) || killer.getItemInHand().getType().equals(Material.IRON_SWORD) || killer.getItemInHand().getType().equals(Material.GOLD_SWORD) || killer.getItemInHand().getType().equals(Material.DIAMOND_SWORD)){
e.setDeathMessage(ChatColor.RED + killer.getName() + ChatColor.YELLOW + " Had No Troble Murderering" + ChatColor.RED + player.getName() + ChatColor.YELLOW + " Using A " + ChatColor.AQUA + killer.getItemInHand().getItemMeta().getDisplayName());
}else if(killer.getItemInHand().getType().equals(Material.BOW)){
e.setDeathMessage(ChatColor.RED + killer.getName() + ChatColor.YELLOW + " Sniped " + ChatColor.RED + player.getName());
}
}
}
@EventHandler
public void playerChangeClass(PlayerInteractEvent e){
Player player = e.getPlayer();
if(e.getItem().getType() != null){
if(e.getItem().getType().equals(Material.NETHER_STAR)){
Inventory invin = Bukkit.createInventory(player, 9, ChatColor.BLUE + "Choose Your Class!");
ItemStack item1 = new ItemStack(Material.IRON_SWORD);
ItemMeta item1M = item1.getItemMeta();
item1M.setDisplayName(ChatColor.DARK_RED + "Barbarian");
List<String> alist1 = new ArrayList<String>();
alist1.add(ChatColor.RED + "This class is the tank of the game, with good armor");
alist1.add(ChatColor.RED + "and OK wepons to scare away enimies from team spawn.");
item1M.setLore(alist1);
item1.setItemMeta(item1M);
invin.addItem(item1);
//
ItemStack item2 = new ItemStack(Material.POTION, 1, (short) 16421);
ItemMeta item2M = item2.getItemMeta();
item2M.setDisplayName(ChatColor.GREEN + "Medic");
List<String> alist2 = new ArrayList<String>();
alist2.add(ChatColor.DARK_GREEN + "Everyone within a 6 block range will heal half-heart/0.5s.");
item2M.setLore(alist2);
item2.setItemMeta(item2M);
invin.addItem(item2);
player.openInventory(invin);
}else if(e.getItem().getType().equals(Material.EMERALD)){
Inventory invin2 = Bukkit.createInventory(player, 9, ChatColor.GOLD + "Choose Your Team!");
ItemStack item1 = new ItemStack(Material.WOOL, 1, (short) 14);
ItemMeta item1M = item1.getItemMeta();
item1M.setDisplayName(ChatColor.RED + "Red Team");
List<String> alist1 = new ArrayList<String>();
alist1.add(ChatColor.GOLD + "Join The " + ChatColor.RED + "Red " + ChatColor.GOLD + "Team!");
item1M.setLore(alist1);
item1.setItemMeta(item1M);
invin2.addItem(item1);
//
ItemStack item2 = new ItemStack(Material.WOOL, 1, (short) 11);
ItemMeta item2M = item2.getItemMeta();
item2M.setDisplayName(ChatColor.BLUE + "Team Blue");
List<String> alist2 = new ArrayList<String>();
alist2.add(ChatColor.GOLD + "Join The " + ChatColor.BLUE + "Blue " + ChatColor.GOLD + "Team!");
item2M.setLore(alist2);
item2.setItemMeta(item2M);
invin2.addItem(item2);
player.openInventory(invin2);
}else return;
}
}
@EventHandler
public void onPlayerEditInventory(InventoryClickEvent e){
Player player = (Player) e.getWhoClicked();
if(e.getInventory().getName().equals(ChatColor.BLUE + "Choose Your Class!") || e.getInventory().getName().equals(ChatColor.GOLD + "Choose Your Team!")){
player.closeInventory();
}
if(e.getInventory().getName().equalsIgnoreCase(ChatColor.BLUE + "Choose Your Class!") && e.getCurrentItem().getType().equals(Material.IRON_SWORD)){
player.sendMessage(ChatColor.GOLD + "You Have Chosen The " + ChatColor.DARK_RED + "Barbarian" + ChatColor.GOLD + " Class!");
Class.setClass("BARBARIAN", player);
}else if(e.getInventory().getName().equalsIgnoreCase(ChatColor.BLUE + "Choose Your Class!") && e.getCurrentItem().getType().equals(Material.POTION) && e.getCurrentItem().getDurability() == 16421){
player.sendMessage(ChatColor.GOLD + "You Have Chosen The " + ChatColor.DARK_GREEN + "Medic" + ChatColor.GOLD + " Class!");
Class.setClass("MEDIC", player);
}else if(e.getInventory().getName().equalsIgnoreCase(ChatColor.GOLD + "Choose Your Team!") && e.getCurrentItem().getType().equals(Material.WOOL) && e.getCurrentItem().getDurability() == 11){
player.sendMessage(ChatColor.GOLD + "You Have Joined The " + ChatColor.BLUE + "Blue" + ChatColor.GOLD + " Team!");
Team.setTeam("BLUE", player);
}else if(e.getInventory().getName().equalsIgnoreCase(ChatColor.GOLD + "Choose Your Team!") && e.getCurrentItem().getType().equals(Material.WOOL) && e.getCurrentItem().getDurability() == 14){
player.sendMessage(ChatColor.GOLD + "You Have Joined The " + ChatColor.RED + "Red" + ChatColor.GOLD + " Team!");
Team.setTeam("RED", player);
}
}
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e){
ItemStack item = new ItemStack(Material.NETHER_STAR);
ItemMeta itemM = item.getItemMeta();
itemM.setDisplayName(ChatColor.BLUE + "Choose Your Class!");
item.setItemMeta(itemM);
e.getPlayer().getInventory().addItem(item);
//
ItemStack item2 = new ItemStack(Material.EMERALD);
ItemMeta item2M = item2.getItemMeta();
item2M.setDisplayName(ChatColor.GOLD + "Choose Your Team!");
item2.setItemMeta(item2M);
e.getPlayer().getInventory().addItem(item2);
}
 
@SuppressWarnings("deprecation")
@EventHandler
public void playerMoveEvent(PlayerMoveEvent e){
Player player = e.getPlayer();
for(Entity ent : player.getNearbyEntities(6, 6, 6)){
if(ent instanceof Player){
final Player entP = (Player) ent;
if(Class.getChosenClass(entP).equalsIgnoreCase("MEDIC")){ //THIS IS LINE 125 RIGHT HERE I HOPE YOU CAN SEE THIS
getServer().getScheduler().scheduleAsyncRepeatingTask(this, new Runnable(){
 
public void run() {
if(entP.getHealth() == 20) return;
else{
entP.setHealth(entP.getHealth() + 1);
entP.sendMessage("Yes You Have Been Healed");
}
}
}, 0L, 10L);
}
}
}
}
 
 
}
 

And, the Class.java class (notice the cap C) is here:

Code:java

package me.James.Battle.Main;
 
import java.util.HashMap;
 
import org.bukkit.entity.Player;
 
public class Class {
public static HashMap<String, String> Class = new HashMap<String, String>();
 
    public static String getChosenClass(Player player){
        String team = null;
        if(Class.containsKey(player.getName() + ":BARBARIAN")){
            team = "BARBARIAN";
        }else if(Class.containsKey(player.getName() + ":MEDIC")){
            team = "MEDIC";
        }else return null;
        return team;
    }
    public static void setClass(String team, Player player){
        Class.remove(player.getName() + ":BARBARIAN");
        Class.remove(player.getName() + ":MEDIC");
        if(team.equalsIgnoreCase("BARBARIAN")){
            Class.put(player.getName() + ":BARBARIAN", null);
    }else if(team.equalsIgnoreCase("MEDIC")){
        Class.put(player.getName() + ":MEDIC", null);
    }else return;
 
}
}
 

And if that wasn't enough, here's Team.java

Code:java

package me.James.Battle.Main;
 
import java.util.HashMap;
 
import org.bukkit.entity.Player;
 
 
public class Team {
    public static HashMap<String, String> teams = new HashMap<String, String>();
 
    public static String getTeam(Player player){
        String team = null;
        if(teams.containsKey(player.getName() + ":RED")){
            team = "RED";
        }else if(teams.containsKey(player.getName() + ":BLUE")){
            team = "BLUE";
        }else return null;
        return team;
    }
    public static void setTeam(String team, Player player){
        teams.remove(player.getName() + ":RED");
        teams.remove(player.getName() + ":BLUE");
        if(team.equalsIgnoreCase("RED")){
            teams.put(player.getName() + ":RED", null);
    }else if(team.equalsIgnoreCase("BLUE")){
        teams.put(player.getName() + ":BLUE", null);
    }else return;
 
}
}

Hmmmm, if i put it in a playerJoinEvent or the onEnable, most likely they will not automatically be a medic, meaning it will fail, i need it to check every millisecond or so, so i'll just use a while loop.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

So your getChosenClass method is returning null. You need to ensure everyone has there class set when you call that method or just call a null check when you want to use the method.

Code:java

 String c = Class.getChosenClass(entP);
if(c == null){
return;
}

EDIT: In your getChosenClass method remove else return null; If its not either of the classes, team is already null so it will return null without that.

 

ah, so could i do:

Code:

if(Class.getChosenClass != null){
if(Class.getChosenClass(entP).equalsIgnoreCase("MEDIC"){
 
}
}

 

Honestly I would do something like this on your PlayerMoveEvent:

Code:java

 
    @EventHandler
    public void playerMoveEvent(PlayerMoveEvent e){
        Player p = e.getPlayer();
        String c = Class.getChosenClass(p);
        if(c == null){
            e.setCancelled(true);
            return;
        }
 
        //This will make it so you can't move until you pick your class.
        //Continue Healer class specifics
 
    }

 

OK, good idea, as this will be on a bungee cord server, it would be OK

I've also added a method so that there team and class are cleared from the HashMap on quit:

Code:java

@EventHandler
    public void onQuit(PlayerQuitEvent e){
        Team.teams.remove(((HumanEntity) e).getName() + ":BULE");
        Team.teams.remove(((HumanEntity) e).getName() + ":RED");
        Class.Class.remove(((HumanEntity) e).getName() + ":BARBARIAN");
        Class.Class.remove(((HumanEntity) e).getName() + ":MEDIC");
    }

i moved the getNearbyEntities to a onPlayerJoin, but i can't seem to download terrain, any ideas? nor can my beta tester.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Err I don't understand why you would move getNearbyEntities to onJoin can you explain?

 

well, if in onEnable, i wouldn't be able to get the player. so playerJoin would be ok, but turns out it doesn't like it. here is the updated code:

Code:java

@EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        ItemStack item = new ItemStack(Material.NETHER_STAR);
        ItemMeta itemM = item.getItemMeta();
        itemM.setDisplayName(ChatColor.BLUE + "Choose Your Class!");
        item.setItemMeta(itemM);
        e.getPlayer().getInventory().addItem(item);
        //
        ItemStack item2 = new ItemStack(Material.EMERALD);
        ItemMeta item2M = item2.getItemMeta();
        item2M.setDisplayName(ChatColor.GOLD + "Choose Your Team!");
        item2.setItemMeta(item2M);
        e.getPlayer().getInventory().addItem(item2);
        //Starts the medic healing when joined, and tests multiple times for a medic.
        while(true){
            for(Entity ent : e.getPlayer().getNearbyEntities(6, 6, 6)){
                if(ent instanceof Player){
                    final Player entP = (Player) ent;
                if(Class.getChosenClass(entP).equalsIgnoreCase("MEDIC")){
                    getServer().getScheduler().scheduleAsyncRepeatingTask(this, new Runnable(){
 
                        public void run() {
                            if(entP.getHealth() == 20) return;
                            else{
                            entP.setHealth(entP.getHealth() + 1);
                            entP.sendMessage("Yes You Have Been Healed");
                        }
                        }
                    }, 0L, 10L);
                }
                }
                }   
        }
    }

 

You could get a player onEnable. This would be in your repeating task:

Code:java

        for(Entity e: Bukkit.getServer().getWorld("WOLRDNAME").getEntities()){
            if(e instanceof Player){
                Player p = (Player)e;
                //Run healer regen skill
            }
        }

 

good point, but it wouldn't be in a 6X6X6 radius, that's the problem

 

Why not?

 

hmmm, if you could sample how that would work it would be good, thanks.

 

Every time this block of code is ran it will heal all entities around the medic for 1hp. If you want to make it only players then change the casts and instanceof check to Players only.

Code:java

        for(Entity e: Bukkit.getServer().getWorld("WOLRDNAME").getEntities()){
            if(e instanceof Player){
                Player p = (Player)e;
                String c = Class.getChosenClass(entP);
                if(c == null || !(c.equalsIgnoreCase("MEDIC"))){
                    return;
                }
                List<Entity> nearby = p.getNearbyEntities(6, 6, 6);
                for (int x = 0; x < nearby.size(); x++) {
                    if ((nearby.get(x) instanceof LivingEntity)) {
                        LivingEntity entity = (LivingEntity) nearby.get(x);
                        entity.setHealth(entity.getHealth() + 1.0);
                    }
                }
            }
        }

 

I'll try it out, but if you remember, the desc was: Everyone within a 6 block range will heal half-heart/0.5s.''

 

Then change the amount healed and change the ticks the repeating task is played. The code I gave you is meant to be put INTO a repeating task on your onENABLE method.

 

So, this is what I have implemented:

Code:java

public void onEnable(){
        getServer().getPluginManager().registerEvents(new ListenerClass(), this);
        getServer().getScheduler().scheduleAsyncRepeatingTask(this, new Runnable(){
 
            @Override
            public void run() {
                for(Entity e: Bukkit.getServer().getWorld("world").getEntities()){
                    if(e instanceof Player){
                    Player p = (Player)e;
                    String c = Class.getChosenClass((Player) e);
                    if(c == null || !(c.equalsIgnoreCase("MEDIC"))){
                    return;
                    }
                    List<Entity> nearby = p.getNearbyEntities(6, 6, 6);
                    for (int x = 0; x < nearby.size(); x++) {
                    if ((nearby.get(x) instanceof LivingEntity)) {
                    LivingEntity entity = (LivingEntity) nearby.get(x);
                    entity.setHealth(entity.getHealth() + 1.0);
                    }
                    }
                    }
                    }
 
            }
 
 
}, 0L, 10L);

Is this correct? i changed a few things around to correct it, but is it?

 

Change: String c =Class.getChosenClass((Player) e);
To: String c =Class.getChosenClass(p);

 

Changed, basically the same thing though

 

Just trying to help you understand java!

 

Ok, it works nicely, but i will soon implement that medic's won't heal enemies, and it still heals at that rate even if more than 6 block away on the X and Z

OK, a little bit more look into it, it was regenerating cause of peaceful, not the plugin, so i'm going to try and fix it so if you have any ideas, just reply, Thanks

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Add some broadcast checks to see where its goings wrong.