Solved Whats the best way to update/refresh a certain line on a scoreboard?

For example this is what i have right now in my code:

Code:java

public void addPlayer(final Player player) {
final Scoreboard board = Bukkit.getScoreboardManager().getNewScoreboard();
o = board.registerNewObjective("XaeusHub", "dummy");
o.setDisplaySlot(DisplaySlot.SIDEBAR);
o.setDisplayName(prefix);
 
int a = Bukkit.getOnlinePlayers().length;
 
o.getScore(Bukkit.getOfflinePlayer(g + b.toString() + "Online:")).setScore(5);
o.getScore(Bukkit.getOfflinePlayer(y + "" + a)).setScore(4);
o.getScore(Bukkit.getOfflinePlayer("")).setScore(3);
o.getScore(Bukkit.getOfflinePlayer(r.toString() + line.toString() + "------------")).setScore(2);
 
 
playerboards.put(player.getName(), board);
plugin.getServer().getScheduler().runTask(plugin, new Runnable() {
public void run() {
player.setScoreboard(board);
 
}
});
 
}

And i want to update the Online: when a player joins or leaves.

 

McKiller5252
To update a scoreboard, what I do in Info-Board is; I remove what the line said previously, and then readd the new line.

 

I wrote a pretty solid class for using the scoreboard as a Pixelated grid take a look at it and see if you can learn from it. http://pastebin.com/Psg4Epaq

 

xXSniperzzXx_SD
Could i have a example of what you mean, I sorta get what you getting at the point but can't picture it in my head.

 

goeiecool9999 Oh cool, you made it play the game snake on a scoreboard?

 

Yep thats exactly what I did!

 

@McKiller5252
For Info-Board I have the lines the people want on the scoreboard, and then when it's time to update them, I loop through the scoreboard and make sure that the string array in the config contains the lines on the scoreboard, if not, I remove it. Then to re-add them, I loop back through the string array from the config and see if the scoreboard contains every line from the array, if not I add it.

This way I'm not resetting the whole scoreboard everytime it goes through. Because when a server is using Spigot, it makes the scoreboard flash

https://github.com/SniperzCiinema/Info-Board/blob/master/Info Board/src/me/xxsniperzzxxsd/infoboard/Scoreboard/Update.java

Then down at the bottom of the class(I'm not the neatest coder, but I try )

 

Basicly what I did for my snake was a little less effective but still I think mineplex uses the same method. I basicly remove all the scores of the OfflinePlayers Take a look at this loop:

Code:java

                        for(OfflinePlayer p : sb.getPlayers()){
                                sb.resetScores(p);
                        }

Where sb is the scoreboard.

Also the lines are sorted by score so basicly have the top line have the highest score.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You should not be creating a new scoreboard every time a player joins or leaves. Store the scoreboard as a field, and then just get the score corresponding to the line you want updated and set it to the new value.

So, you would get the new scoreboard and do the setup once when the plugin loads, and then on the PlayerJoinEvent you update the score on the scoreboard and set the player's current scoreboard to the scoreboard you have stored. On the PlayerLeaveEvent you also update the score.

Also, if this is not on an asynchronous separate thread, you don't need to schedule a runnable.

 

I've solved it! Thanks everyone for all the help! <3