Solved Kit help :D

I am making the kit stomper and just renaming it Trampler. For whatever reason, the trampler doesnt take any damage at all. They can dish but they just dont take it. If I put the trampler into lava or hava a player repeatedly hit them it still doesnt kill them. I have no idea how to fix it. Any help?

Trampler Kit Code:

Code:java

package me.TCOB055.MultiKits;
 
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.LeatherArmorMeta;
 
public class Trampler implements CommandExecutor{
    private Main plugin;
    public Trampler(Main instance){
        plugin = instance;}
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String [] args){
        Player p = (Player) sender;
        if(commandLabel.equalsIgnoreCase("Trampler")){
            if(p.hasPermission("Trampler.use")){
                if(!plugin.kitused.contains(p.getName())){
                    if(!plugin.Trampler.contains(p.getName())){
                        plugin.Trampler.add(p.getName());
                        plugin.kitused.add(p.getName());
 
                        p.sendMessage("You have received the..." + ChatColor.GOLD+ " Trampler " + ChatColor.WHITE + "kit!");
                        p.getInventory().clear();
                        ItemStack TSword = new ItemStack(Material.STONE_SWORD, 1);
                        TSword.addEnchantment(Enchantment.DAMAGE_ALL , 1);
                        p.getInventory().addItem(TSword);
                        for (int i=0; i<32; i++){
                            p.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP ));}
                        p.getInventory().setHelmet(new ItemStack(Material.IRON_HELMET));
 
                        ItemStack ChestplateAqua = new ItemStack(Material.LEATHER_CHESTPLATE, 1);
                            LeatherArmorMeta chestplatemeta = (LeatherArmorMeta) ChestplateAqua.getItemMeta();
                            chestplatemeta.setColor(Color.AQUA);
                            ChestplateAqua.setItemMeta(chestplatemeta);
                            p.getInventory().setChestplate(ChestplateAqua);
 
                        p.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS));
 
                        p.getInventory().setBoots(new ItemStack(Material.CHAINMAIL_BOOTS));
 
 
                    } else {
                        p.sendMessage(ChatColor.RED + "You have already selected the Trampler kit!");}
                } else {
                    p.sendMessage(ChatColor.RED + "You have already selected a kit!");}
            } else {
                p.sendMessage(ChatColor.GOLD + "Donate for this kit online!");
            }
        }
        return false;
 
}
}

Event code:

Code:java

@EventHandler
    public void onPlayerDamage(EntityDamageEvent e) {
        if (e.getEntity() instanceof Player) {
                Player p = (Player) e.getEntity();
                if (plugin.Trampler.contains(p.getName())) {
                        e.setDamage((double) p.getFallDistance() / 8);
                        if (p.getFallDistance() > 3) {
                                List<Entity> nearby = p.getNearbyEntities(5, 5, 5);
                                for (Entity tmp : nearby)
                                        if (tmp instanceof Player) {
                                                ((Player) tmp).damage((double) p.getFallDistance() / 2);
                                        }
                        }
                }
        }
    }
}

Kit GUI:

Code:java

package me.TCOB055.MultiKits;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class Kit implements CommandExecutor{
        private Main plugin;
        public Kit(Main instance){
            plugin = instance;
        }
        public static Inventory kits = Bukkit.createInventory(null, 18, ChatColor.GOLD + "Kits");
 
        public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
            Player p = (Player) sender;
            if(commandLabel.equalsIgnoreCase("kit")){
                kits.clear();
                p.sendMessage(ChatColor.GREEN + "You have opened your kits!");
 
                ItemStack PvP = new ItemStack(Material.DIAMOND_SWORD);
                PvP.addEnchantment(Enchantment.DAMAGE_ALL, 1);
                ItemMeta PvPMeta = PvP.getItemMeta();
                PvPMeta.setDisplayName(ChatColor.GRAY + "PvP");
                ArrayList<String> PvPLore = new ArrayList<String>();
                PvPLore.add(ChatColor.RED + "Diamond Sword - Sharpness 1");
                PvPLore.add(ChatColor.GRAY + "Full iron armour!");
                PvPMeta.setLore(PvPLore);
                PvP.setItemMeta(PvPMeta);
                kits.setItem(0 , PvP);
 
 
 
                ItemStack Fisherman = new ItemStack(Material.FISHING_ROD);
                Fisherman.addUnsafeEnchantment(Enchantment.DURABILITY, 10);
                ItemMeta FishermanMeta = Fisherman.getItemMeta();
                FishermanMeta.setDisplayName(ChatColor.GOLD + "Fisherman");
                ArrayList<String> FishermanLore = new ArrayList<String>();
                FishermanLore.add(ChatColor.AQUA + "Stone Sword - Sharpness 1");
                FishermanLore.add(ChatColor.GOLD + "Hook your enemies and pull them to you!");
                FishermanMeta.setLore(FishermanLore);
                Fisherman.setItemMeta(FishermanMeta);
                kits.setItem(1, Fisherman);
 
                ItemStack Venom = new ItemStack(Material.SPIDER_EYE);
                Venom.addUnsafeEnchantment(Enchantment.LUCK, 1);
                ItemMeta VenomMeta = Venom.getItemMeta();
                VenomMeta.setDisplayName(ChatColor.GOLD + "Venom");
                ArrayList<String> VenomLore = new ArrayList<String>();
                VenomLore.add(ChatColor.AQUA + "Stone Sword");
                VenomLore.add(ChatColor.GREEN + "33% chance of giving poison to your enemy!");
                VenomMeta.setLore(VenomLore);
                Venom.setItemMeta(VenomMeta);
                kits.setItem(2, Venom);
 
                ItemStack Trampler = new ItemStack(Material.CHAINMAIL_BOOTS);
                Trampler.addEnchantment(Enchantment.PROTECTION_FALL, 1);
                ItemMeta TramplerMeta = Trampler.getItemMeta();
                TramplerMeta.setDisplayName(ChatColor.GOLD + "Trampler");
                ArrayList<String> TramplerLore = new ArrayList<String>();
                TramplerLore.add(ChatColor.GRAY + "Stone Sword - Sharpness 1");
                TramplerLore.add(ChatColor.GOLD + "Trample your enemies by transfering your fall damage to theirs!");
                TramplerMeta.setLore(TramplerLore);
                Trampler.setItemMeta(TramplerMeta);
                kits.setItem(3, Trampler);
 
 
 
                p.openInventory(kits);
 
 
 
            }
            return false;
        }
}
 

GUIListener:

Code:java

package me.TCOB055.MultiKits;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
 
public class GUIListener implements Listener{
    private Main plugin;
    public GUIListener(Main instance){
        plugin = instance;
    }
    @EventHandler
    public void onClick(InventoryClickEvent event){
        if ((event.getCurrentItem() != null) && (event.getCurrentItem().getItemMeta() != null)){
            Inventory inv = event.getInventory();
            Player p = (Player)event.getWhoClicked();
            if ((inv.getTitle().equals(ChatColor.GOLD + "Kits"))){
                if (event.getCurrentItem().getItemMeta().getDisplayName().equals(ChatColor.GRAY + "PvP")){
                    Bukkit.dispatchCommand(p, "PvP");
                    event.setCancelled(true);
                    p.closeInventory();
 
                }
                if (event.getCurrentItem().getItemMeta().getDisplayName().equals(ChatColor.GOLD + "Fisherman")){
                    Bukkit.dispatchCommand(p, "Fisherman");
                    event.setCancelled(true);
                    p.closeInventory();
                    }
                if (event.getCurrentItem().getItemMeta().getDisplayName().equals(ChatColor.GOLD + "Venom")){
                    Bukkit.dispatchCommand(p, "Venom");
                    event.setCancelled(true);
                    p.closeInventory();
                }
                if (event.getCurrentItem().getItemMeta().getDisplayName().equals(ChatColor.GOLD + "Trampler")){
                    Bukkit.dispatchCommand(p, "Trampler");
                    event.setCancelled(true);
                    p.closeInventory();
                }
 
        }
 
    }
 
}
}
 

 

You aren't checking if the damage is done by fall damage, therefore if their fall distance is 0 and it's divided by 8, then it will set the damage to 0, thus doing no damage at all

 

This probably sounds very noobish but how would I do that? Im very new to coding and I still have a lot to learn. Sorry. Pimp_like_me

 

TCO_007
in your PlayerDamage event do this check:

Code:java

if(e.getCause().equals(DamageCause.FALL)){
//Do stuff
}

 

Thanks guys! Its fixed now!

 

TCO_007
Yw, remember to set the topic to solved.