Integer not going any further than 1?

For some reason, the integer isn't going further than 1. Help?

Code:

Code:java

 
private Map<String, Integer> playerDeaths = new HashMap<String, Integer>();
private Map<String, Integer> playerKills = new HashMap<String, Integer>();
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent e) {
if(this.playerDeaths.containsKey(e.getEntity().getName())) {
this.playerDeaths.put(e.getEntity().getName(), this.playerDeaths.get(e.getEntity().getName() + 1));
return;
} else {
this.playerDeaths.put(e.getEntity().getName(), 1);
}
if(this.playerKills.containsKey(e.getEntity().getKiller().getName())) {
this.playerKills.put(e.getEntity().getKiller().getName(), this.playerKills.get(e.getEntity().getKiller().getName() + 1));
return;
} else {
this.playerKills.put(e.getEntity().getKiller().getName(), 1);
}
}
 

 

It's only staying at 1 because you continually put the number "1" in there. #put() doesn't add numbers, it places whatever value you provide it.

 

I agree; I would do :

Code:java

int formerDeaths = playerDeaths.get(e.getEntity().getName();
//...
this.playerDeaths.put(e.getEntity().getName(), formerDeaths + 1);

inside your onPlayerDeath method.

 

1Rogue
Hmm, then do I need to erase that bit and instead just make it add one integer everytime?

 

DaBoltLegend
in some of the put methods, you put the +1 inside the wrong parantheses

 

alex123099
Like where?

 

DaBoltLegend
I think you have a misplaced parenthesis.
Change:

Code:java

this.playerDeaths.put(e.getEntity().getName(), this.playerDeaths.get(e.getEntity().getName() + 1));

to:

Code:java

this.playerDeaths.put(e.getEntity().getName(), this.playerDeaths.get(e.getEntity().getName()) + 1);

Replicate that for your other statements.

 

Wizehh
They are. It still doesn't work.

 

Have you registered your events? What exactly is the problem/error?

 

DaBoltLegend

Code:java

 
    if(e.getEntity() instanceof Player) {
                Player pl = (Player) e.getEntity();
            int deaths = this.playerDeaths.get(pl.getName());
            this.playerDeaths.put(pl.getName(), deaths+1);
            }

 

Minesuchtiiii
Still doesn't work.

Anybody?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Well, I think we need to see an updated version of your code. But one thing I notice is your using if/else and return. That means if your Death map contains e.getEntity, Killer is not going to get updated.

 

Alshain01

Code:java

 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent e) {
if(e.getEntity() instanceof Player) {
int formerDeaths = this.playerDeaths.get(e.getEntity().getName());
int formerKills = this.playerKills.get(e.getEntity().getName());
if(this.playerDeaths.containsKey(e.getEntity().getName())) {
this.playerDeaths.get(e.getEntity().getName() + 1);
return;
} else {
this.playerDeaths.put(e.getEntity().getName(), formerDeaths + 1);
}
if(this.playerKills.containsKey(e.getEntity().getKiller().getName())) {
this.playerKills.get(e.getEntity().getKiller().getName() + 1);
return;
} else {
this.playerKills.put(e.getEntity().getKiller().getName(), formerKills + 1);
}
}
}
 

 

Part of your problem is your using the same method repeatedly. For the sake of clarity and less chance of making a mistake, when you use it that much you should just pull out into an easy to understand temp variable.

Code:java

 
private Map<String, Integer> playerDeaths = new HashMap<String, Integer>();
private Map<String, Integer> playerKills = new HashMap<String, Integer>();
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent e) {
  String dead = e.getEntity().getName();
  String killer = e.getEntity().getKiller().getName();
 
  playerDeaths.put(dead, playerDeaths.containsKey(dead) ? playerDeaths.get(dead) + 1 : 1);
  playerKills.put(killer, playerKills.containsKey(killer) ? playerKills.get(killer) + 1 : 1);
}
 

 

Alshain01
THANK YOU!