Two Problems

setBanned() Has been fixed! Thanks! Problem 1 out of 2

Both problems have been fixed! Thank you all!

So I have encountered two problems in my coding. My first one is a Gamemode Inventory, where when you click a compass, it will open up an inventory that, when clicked, will change your gamemode. Now, the code for that is perfectly fine, but there is an error whenever a player interacts with anything in their hand with something else. Let me just first show.

Code:java

 @EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
if (e.getPlayer().getItemInHand().getItemMeta() == null) return;
if (e.getPlayer().getItemInHand().getType() == Material.COMPASS) {
if (e.getAction() == Action.RIGHT_CLICK_AIR
|| e.getAction() == Action.RIGHT_CLICK_BLOCK
|| e.getAction() == Action.LEFT_CLICK_AIR
|| e.getAction() == Action.LEFT_CLICK_BLOCK) {
e.setCancelled(true);
gminv.show(e.getPlayer());
}
}
else return;
}
 
}

This works fine, but whenever I step on a pressure plate with something in my hand, I will just get a bunch of errors in the log. Does anyone know the fix?

Second problem:
setBanned() is Deprecated. Does anyone know the solution?

Code:java

final Player target = Bukkit.getServer().getPlayer(args[0]);
if (l == 2) {
target.kickPlayer(ChatColor.GOLD+"Warning> "+ChatColor.GRAY+"You have been warned for "+ChatColor.RED+msg+ChatColor.GRAY+"3/3 times. You have been temporarily banned for "+ChatColor.RED+"10 seconds"+ChatColor.GRAY+".");
target.setBanned(true);
 
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
public void run() {
target.setBanned(false);
}
}, 10 * 20);
return true;
}
 

This is just part of the code, but the setBanned will be crossed out.

 

setBanned();

Shouldnt be deprecated
Also you should ban them before you kick them. I think it matters

 

@pigeontroll
@MrAwellstein

Incorrect, good sir. It should be deprecated. Any CB version after DEV #3007, it'll be deprecated because of the ban API that mbaxter implemented. If you would like to see the commit, click here.

Anyway, OP, because of the new ban API, here is how you'd accomplish the ban:

To ban a player:

Show Spoiler Hide Spoiler

1. Get the new BanList class from the static Bukkit class or the JavaPlugin's 'getServer()' method:

Code:Java

BanList bukkitBanList = Bukkit.getBanList(BanList.Type.NAME);
 
BanList serverBanList = getServer().getBanList(BanList.Type.NAME);

Note: The parameters are either 'BanList.Type.NAME' or 'BanList.Type.IP.' If you want to ban an IP, do the IP type; if you want to ban a player by name, do the name type. Should be pretty self-explanatory.

2. To add a person to the ban list, you call the addBan method.

Code:Java

serverBanList.addBan(player.getName(), null, null, null);

Note: The first parameter must be filled in. It cannot be null. If you're banning a player by name, you'll put in the player's name. The second parameter is the ban reason. This parameter can be left null or, if you want a custom reason for banning, you'll put that in there. If it is left null, it'll default to "Banned by an operator." The third parameter is a Date object setting when the ban should expire. This too can be left null. If it is left null, it'll be interpreted as "forever." The last (fourth) object is the source of the ban. If it is left null, it'll default to "(Unknown)."

3. To release a person of their ban, you'd call the pardon function.

Code:Java

serverBanList.pardon(player.getName());

Note: It takes one parameter -- the person's name.

End Note: If you're wanting to ban someone's IP instead of their name, just replace the player's name in 'addBan' with the player's IP, and replace the player's name in 'pardon' with the player's IP again.

That should at least help you with the ban issue. If you want to check out more functions, click here to view the JavaDoc page.

 

Code:java

 
ItemStack hand = e.getPlayer.getItemInHand();
 if (hand == null || !hand.hasItemMeta()) return;
 

I'm not certain but I think getItemInHand can be null.

 

@pigeontroll I made a plugin (didn't upload it) that was a gm inventory but i used a command but i just made it on interaction with a compass and it works if you want to see code i could show you.

 

pigeontroll
You use hasItemMeta by the way, and you should check if the item in hand is null before checking item meta. I don't see the point of checking item meta though, just remove it.

 

Thanks for all the feedback! The setBanned() now works, but I still can't squash the other bug. It says that the error (on the log) is an "EventException". I've tried changing the code to this. If you know a solution, please help!

Code:java

    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        ItemStack hand = e.getPlayer().getItemInHand();
        if (hand == null || !hand.hasItemMeta()) return;
            if (!(hand.getType() == Material.COMPASS)) return;
                if (!(e.getAction() == Action.RIGHT_CLICK_AIR)
                        || !(e.getAction() == Action.RIGHT_CLICK_BLOCK)
                        || !(e.getAction() == Action.LEFT_CLICK_AIR)
                        || !(e.getAction() == Action.LEFT_CLICK_BLOCK)) return;
                    e.setCancelled(true);
                    gminv.show(e.getPlayer());
    }

 

Just for future reference, it's nice if you can attach the exact stack-trace from your logs. Also, if you could that here, it'd help.

 

Alright, I have the stack-trace.
[20:54:46 ERROR]: Could not pass event PlayerInteractEvent to MenuInv v1.0.0.0
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:320) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:486) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:471) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInte
ractEvent(CraftEventFactory.java:195) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g
85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.BlockPressurePlateBinary.e(BlockPressure
PlateBinary.java:53) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks
]
at net.minecraft.server.v1_7_R1.BlockPressurePlateAbstract.a(BlockPressu
rePlateAbstract.java:92) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022
jnks]
at net.minecraft.server.v1_7_R1.BlockPressurePlateAbstract.a(BlockPressu
rePlateAbstract.java:86) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022
jnks]
at net.minecraft.server.v1_7_R1.Entity.I(Entity.java:756) [craftbukkit.j
ar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.Entity.move(Entity.java:414) [craftbukki
t.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityLiving.e(EntityLiving.java:1210) [
craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityHuman.e(EntityHuman.java:1259) [cr
aftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityLiving.e(EntityLiving.java:1466) [
craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityHuman.e(EntityHuman.java:390) [cra
ftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityLiving.h(EntityLiving.java:1299) [
craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityHuman.h(EntityHuman.java:162) [cra
ftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.EntityPlayer.i(EntityPlayer.java:240) [c
raftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java
:342) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.PacketPlayInFlying.a(SourceFile:137) [cr
aftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.PacketPlayInPosition.handle(SourceFile:6
3) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146
) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craf
tbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:6
55) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:2
50) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:5
45) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java
:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:6
17) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
Caused by: java.lang.NullPointerException
at me.pigeontroll.menuinv.MenuInv.onPlayerInteract(MenuInv.java:29) ~[?:
?]
at sun.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1
.7.0_45]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_45]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:318) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-2-g85f5776-b3022jnks]
... 26 more
>

I was stepping on a pressure plate (that does nothing)

 

pigeontroll
For the one i have i have 2 seperate classes

Class One (The one creating the inventory) :

Code:java

public class Menu implements Listener {
 
    private Inventory inv;
    private ItemStack c, s, a;
 
    public Menu(Plugin p) {
        inv = Bukkit.getServer().createInventory(null, 9, "Choose Gamemode");
 
        c = createItem(DyeColor.GREEN, ChatColor.GREEN + "Creative Mode");
        s = createItem(DyeColor.YELLOW, ChatColor.YELLOW + "Survival Mode");
        a = createItem(DyeColor.RED, ChatColor.RED + "Adventure Mode");
 
        inv.setItem(2, c);
        inv.setItem(4, s);
        inv.setItem(6, a);
 
        Bukkit.getServer().getPluginManager().registerEvents(this, p);
    }
 
    private ItemStack createItem(DyeColor dc, String name) {
        ItemStack i = new Wool(dc).toItemStack();
        ItemMeta im = i.getItemMeta();
        im.setDisplayName(name);
        im.setLore(Arrays.asList("Set To: " + name));
        i.setItemMeta(im);
        return i;
    }
 
    public void show(Player p) {
        p.openInventory(inv);
    }
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent e) {
        if (!e.getInventory().getName().equalsIgnoreCase(inv.getName())) return;
        if (e.getCurrentItem() == null) return;
        if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Creative Mode")) {
            e.setCancelled(true);
            e.getWhoClicked().setGameMode(GameMode.CREATIVE);
            e.getWhoClicked().closeInventory();
        }
        if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Survival Mode")) {
            e.setCancelled(true);
            e.getWhoClicked().setGameMode(GameMode.SURVIVAL);
            e.getWhoClicked().closeInventory();
        }
        if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Adventure Mode")) {
            e.setCancelled(true);
            e.getWhoClicked().setGameMode(GameMode.ADVENTURE);
            e.getWhoClicked().closeInventory();
        }
    }
}

Class Two(The one opening the inventory):

Code:java

public class MenuInv extends JavaPlugin implements Listener {
 
    private Menu menu;
 
    public void onEnable() {
        menu = new Menu(this);
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
        Player p = event.getPlayer();
        if (((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK) || (event.getAction() == Action.LEFT_CLICK_AIR) || (event.getAction() == Action.LEFT_CLICK_BLOCK)) && (p.getItemInHand().getType() == Material.COMPASS)) {
            event.setCancelled(true);
            menu.show(p);   
        }   
    }
}
 

 

Do you get the error when you step on something that's not that?