Help I can't remove items from a players inventory

Hello there Bukkit, my problem is that even if I try it wont remove the golden apple from the players inventory once picked up, heres my code can someone help?

Code:

package me.BuissnessMonkey.CustomGapples;
 
import java.io.IOException;
 
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPickupItemEvent;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class ItemListener implements Listener {
   
    @EventHandler
    public void onGapplePickup(PlayerPickupItemEvent e) throws IOException{
        Player p = (Player) e.getPlayer();
        if(e.getItem().equals(Material.GOLDEN_APPLE));
        p.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 100 , 2));
        p.getInventory().remove(Material.GOLDEN_APPLE);

 

Just do

Code:

p.updateInventory();

after the remove line

 

Dosen't work tomudding, do I have to remove suppress warnings?

 

Well one of your problems is that there are no brackets surrounding your stuff... You have a completely useless if statement, what are you doing with that?

 

MonkeyPlays, Add SuppresWarning deprecation (or how it is named) And as EnderTroll68 said. Close your event with "}"

 

The inventory should be automatically updated when they open it, that is why it is marked as deprecated, as it is no longer needed. If that fixes it, then there is something wrong with your code

 

tomudding Supress warning deprecation doesn't work

tomudding and EnderTroll68, pls help it's not working

Hello?

tomudding Any idea why it's not working?

HEEEEEEELLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLO

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Please bump once every 24 hours.
Not...every...minute...

Anyway, they haven't picked it up when you're removing it. Just cancel it and delete the item entity.

 

MonkeyPlays, don't do that. I have school and work. And I coded and debugged about ± 30 minutes for you and got it working. Here is the code.

Code:java

 @EventHandler
public void PickupItem(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if (event.getItem().getItemStack().getType() == Material.GOLDEN_APPLE) {
player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 100 , 2));
event.getItem().remove();
event.setCancelled(true);
}
 
}

And don't forget to register the event.