Statistics Leaderboard

I currently have a plugin which I am trying to implement top statistics.
Here is what the stats file currently looks like:

Code:

TheFancyWhale:
  stats: 201
Dinnerbone:
  stats: 435

Is there a way to check who has the highest stats

 

Yes you can get the player with the highest stats.
First let the plugin get all the players stats, and than let him get the highest number (Stats in this case).

 

ItsLeandro I cant think of any ways to do this. Would I have to rearrange the way my config is formatted?

 

No you don't need to rearrange your config

 

ItsLeandro How would I get all the players stats without a players section?

 

The Fancy Whale Use a for loop and a hashmap like so:

Code:java

//not tested!
 
HashMap<String, Integer> stats = new HashMap<String, Integer>();
for(Player player : playersToGetStatsFrom){
stats.put(player.getName(), getConfig().getInt(player.getName() + ".stats"));
}

If you want it to just loop through everything in the config instead of for certain players:

Code:java

HashMap<String, Integer> stats = new HashMap<String, Integer>();
for(String player : getConfig().getKeys()){
    stats.put(player, getConfig().getInt(player + ".stats"));
}

 

Not working for me... I am might be using it wrong though.

 

The Fancy Whale Ah, I see my error. Where it says .getKeys(), change it to .getKeys(false) (Keep in mind I didn't test this beforehand)

Basically what it's doing is just looping through all the keys in the config, then adding them to a hashmap based on the key.

 

DonkeyTeeth2013 Still not working. Do I have to change the pLayer?

 

The Fancy Whale By "not working" do you mean you're getting errors in Eclipse or it doesn't do anything when you test it? (If you're getting errors please post them)

 

DonkeyTeeth2013 Sorry for not specifying. Errors in Eclipse

 

The Fancy Whale And what would those errors be?

 

On the first line:

Code:

Multiple markers at this line
    - Watchpoint:Main [access and modification] -
    poop
    - Syntax error on token ";", { expected after this
    token

Second Line:

Code:

Multiple markers at this line
    - Syntax error on token ")", ; expected
    - Syntax error on token(s), misplaced construct(s)
    - Return type for the method is missing
    - The method getKeys(boolean) is undefined for the type
    Main
    - Syntax error on token ".", { expected

And fourth line:

Code:

Syntax error, insert "}" to complete
MethodBody

 

The Fancy Whale Hmm, all I could say is that it's probably a problem with the surrounding code. It worked fine for me as you see in this picture:

Check the surrounding code for a missing ; or extra } or some other error.

 

DonkeyTeeth2013 Ph I forgot to put public void *MAJOR DERP*
But I am still confused how I would use this to check who has the highest.

 

The Fancy Whale This just adds everything to a hashmap so you can use it. To get the highest value, loop through the values and get the highest value, and then get the key that the value belongs to like this:

Code:java

String max = null;
int maxValueInMap=(Collections.max(stats.values())); // This will return max value in the Hashmap
for (Entry<String, Integer> entry : stats.entrySet()) { // Itrate through hashmap
if (entry.getValue()==maxValueInMap) {
max = entry.getKey();
}
}
Player player = Bukkit.getPlayer(max); //Do stuff with the player

So your entire method looks like this:

Code:java

public Player getHighestPlayer(){
HashMap<String, Integer> stats = new HashMap<String, Integer>();
for(String player : getConfig().getKeys(false)){
stats.put(player, getConfig().getInt(player + ".stats"));
}
 
String max = null;
int maxValueInMap=(Collections.max(stats.values()));
for (Entry<String, Integer> entry : stats.entrySet()) {
if (entry.getValue()==maxValueInMap) {
max = entry.getKey();
}
}
Player player = Bukkit.getPlayer(max);
return player;
}

 

"The method getKeys(boolean) in the type MemorySection is not applicable for the arguments ()"
error on line 3 on the .getKeys
"Type mismatch: cannot convert from element type Map.Entry<String,Integer> to Entry"
Error on stats.entryset

BTW Thanks sooo much for your help ive been working on this for about a month.

 

The Fancy Whale For the first error, looks like I derped again and forgot to put .getKeys(false) (I edited that in just now)
For the second error, make sure the hashmap type is <String, Integer> & the entry type is also <String, Integer>

 

When I added the .getKeys(false) it fixed the other issue as well. Thanks!

DonkeyTeeth2013 Thanks so much again and sorry one last question. Is it possible to get top 5 rather than just number 1?

DonkeyTeeth2013 Also, how would I get their name in a command. I need to take that variable and make it usable somewhere else

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

The Fancy Whale No problem If you want the top 5, just remove the key from the hashmap and look again for the next highest, and keep repeating that until you have a total of 5 players.

For your second question, do you mean get the player's name when they type a command?

 

DonkeyTeeth2013 Thanks I'll see the code I can write to get 2-5 and get back to you.
Then for the second question I mean so I have a command to get the top players. However I am not sure how to access the integer. Does that make sense sort of?

 

The Fancy Whale Simply move the hashmap outside of the method so that it's used by the entire class (make sure to clear the hashmap when you're done with it) and when you need a value just do stats.get(player.getName()), and that will return the integer of the player. So you could do:

Code:java

if(cmd.getName().equalsIgnoreCase("top")){
    player.sendMessage("§aThe top 5 players are:");
    player.sendMessage("§a1st: " + first.getName() + " - " + stats.get(first.getName()));
    player.sendMessage("§a2st: " + second.getName() + " - " + stats.get(second.getName()));
    player.sendMessage("§a3rd: " + third.getName() + " - " + stats.get(third.getName()));
    player.sendMessage("§a4th: " + fourth.getName() + " - " + stats.get(fourth.getName()));
    player.sendMessage("§a5th: " + fifth.getName() + " - " + stats.get(fifth.getName()));
    return true;
}

 

DonkeyTeeth2013 Sorry now I am even more lost. How would I take it out of the method? And remove a key?

 

Loop through your Map, check for the highest value, then check for a value that is less than or equal to(without 2nd's name), repeat this process.

 

The Fancy Whale
Instead of declaring the hashmap inside the method, put it at the top of the class like this instead:

Code:java

public HashMap<String, Integer> stats = new HashMap<String, Integer>();

and to remove a key, just do this:

Code:java

stats.remove(player.getName());

 

Can you link me to any java docs demonstrating this? I have never really worked with hashmaps before.

Do I have to dedicate a class to that then?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

The Fancy Whale
I don't know if it's allowed, but here's a link to StackOverflow.
http://stackoverflow.com/questions/109383/how-to-sort-a-mapkey-value-on-the-values-in-java

 

The Fancy Whale The HashMap javadoc. You don't really need to dedicate an entire class to it if you don't want to.
Either way, your class needs to start out like this:

Code:java

package some.package;
 
import everything.you.need;
 
public class SomeClass extends JavaPlugin{ //extend JavaPlugin if its your main class
 
public HashMap<String, Integer> stats = new HashMap<String, Integer>();

Then to get the top 5:

Code:java

public Player getHighestPlayer(){
    HashMap<String, Integer> stats = new HashMap<String, Integer>();
    for(String player : getConfig().getKeys(false)){
        stats.put(player, getConfig().getInt(player + ".stats"));
    }
 
    String max = null;
    int maxValueInMap=(Collections.max(stats.values()));
    for (Entry<String, Integer> entry : stats.entrySet()) {
        if (entry.getValue()==maxValueInMap) {
            max = entry.getKey();
        }
    }
    Player player = Bukkit.getPlayer(max);
    return player;
}
 
public List<Player> getTopFive(){
 
    List<Player> players = new ArrayList<Player>();
 
    Player first = getHighestPlayer(); //get the highest player
    players.add(first); //add the player to the list
    stats.remove(first); //remove the player from stats
 
    Player second = getHighestPlayer(); //get the next highest player
    players.add(second); //add to list
    stats.remove(second); //remove from stats
 
    //etc..
 
    return players;
 
}
 
public Player getTopPlayer(int place){
    if(place > 5) //you don't have places larger than 5 so you don't want people to ask for those
        throw new IndexOutOfBoundsException();
    return getTopFive().get(place - 1); //get the corresponding place in the list (java starts at zero so you subtract 1)
}

Just continue the code from getTopFive(), and then all you have to do to get a certain player is getTopPlayer(place)
So if you wanted the 3rd place player, you do: getTopPlayer(3);
I inserted a few comments so you can tell what each thing does

 

DonkeyTeeth2013 That is working perfectly except I still can't use the variables. Again thanks so much!

 

when i use the getTopPlayer method, it always returns the same player, no matter what their score is

edit:

I think this is because of this:

Code:java

for(String player : Main.getPlugin().getConfig().getKeys(false)){
            stats.put(player, Main.getPlugin().getConfig().getInt(player + ".Kills"));
        }

every time the getHighestPlayer() method is called, it re adds all the players back in, so everytime you do this, Player first = getHighestPlayer(); it readds the players back in and stats.remove(first); is pointless. Not sure how to fix tho :/