Solved Why won't this work?

Trying to toggle clouds if player is flying. If i use /toggleclouds on it will only display "Clouds enabled"

Code:java

    ArrayList <Player> flying = new ArrayList<Player>();
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
        if(sender instanceof Player)
        {
            Player player = (Player) sender;
            if(commandLabel.equalsIgnoreCase("toggleclouds"))
            {
                if(args.length == 0)
                {
                    if(flying.contains(player))
                    {
                        flying.remove(player);
                    }
                    else
                    {
                        flying.add(player);
                    }
                }
                else
                {
                    boolean toggle = false;
                    if(args[0].equalsIgnoreCase("on"))
                    {
                        toggle = true;
                    }
                    if(toggle && !flying.contains(player))
                    {
                        flying.add(player);
                    }
                    else if(toggle)
                    {
                        player.sendMessage("Clouds enabled");
                    }
                    else if(!toggle && flying.contains(player))
                    {
                        flying.remove(player);
                    }
                    else if(!toggle)
                    {
                        player.sendMessage("Clouds disabled");
                    }
                }
            }
        }
 
        return false;
    }

 

GreatMinerZ You also need to show clouds...

 

stirante

Code:java

    @EventHandler
    public void onPlayerFly(PlayerMoveEvent e) {
        Player p = e.getPlayer();
        Location location = p.getLocation();
 
            if(p.isFlying()){
 
            ParticleEffects.sendToLocation(ParticleEffects.CLOUD, location, 0.5F, 0.5F, 1.0F, 0, 20);
 
        }
    }

 

GreatMinerZ Check if you registered event.

 

stirante did that the clouds work fine but the command doesnt

 

GreatMinerZ Your going to cause a memory leak if you save the player object instead save the players name.

 

GreatMinerZ Change if(p.isFlying()){ to if(p.isFlying() && flying.contains(p)){

But as hamzaxx said don't save Player object. Save player's name instead.

 

hamzaxx stirante Changed if(p.isFlying()){ to if(p.isFlying() && flying.contains(p)){ But the only problem now is that flying.add(player.getName()); is giving the following error: "The method add(Player) in the type ArrayList is not applicable for the arguments (String)

 

GreatMinerZ Change generic parameter of list from Player to String

 

stirante Clouds don't show anymore. I think it's because of if(p.isFlying() && flying.contains(p)) {

Code:

Code:java

    ArrayList <String> flying = new ArrayList<String>();
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
        if(sender instanceof Player)
        {
            Player player = (Player) sender;
            if(commandLabel.equalsIgnoreCase("toggleclouds"))
            {
                if(args.length == 0)
                {
                    if(flying.contains(player.getName()))
                    {
                        flying.remove(player.getName());
                    }
                    else
                    {
                        flying.add(player.getName());
                    }
                }
                else
                {
                    boolean toggle = false;
                    if(args[0].equalsIgnoreCase("on"))
                    {
                        toggle = true;
                    }
                    if(toggle && !flying.contains(player.getName()))
                    {
                        flying.add(player.getName());
                    }
                    else if(toggle)
                    {
                        player.sendMessage("Clouds enabled");
                    }
                    else if(!toggle && flying.contains(player.getName()))
                    {
                        flying.remove(player.getName());
                    }
                    else if(!toggle)
                    {
                        player.sendMessage("Clouds disabled");
                    }
                }
            }
        }
 
        return false;
    }
 
    @EventHandler
    public void onPlayerFly(PlayerMoveEvent e) {
        Player p = e.getPlayer();
        Location location = p.getLocation();
 
        if(p.isFlying() && flying.contains(p)) {
 
            ParticleEffects.sendToLocation(ParticleEffects.CLOUD, location, 0.5F, 0.5F, 1.0F, 0, 20);
 
        }
    }
 
}

 

GreatMinerZ use flying.contains(p.getName())

 

stirante Thanks, works fine now!