Solved [HELP] Give player sword on login not working

For some reason in my code for a simple plugin, all my events aren't working meaning when I upload the plugin and put it in my server, it has no errors or anything but just nothing works lol.

Here's a snip of the first part of my code:

Code:java

package me.creepah.LegionsCore;
 
import java.util.List;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.Sound;
import org.bukkit.World;
import org.bukkit.entity.Item;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.event.player.PlayerDropItemEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerPickupItemEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class LegionsCore extends JavaPlugin
{
  public void onEnable()
  {
  }
 
  public void onDisable()
  {
  }
 
  @EventHandler
  public static void TradeChat(AsyncPlayerChatEvent event)
  {
    String Prefix = event.getMessage().split(" ")[0];
    if ((Prefix.equalsIgnoreCase("WTS")) || (Prefix.equalsIgnoreCase("WTB")) || (Prefix.equalsIgnoreCase("WTT")) || (Prefix.equalsIgnoreCase("PC")) || (Prefix.equalsIgnoreCase("Sell")) || (Prefix.equalsIgnoreCase("Price Check")) || (Prefix.equalsIgnoreCase("Buy")) || (Prefix.equalsIgnoreCase("Selling")) || (Prefix.equalsIgnoreCase("Buying")))
      event.setFormat("&3&l<T> &f" + event.getPlayer().getName() + "&7: " + event.getMessage());
  }
 
  @EventHandler
  public void UnDrop(PlayerDropItemEvent event) {
    if ((event.getItemDrop().getItemStack().hasItemMeta()) &&
      (event.getItemDrop().getItemStack().getItemMeta().hasLore()) &&
      (event.getItemDrop().getItemStack().getItemMeta().getLore().contains(ChatColor.GRAY + "Untradeable"))) {
      event.getItemDrop().remove();
      event.getPlayer().sendMessage(ChatColor.GRAY + "The item was untradeable so it has vanished.");
      event.getPlayer().getWorld().playSound(event.getPlayer().getLocation(), Sound.FIZZ, 0.0F, 0.0F);
    }
  }

 

Register them... onEnable do this code:

Code:

        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(this, this);

 

Also, you have too many brackets.

 

Not sure if I did this right...

Code:java

public class LegionsCore extends JavaPlugin
{
    public void onEnable()
    {
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents((Listener) this, this);
    }
 
    public void onDisable()
    {
    }

 

CreepahMC dont do the (Listener) thing just add "implements Listener" next to extends JavaPlugin

 

Oo-Zakk-oO You forgot to tell CreepahMC that he needs to implement listener..

Code:java

public class LegionsCore extends JavaPlugin implements listener {

 

thats what i did? but same thing anyways!

 

CreepahMC http://wiki.bukkit.org/Plugin_Tutorial shows you everything you need

 

So I have an event to repair your armor and weapon to full dura when you take damage and attack mobs/players.
When attacking, it repairs the armor but taking damage doesn't. Any idea? What's really weird is that my helmet takes 0 dura on damage so everything else but my helmet is taking durability when hit by mob/player.

Dura Code:

Code:java

 @EventHandler
public void HitRepair(PlayerInteractEvent event) { event.getPlayer().setFoodLevel(20);
if (event.getPlayer().getInventory().getBoots() != null) {
event.getPlayer().getInventory().getBoots().setDurability((short) 0);
}
if (event.getPlayer().getInventory().getLeggings() != null) {
event.getPlayer().getInventory().getLeggings().setDurability((short) 0);
}
if ((event.getPlayer().getInventory().getItemInHand().getTypeId() == 283) || (event.getPlayer().getInventory().getItemInHand().getTypeId() == 286) || (event.getPlayer().getInventory().getItemInHand().getTypeId() == 267)) {
event.getPlayer().getItemInHand().setDurability((short) 0);
event.getPlayer().updateInventory();
}
if (event.getPlayer().getInventory().getChestplate() != null) {
event.getPlayer().getInventory().getChestplate().setDurability((short) 0);
}
if (event.getPlayer().getInventory().getHelmet() != null)
event.getPlayer().getInventory().getHelmet().setDurability((short) 0); }
 
@EventHandler
public void DamageRepair(EntityDamageEvent event) {
if ((event.getEntity() instanceof Player)) {
Player s = (Player)event.getEntity();
if (s.getInventory().getBoots() != null) {
s.getInventory().getBoots().setDurability((short) 0);
}
if (s.getInventory().getLeggings() != null) {
s.getInventory().getLeggings().setDurability((short) 0);
}
if ((s.getInventory().getItemInHand().getTypeId() == 283) || (s.getInventory().getItemInHand().getTypeId() == 286) || (s.getInventory().getItemInHand().getTypeId() == 267)) {
s.getItemInHand().setDurability((short) 0);
s.updateInventory();
}
if (s.getInventory().getChestplate() != null) {
s.getInventory().getChestplate().setDurability((short) 0);
}
if (s.getInventory().getHelmet() != null) {
s.getInventory().getHelmet().setDurability((short) 0);

 

Few tips:
1) Save yourself some typing:

Code:java

 
ItemStack boots = event.getPlayer().getInventory().getBoots();
if (boots != null) {
   boots.setDurability((short) 0);
}

2) Try using the "EntityDamageByEntity" event

Best Regards,
Maximvdw

 

Thanks! That fixed my dura! Any idea on why this won't give me a sword on login?

Code:java

  @EventHandler(priority=EventPriority.MONITOR)
  public void BasicJoin(PlayerJoinEvent event) { if (!event.getPlayer().hasPlayedBefore()) {
        ItemStack Sword = new ItemStack(Material.WOOD_SWORD);
        ItemMeta SwordMeta = Sword.getItemMeta();
        ArrayList SwordLore = new ArrayList();
        SwordMeta.setDisplayName(ChatColor.WHITE + "Training Sword");
        SwordLore.add(ChatColor.RED + "DMG: +" + plugin.rand(5, 7) + " - " + plugin.rand(10, 12));
        SwordLore.add(ChatColor.GRAY + "Untradeable");
        SwordMeta.setLore(SwordLore);
        Sword.setItemMeta(SwordMeta);
        event.getPlayer().getInventory().addItem(new ItemStack[] { Sword });
    }
  }
}

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I would set the item at slot (get some blank slot) instead of adding items.

 

Try this

Code:

event.getPlayer().getInventory().addItem(Sword);

 

Still not working. I think it's the event since I get an error stating it can't understand the PlayerJoinEvent.

Error:

Code:

 [SEVERE] Could not pass event PlayerJoinEvent to LegionsCore v1.0
01:21:55 org.bukkit.event.EventException
01:21:55 at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
01:21:55 at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
01:21:55 at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
01:21:55 at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
01:21:55 at net.minecraft.server.v1_6_R3.PlayerList.c(PlayerList.java:207)
01:21:55 at net.minecraft.server.v1_6_R3.PlayerList.a(PlayerList.java:103)
01:21:55 at net.minecraft.server.v1_6_R3.PendingConnection.e(PendingConnection.java:132)
01:21:55 at net.minecraft.server.v1_6_R3.PendingConnection.d(PendingConnection.java:43)
01:21:55 at net.minecraft.server.v1_6_R3.DedicatedServerConnectionThread.a(DedicatedServerConnectionThread.java:41)
01:21:55 at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:29)
01:21:55 at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
01:21:55 at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
01:21:55 at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
01:21:55 at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
01:21:55 at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
01:21:55 Caused by: java.lang.Error: Unresolved compilation problems:
01:21:55 plugin cannot be resolved
01:21:55 plugin cannot be resolved
01:21:55 at me.creepah.LegionsCore.LegionsCore.BasicJoin(LegionsCore.java:113)
01:21:55 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
01:21:55 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
01:21:55 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
01:21:55 at java.lang.reflect.Method.invoke(Method.java:606)
01:21:55 at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
01:21:55 ... 14 more
01:21:59  [INFO] CreepahPlaysMC issued server command: /clear
01:22:31  [INFO] Connection reset
01:23:23  [FINEST] [WGCustomFlags] Saving flags for world InfernalRealms
01:23:23  [FINEST] [WGCustomFlags] Saving flags for world InfernalRealms_the_end
01:23:23  [FINEST] [WGCustomFlags] Saving flags for world Nordic
01:23:23  [FINEST] [WGCustomFlags] Saving flags for world rpg

Java Code:

Code:java

    @EventHandler(priority=EventPriority.MONITOR)
      public void BasicJoin(PlayerJoinEvent event) { if (!event.getPlayer().hasPlayedBefore()) {
          ItemStack Sword = new ItemStack(Material.WOOD_SWORD);
          ItemMeta SwordMeta = Sword.getItemMeta();
          ArrayList SwordLore = new ArrayList();
          SwordMeta.setDisplayName(ChatColor.WHITE + "Shortsword");
          SwordLore.add(ChatColor.RED + "DMG+" + plugin.rand(5, 7) + " - " + plugin.rand(10, 12));
          SwordLore.add(ChatColor.GRAY + "Untradeable");
          SwordMeta.setLore(SwordLore);
          Sword.setItemMeta(SwordMeta);
          event.getPlayer().getInventory().addItem(Sword);
 
    }
  }
 
}

 

You have a public variable called plugin? if so where is it?

 

Not sure why I had it. I removed it and set a method for rand to be and integer and it seemed to not cause errors on save and on reload/login. Still no sign of a wooden sword.

Also

How could I add it to where the itemLore can have to types of chat color meaning a word can be Bold and a color.

 

Try delaying the sword giving for like 10 ticks. And make sure to delete your player.dat since you check if he is new

About Bold and color. The way you do it already.

ChatColor.RED + ChatColor.BOLD + "Bolden red text"

 

Ok thanks! I'll try it out!

Well the chat color red/bold didn't work; it gave off an error but not a big deal. The sword worked but when it gave it to me it said DMG: null-null. I meant it to say a random integer between the 2 (5-7 for the first). Am I doing this wrong?

Code:java

SwordMeta.setDisplayName(ChatColor.WHITE + "Shortsword");
    SwordLore.add(ChatColor.RED + "DMG+" + rand(5, 7) + "-" + rand(10, 12));
    SwordLore.add(ChatColor.GRAY + "Untradeable");

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

CreepahMC
Stop bumping your thread every 2 hours.

Show your whole code. Also, please learn java properly, as well as the Bukkit API and get familiar with basic debugging, your code has horrible readability.