Solved EntityDamageEntityEvent PvP

Hello,

I am writing a plugin that disables PvP for a person when the respawn for a set amount of time given in the config file. It needs to stop the protected player from being hit and hitting others.

Anytime a player hits another player I am getting an error which I don't fully understand what it's telling me.

My code stops a protected player from being hit even though it gives the error in console, but it is not stopping a protected player from hitting other. (it tells the player that they can't do it, but the event isn't canceled).

Code:java

public boolean isProtected(Player player) {
        if ((protections.get(player.getName()) < (System.currentTimeMillis() - (getConfig().getInt("protectionTime")) * 1000))) {
            return false;
        } else {
            return true;
        }
    }
 
    public void activateProtection(Player player) {
        protections.put(player.getName(), System.currentTimeMillis());
        player.sendMessage("You are protected from pvp");
    }
 
    @EventHandler
    public void onPvp(EntityDamageByEntityEvent event) {
        if (getConfig().getBoolean("protectionEnabled")) {
            if (event.getEntity() instanceof Player) {
                if (event.getDamager() instanceof Player) {
                    Player damager = (Player) event.getDamager();
                    Player damaged = (Player) event.getEntity();
 
                    if(isProtected(damaged)) {
                        event.setCancelled(true);
                        damager.sendMessage("He is protected");
                    }
 
                    if(isProtected(damager)) {
                        event.setCancelled(true);
                        damager.sendMessage("You are protected!");
                    }
 
 
                }
            }
        }
    }
 
    @EventHandler
    public void onRespawn(PlayerRespawnEvent event) {
        activateProtection(event.getPlayer());
    }
 
....

Code:

[00:00:11] [Server thread/ERROR]: Could not pass event EntityDamageByEntityEvent to PvPShield v1.0
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:481) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:466) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callEvent(CraftEventFactory.java:94) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:382) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:410) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.EntityLiving.damageEntity(EntityLiving.java:656) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.EntityHuman.damageEntity(EntityHuman.java:746) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.EntityPlayer.damageEntity(EntityPlayer.java:446) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.EntityHuman.attack(EntityHuman.java:918) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:1092) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.PacketPlayInUseEntity.a(SourceFile:55) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.PacketPlayInUseEntity.handle(SourceFile:10) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:655) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
Caused by: java.lang.NullPointerException
    at com.daawsomest.shield.PvPShield.isProtected(PvPShield.java:43) ~[?:?]
    at com.daawsomest.shield.PvPShield.onPvp(PvPShield.java:63) ~[?:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_45]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_45]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_45]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_45]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
    ... 20 more

 

Show us more code..

 

And in the code you gave us I can't tell what line is 43

 

Line 63 is: if ((protections.get(player.getName()) < (System.currentTimeMillis() - (getConfig().getInt("protectionTime")) * 1000))) {

Code:java

package com.daawsomest.shield;
 
import java.util.HashMap;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
import org.bukkit.event.player.PlayerRespawnEvent;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class PvPShield extends JavaPlugin implements Listener {
 
    HashMap<String, Long> protections = new HashMap<String, Long>();
    List<String> commandList;
 
    public void onEnable() {
        getLogger().info("PvP Shield was enabled!");
 
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(this, this);
 
        getConfig().options().copyDefaults(true);
        this.saveConfig();
 
        commandList = getConfig().getStringList("blockedCommands");
 
    }
 
    public void onDisable() {
        //this.saveDefaultConfig();
        getLogger().info("PvP Shield was disabled!");
    }
 
    public boolean isProtected(Player player) {
        if ((protections.get(player.getName()) < (System.currentTimeMillis() - (getConfig().getInt("protectionTime")) * 1000))) { //LINE43/////////////////////////////// 
            return false;
        } else {
            return true;
        }
    }
 
    public void activateProtection(Player player) {
        protections.put(player.getName(), System.currentTimeMillis());
        player.sendMessage("You are protected from pvp");
    }
 
    @EventHandler
    public void onPvp(EntityDamageByEntityEvent event) {
        if (getConfig().getBoolean("protectionEnabled")) {
            if (event.getEntity() instanceof Player) {
                if (event.getDamager() instanceof Player) {
                    Player damager = (Player) event.getDamager();
                    Player damaged = (Player) event.getEntity();
 
                    if(isProtected(damaged)) {//LINE 63
                        event.setCancelled(true);
                        damager.sendMessage("He is protected");
                    }
 
                    if(isProtected(damager)) {
                        event.setCancelled(true);
                        damager.sendMessage("You are protected!");
                    }
 
 
                }
            }
        }
    }
 
    @EventHandler
    public void onRespawn(PlayerRespawnEvent event) {
        activateProtection(event.getPlayer());
    }
 
    @EventHandler
    public void onPlayerCommandPreProcess(PlayerCommandPreprocessEvent event) {
        Player player = event.getPlayer();
        String cmd = event.getMessage();
        String[] cmdArgs = cmd.split(" ");
 
        if (isProtected(player)) { //LINE
            if (commandList.contains(cmdArgs[0])) {
                event.setCancelled(true);
                player.sendMessage(ChatColor.RED + "You can not use this command while protected");
            }
        }
    }
 
    @SuppressWarnings("unchecked")
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        Player player = (Player) sender;
 
        if (cmd.getName().equalsIgnoreCase("shield")) {
 
            if (args.length == 1) {
                if (args[0].equalsIgnoreCase("on")) {
                    if(player.hasPermission("shield.admin")) {
                        activateProtection(player);
                    }    else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }
                }
 
                else if (args[0].equalsIgnoreCase("time")) {
                    if(player.hasPermission("shield.admin")) {
                        player.sendMessage(ChatColor.YELLOW + "Protection time is set to " + Integer.toString(getConfig().getInt("protectionTime")) + " seconds");
                    } else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }
                }
 
                else if (args[0].equalsIgnoreCase("cancel")) {
                    if (isProtected(player)) {
                        protections.put(player.getName(), new Long(0));
                        player.sendMessage(ChatColor.GREEN + "Protection was canceled");
                    } else {
                        player.sendMessage(ChatColor.RED + "You have no current protections!");
                    }
                }
 
                else if (args[0].equalsIgnoreCase("enable")) {
                    if(player.hasPermission("shield.admin")) {
                        getConfig().set("protectionEnabled", true);
                        saveConfig();
                        player.sendMessage(ChatColor.GREEN + "Shields enabled");
                    } else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }   
                }
 
                else if (args[0].equalsIgnoreCase("disable")) {
                    if(player.hasPermission("shield.admin")) {
                        getConfig().set("protectionEnabled", false);
                        saveConfig();
                        player.sendMessage(ChatColor.GREEN + "Shields disabled");
                    }    else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }
                }
            }
 
            else if (args.length == 2) {
                if (args[0].equalsIgnoreCase("on")) {
                    if(player.hasPermission("shield.admin")) {
                        Player whoToProtect = Bukkit.getServer().getPlayer(args[1]);
                        activateProtection(whoToProtect);
                    }    else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }
                }
 
                else if (args[0].equalsIgnoreCase("add")) {
                    if(player.hasPermission("shield.admin")) {
                        if (args[1].contains("/")) {
                            ((List<String>) getConfig().getList("blockedCommands")).add(args[1]);
                            this.saveConfig();
                            player.sendMessage(ChatColor.YELLOW + args[1] + ChatColor.GREEN + " was add to command list");
                        }
                        else {
                            player.sendMessage(ChatColor.RED + "Please use a valiad command");
                        }
                    }   
 
                    else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }
                }
 
                else if (args[0].equalsIgnoreCase("remove")) {
                    if(player.hasPermission("shield.admin")) {
                        if (args[1].contains("/")) {
                            ((List<String>) getConfig().getList("blockedCommands")).remove(args[1]);
                            this.saveConfig();
                            player.sendMessage(ChatColor.YELLOW + args[1] + ChatColor.GREEN + " was removed from command list");
                        }
                        else {
                            player.sendMessage(ChatColor.RED + "Please use a valiad command");
                        }
                    }
                }
            }
 
            else if (args.length == 3) {
                if (args[0].equalsIgnoreCase("time") && args[1].equalsIgnoreCase("set")) {
                    if(player.hasPermission("shield.admin"));
                        int seconds;
 
                        try {
                            seconds = Integer.parseInt(args[2]);
                            getConfig().set("protectionTime", seconds);
                            saveConfig();
                            player.sendMessage(ChatColor.GREEN + "Protection time set to " + Integer.toString(seconds) + " seconds");
                        } catch (NumberFormatException ex) {
                            player.sendMessage(ChatColor.RED + "Invalid time");
                        }
                    } else {
                        player.sendMessage(ChatColor.RED + "You do not have permission to do that");
                    }               
                }
            }
 
            else {
                player.sendMessage("incorrect args");
            }
        return true;
    }
}
 

 

You're trying to use a Player in a HashMap of Strings and Longs :/

 

From what I can see this is your problem:

Code:java

if((protections.get(player.getName())<(System.currentTimeMillis()-(getConfig().getInt("protectionTime"))*1000))){//LINE43///////////////////////////////

Why? This if is being called regardless of whether the player has respawned or not.
Before this, you need to check:
if (protections.get(player.getName()).exists)) = true {
}
^ please don't copy pasta the bit above, exists might need brackets... exists()
if it doesn't exist, return false, otherwise continue with code

 

DreadTank27 Tster Thanks for the replies. I'll try to fix it up tomorrow.

I just had a look and i used player.getName() which returns the players name as a string.

I tried protections.get(player.getName()).exist() and protections.get(player.getName()).exist but neither of them work.

EDIT:
Could I do it like this?

Code:java

 public boolean isProtected(Player player) {
if(protections.containsKey(player.getName())) {
if ((protections.get(player.getName()) < (System.currentTimeMillis() - (getConfig().getInt("protectionTime")) * 1000))) {
return false;
} else {
return true;
}
} else {
return false;
}
}

EDIT EDIT:
Yes that worked and fixed everything

EDIT by Moderator: merged posts, please use the edit button instead of double posting.