Solved Why is this not working?

Hello Everyone,

I am making a plugin and when I went to test it none of my events were firing. I put debug lines in but none of them showed up. I checked to see if I registered my events and I did. I even checked at other projects of mine but they looked exactly the same. I have no idea what I am doing wrong. Here is my class:

Code:java

package me.pieman.eggs;
 
import java.util.ArrayList;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.block.Sign;
import org.bukkit.entity.Egg;
import org.bukkit.entity.Player;
import org.bukkit.entity.Projectile;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.entity.ProjectileHitEvent;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Eggs extends JavaPlugin implements Listener {
 
    public Eggs plugin;
 
    public ArrayList<String> player = new ArrayList<String>();
 
    public ArrayList<Location> mine = new ArrayList<Location>();
 
    public ArrayList<Location> bomb = new ArrayList<Location>();
 
    public static Economy econ = null;
 
    public void onEnable(){
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
        if (!setupEconomy() ) {
            getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
    }
 
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
 
    @EventHandler
    public void onProjectileHit(ProjectileHitEvent e){
        Projectile p = e.getEntity();
        if(!(p instanceof Egg)) return;
        Egg egg = (Egg) p;
        if(egg.hasMetadata("grenade")){
            double eggx = egg.getLocation().getX();
            double eggy = egg.getLocation().getY();
            double eggz = egg.getLocation().getZ();
            egg.getWorld().createExplosion(eggx, eggy, eggz, 4F, false, false);
            return;
        }
        if(egg.hasMetadata("landmine")){
            Player shooter = (Player) egg.getShooter();
            shooter.sendMessage(ChatColor.GREEN + "LandMine placed!");
            Block b = egg.getLocation().getBlock();
            mine.add(b.getLocation());
            return;
        }
        if(egg.hasMetadata("bomb")){
            final Player shooter = (Player) egg.getShooter();
            final Block b = egg.getLocation().getBlock();
            bomb.add(b.getLocation());
            Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable(){
                public void run(){
                    if(player.contains(shooter.getName())){
                        b.getWorld().createExplosion(b.getX(), b.getY(), b.getZ(), 4F, true, true);
                        bomb.remove(b.getLocation());
                        Bukkit.getServer().getScheduler().cancelTasks(plugin);
                        return;
                    }
                    shooter.sendMessage(ChatColor.GREEN + "Bomb is going off in 10 seconds!");
                    player.add(shooter.getName());
                }
            }, 20 * 10, 20 * 10);
        }
    }
 
    @EventHandler
    public void onPlayerMove(PlayerMoveEvent e){
        Player p = e.getPlayer();
        ArrayList<Location> mine = this.mine;
        for(Location mloc : mine){
            Location ploc = p.getLocation();
            if(ploc.getX() == mloc.getX() && ploc.getY() == mloc.getY() && ploc.getX() == mloc.getX()){
                mloc.getWorld().createExplosion(ploc.getX(), ploc.getY(), ploc.getZ(), 4F, false, false);
                mine.remove(mloc);
            }
        }
    }
 
    @SuppressWarnings("deprecation")
    public void openInventory(Player p){
        Inventory inv = Bukkit.createInventory(null, 9, "Bomb Factory");
 
        ItemStack grenade = new ItemStack(Material.EGG);
        ItemMeta gmeta = grenade.getItemMeta();
        ArrayList<String> g = new ArrayList<String>();
        g.add(ChatColor.DARK_AQUA + "Cost: " + getConfig().getDouble("grenadeprice"));
        gmeta.setLore(g);
        gmeta.setDisplayName(ChatColor.GREEN + "Grenade");
        grenade.setItemMeta(gmeta);
 
        ItemStack bomb = new ItemStack(Material.EGG);
        ItemMeta bmeta = bomb.getItemMeta();
        ArrayList<String> b = new ArrayList<String>();
        b.add(ChatColor.DARK_AQUA + "Cost: " + getConfig().getDouble("bombprice"));
        bmeta.setLore(b);
        bmeta.setDisplayName(ChatColor.GREEN + "Bomb");
        bomb.setItemMeta(bmeta);
 
        ItemStack landmine = new ItemStack(Material.EGG);
        ItemMeta lmeta = landmine.getItemMeta();
        ArrayList<String> l = new ArrayList<String>();
        l.add(ChatColor.DARK_AQUA + "Cost: " + getConfig().getDouble("landmineprice"));
        lmeta.setLore(l);
        lmeta.setDisplayName(ChatColor.GREEN + "LandMine");
        landmine.setItemMeta(lmeta);
 
        ItemStack wirecutters = new ItemStack(Material.FLINT_AND_STEEL);
        ItemMeta wmeta = wirecutters.getItemMeta();
        ArrayList<String> w = new ArrayList<String>();
        w.add(ChatColor.DARK_AQUA + "Cost: " + getConfig().getDouble("wirecuttersprice"));
        wmeta.setLore(w);
        wmeta.setDisplayName(ChatColor.GREEN + "WireCutters");
        wirecutters.setItemMeta(wmeta);
 
        ItemStack money = new ItemStack(Material.DIAMOND);
        ItemMeta mmeta = money.getItemMeta();
        mmeta.setDisplayName(ChatColor.DARK_PURPLE + "Balance: " + econ.getBalance(p.getName()));
        money.setItemMeta(mmeta);
 
        p.openInventory(inv);
 
        inv.clear();
        inv.setItem(0, new ItemStack(grenade));
        inv.setItem(2, new ItemStack(bomb));
        inv.setItem(4, new ItemStack(money));
        inv.setItem(6, new ItemStack(landmine));
        inv.setItem(8, new ItemStack(wirecutters));
 
        p.updateInventory();
    }
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent e){
        if(!e.getInventory().getName().equalsIgnoreCase("Bomb Factory")) return;
        if(!(e.getWhoClicked() instanceof Player)) return;
        Player p = (Player) e.getWhoClicked();
        if (p.getInventory().firstEmpty() == -1) {
            p.sendMessage(ChatColor.RED + "Your inventory is full!");
            return;
        }
        if(e.getCurrentItem().getType() == Material.DIAMOND){
            e.setCancelled(true);
        }
        if(e.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Grenade")){
            e.setCancelled(true);
            if(econ.getBalance(p.getName()) < getConfig().getDouble("grenadeprice")){
                p.sendMessage(ChatColor.RED + "You do not have enough money!");
                return;
            } else {
                ItemStack grenade = new ItemStack(Material.EGG);
                ItemMeta gmeta = grenade.getItemMeta();
                gmeta.setDisplayName(ChatColor.GREEN + "Grenade");
                grenade.setItemMeta(gmeta);
                p.getInventory().addItem(new ItemStack(grenade));
                econ.withdrawPlayer(p.getName(), getConfig().getDouble("grenadeprice"));
            }
        }
        if(e.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Bomb")){
            e.setCancelled(true);
            if(econ.getBalance(p.getName()) < getConfig().getDouble("bombprice")){
                p.sendMessage(ChatColor.RED + "You do not have enough money!");
                return;
            } else {
                ItemStack bomb = new ItemStack(Material.EGG);
                ItemMeta bmeta = bomb.getItemMeta();
                bmeta.setDisplayName(ChatColor.GREEN + "Bomb");
                bomb.setItemMeta(bmeta);
                p.getInventory().addItem(new ItemStack(bomb));
                econ.withdrawPlayer(p.getName(), getConfig().getDouble("bombprice"));
            }
        }
        if(e.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "LandMine")){
            e.setCancelled(true);
            if(econ.getBalance(p.getName()) < getConfig().getDouble("landmineprice")){
                p.sendMessage(ChatColor.RED + "You do not have enough money!");
                return;
            } else {
                ItemStack landmine = new ItemStack(Material.EGG);
                ItemMeta lmeta = landmine.getItemMeta();
                lmeta.setDisplayName(ChatColor.GREEN + "LandMine");
                landmine.setItemMeta(lmeta);
                p.getInventory().addItem(new ItemStack(landmine));
                econ.withdrawPlayer(p.getName(), getConfig().getDouble("landmineprice"));
            }
        }
        if(e.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "WireCutters")){
            e.setCancelled(true);
            if(econ.getBalance(p.getName()) < getConfig().getDouble("wirecuttersprice")){
                p.sendMessage(ChatColor.RED + "You do not have enough money!");
                return;
            } else {
                ItemStack wirecutters = new ItemStack(Material.FLINT_AND_STEEL);
                ItemMeta wmeta = wirecutters.getItemMeta();
                wmeta.setDisplayName(ChatColor.GREEN + "WireCutters");
                wirecutters.setItemMeta(wmeta);
                p.getInventory().addItem(new ItemStack(wirecutters));
                econ.withdrawPlayer(p.getName(), getConfig().getDouble("landmineprice"));
            }
        }
    }
 
    @EventHandler
    public void onSignChangeEvent(SignChangeEvent e){
        if(!(e.getLines().length >= 1) && !e.getLine(0).equalsIgnoreCase("Bomb Factory")) return;
        e.setLine(0, ChatColor.GREEN + "Bomb Factory");
    }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        System.out.println("Working");
        Block b = e.getClickedBlock();
        if(e.getAction() != Action.RIGHT_CLICK_AIR && e.getAction() != Action.RIGHT_CLICK_BLOCK) return;
        if(bomb.contains(b.getLocation())){
            Player p = e.getPlayer();
            if(p.getItemInHand().getType() == Material.FLINT_AND_STEEL){
                p.sendMessage(ChatColor.GREEN + "You have successfully defused the bomb!");
                Bukkit.getServer().getScheduler().cancelTasks(plugin);
                bomb.remove(b.getLocation());
                return;
            }
        }
        if(e.getClickedBlock().getType() != Material.SIGN && e.getClickedBlock().getType() != Material.WALL_SIGN
                && e.getClickedBlock().getType() != Material.SIGN_POST) return;
        System.out.println("Still Working");
        Sign s = (Sign) e.getClickedBlock().getState();
        if(s.getLine(0).equalsIgnoreCase(ChatColor.GREEN + "Bomb Factory")){
            System.out.println("Works!");
            Player p = (Player) e.getPlayer();
            openInventory(p);
        }
    }
}
 

 

Did you make sure you exported the plugin right and you have a plugin.yml? I honestly don't know, everything looks fine to me..

 

BajanAmerican
Yes the plugin.yml is correct and I export it the same way it do to very one of my plugins.

 

PieMan456 Is Vault enabled, did you have

Code:

depend: [Vault]

in plugin.yml

 

fireblast709
No I don't have that. Let me see if it works now.

 

PieMan456
The only thing I see wrong with your code is invalid operands. For example, you use == in line 176 where you should be using .equals()

== compares two non-primitive references,
.equals() can be overriden.

EDIT: There could be other instances where you used the wrong one, I only noticed the one I pointed out

 

AoH_Ruthless
I pretty much just copied that small piece of code from another plugin that worked perfectly fine with it.

 

PieMan456
Really? For me using == is iffy, but maybe there was something else wrong with my code at the time

EDIT: Wait sorry, it's the other way around. == is the right method for a material name. I was thinking of the wrong thing.

 

fireblast709
Ok so I added depend: [Vault] and I put vault in the plugins but now it says it is disabled because there is not vault when vault is in the plugins folder.

AoH_Ruthless
Do you know?(Look up at last post)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

PieMan456
I would add the logger statements in the setupEconomy() constructor, and then in your onEnable just do setupEconomy();

 

When you do depend: Vault, you are saying your plugin requires vault to run. If that is so then the user would require vault to run. If you do not require Vault, but have optional implementation of it, change the line to: softDepend: Vault

It is these lines of code that are disabling your plugin when there is no vault

Code:

public void onEnable(){
Bukkit.getServer().getPluginManager().registerEvents(this, this);
if (!setupEconomy() ) {
getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
getServer().getPluginManager().disablePlugin(this);
return;
}
}

You are saying if setupEconomy returns false, Disable the plugin.

 

Do you have any plugins which have an economy? (one from the 'vault currently supports' on the BukkitDev page)

 

fireblast709
I just removed them all and tried again but it still disables it.

 

PieMan456 No you should have one of them for the economy to be registered (nope, didn't check Vault for this, this is purely based on guessing). So you need at least Vault, one of those plugins providing economy, and your own plugin in the /plugins folder

 

fireblast709
Haha you got it right. Thanks! It only works if you have an economy plugin as well.