Why are my configs empty? :(

So i am making a plugin that relies heavily on config.yml files. At the advice of some people on an IRC, i made a config.yml in the .jar, but that is empty and it will not make a config.yml in the plugins/WhereToSell/
Here is the code:

Code:java

package me.Dmoney12321.WhereToSell;
 
    import java.io.File;   
    import org.bukkit.ChatColor;
    import org.bukkit.command.Command;
    import org.bukkit.command.CommandSender;
    import org.bukkit.entity.Player;
    import org.bukkit.plugin.PluginDescriptionFile;
    import org.bukkit.plugin.java.JavaPlugin;
 
    public class WhereToSell extends JavaPlugin {
 
    @Override
    public void onDisable()
    {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.getLogger().info(pdfFile.getName() + " Has Been Disabled!");
    }
 
    @Override
    public void onEnable()
    {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.getLogger().info(pdfFile.getName() + "Version" + pdfFile.getVersion() + " Has Been Enabled!");
    File configFile = new File(this.getDataFolder(), "config.yml");
    if (!configFile.exists()){
    this.getConfig().options().copyDefaults(true);
    this.getLogger().info("Generating config.yml...");
    this.getConfig().addDefault("buydiamond", "Default");
    this.getConfig().addDefault("buyiron" , "Default");
    this.getConfig().addDefault("buygold", "Default");
    this.getConfig().addDefault("buycoal", "Default");
    this.getConfig().addDefault("buywood", "Default");
    this.getConfig().addDefault("buysand", "Default");
    this.getConfig().addDefault("buydirt", "Default");
    this.getConfig().addDefault("buycobblestone", "Default");
    this.getConfig().addDefault("buyseeds", "Default");
    this.getConfig().addDefault("buywheat", "Default");
    this.getConfig().addDefault("buybread", "Default");
    this.getConfig().addDefault("buycowspawner", "Default");
    this.getConfig().addDefault("buymooshroomspawner", "Default");
    this.getConfig().addDefault("buypigspawner", "Default");
    this.getConfig().addDefault("buychickenspawner", "Default");
    this.getConfig().addDefault("buyhorsespawner", "Default");
    this.getConfig().addDefault("buysheepspawner", "Default");
    this.getConfig().addDefault("buywolfspawner", "Default");
    this.getConfig().addDefault("buyocelotspawner", "Default");
    this.getConfig().addDefault("buyspiderspawner", "Default");
    this.getConfig().addDefault("buyskeletonspawner", "Default");
    this.getConfig().addDefault("buyzombiespawner", "Default");
    this.getConfig().addDefault("buyendermanspawner", "Default");
    this.getConfig().addDefault("buyblazespawner", "Default");
    this.getConfig().addDefault("buycreeperspawner", "Default");
    //
    //Just a divider :P
    //
    this.getConfig().addDefault("sellwood", "Default");
    this.getConfig().addDefault("sellsand", "Default");
    this.getConfig().addDefault("sellcobble", "Default");
    this.getConfig().addDefault("selldirt", "Default");
    this.getConfig().addDefault("sellstone", "Default");
    this.getConfig().addDefault("sellredmushroom", "Default");
    this.getConfig().addDefault("sellbrownmushroom", "Default");
    this.getConfig().addDefault("sellmycellium", "Default");
    this.getConfig().addDefault("selldiamond", "Default");
    this.getConfig().addDefault("sellgold", "Default");
    this.getConfig().addDefault("selliron", "Default");
    this.getConfig().addDefault("sellcoal", "Default");
    this.getConfig().addDefault("sellemerald", "Default");
    this.getConfig().addDefault("sellredstone", "Default");
    this.getConfig().addDefault("sellnetherrack", "Default");
    this.getConfig().addDefault("sellglowstone", "Default");
    this.getConfig().addDefault("sellnetherwart", "Default");
    this.getConfig().addDefault("sellrawpork", "Default");
    this.getConfig().addDefault("sellrawbeef", "Default");
    this.getConfig().addDefault("sellrawsteak", "Default");
    this.getConfig().addDefault("sellrawchicken", "Default");
    this.getConfig().addDefault("sellrawfish", "Default");
    this.getConfig().addDefault("sellcactus", "Default");
    this.getConfig().addDefault("sellpumpkin", "Default");
    this.getConfig().addDefault("sellmelon", "Default");
    this.getConfig().addDefault("selllillypads", "Default");
    }
    else if(configFile.exists()){
    this.getLogger().info("Reloading config.yml");
    this.saveConfig();
 
    }
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
    Player p = (Player) sender;
    if(cmd.getName().equalsIgnoreCase("wts")){
    //Sends error message if no args are entered.
    if (args.length == 0){
    p.sendMessage(ChatColor.RED + "Correct usage is /wts (item name)");
    }
    //Help args (Sends info)
    else if (args[0].equalsIgnoreCase("help")){
    p.sendMessage(ChatColor.LIGHT_PURPLE + "WhereToSell by Dmoney12321. Do /wts (item name) to find out where you can sell said item.");
    p.sendMessage(ChatColor.LIGHT_PURPLE + "Example: /wts diamond would send you a message saying where you can sell diamond");
    }
    //begin item naming
    else if (args[0].equalsIgnoreCase("diamond")){
    p.sendMessage(ChatColor.LIGHT_PURPLE + "You can sell this item at " + this.getConfig().getString("selldiamond"));
    }
    }
    //
    // WHERE TO BUY COMMANDS
    //
    else if (cmd.getName().equalsIgnoreCase("wtb")){
    //Sends error message if no args are entered.
    if (args.length == 0){
    p.sendMessage(ChatColor.RED + "Correct usage is /wtb (item name)");
    }
    //Help args (Sends info)
    else if (args[0].equalsIgnoreCase("help")){
    p.sendMessage(ChatColor.LIGHT_PURPLE + "WhereToBuy by Dmoney12321. Do /wtb (item name) to find out where you can buy said item.");
    p.sendMessage(ChatColor.LIGHT_PURPLE + "Example: /wtb diamond would send you a message saying where you can buy diamond");
    }
    //Begin item naming.
    else if (args[0].equalsIgnoreCase("diamond")){
    p.sendMessage(ChatColor.LIGHT_PURPLE + "You can buy this item at " + this.getConfig().getString("buydiamond"));
    }
    }
    else if (cmd.getName().equalsIgnoreCase("wtreload")){
    if(p.isOp()){
    this.reloadConfig();
    this.saveConfig();
    p.sendMessage(ChatColor.GREEN + "Reloaded.");
    }
    else if(!p.isOp()){
    p.sendMessage(ChatColor.RED + "Sorry, you cannot do that.");
    }
    }
    return false;
    }
    }

 

Code:java

File file = new File(this.getDataFolder(), "config.yml");
if (!file.exists()) {
    saveDefaultConfig();
}

And then keeping a default config in your plugin resources (Where you plugin.yml is). It will make life much easier for you.

 

1Rogue
So in the config in the .jar put all the defaults?

 

Not necessary. saveDefaultConfig() will check if the file exists or not. https://github.com/Bukkit/Bukkit/bl...a/org/bukkit/plugin/java/JavaPlugin.java#L135

 

drtshock 1Rogue
Put all defaults in the one in the .jar
Still doesnt make a config.yml in the plugin's plugin folder

 

Put your config where your plugin.yml is in your jar. Then call saveDefaultConfig() in the onEnable. That will then save the config to the server on startup.

 

drtshock
Still doesnt work.

 

What isn't working? Getting any errors?

 

http://imgur.com/FExqRrx
drtshock

 

The only line you need in your config is "saveDefaultConfig()" get rid of everything else.

 

Er, unless I'm not seeing correctly, you're not using the saveDefaultConfig() method.

 

So

Code:java

if (!configFile.exists()){
    this.saveDefaultConfig();
    }

drtshock

 

No. Read what I said. The ONLY line that you need is

Code:java

saveDefaultConfig();

 

drtshock
This?

Code:java

public void onEnable()
    {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.getLogger().info(pdfFile.getName() + "Version" + pdfFile.getVersion() + " Has Been Enabled!");
    this.saveDefaultConfig();
    }

 

Sure but why do you say that the plugin has been enabled? Bukkit does that for you. You also don't need "this."

 

drtshock
Thanks man.

 

drtshock
It says "Enabling Plugin..." not "Plugin Enabled!"

 

Yes but it's bad practice to log things that are unnecessary

 

True....I used to do that until I finally got tired of writing a logger message instead of coding