I need help with some coding issues.

Hello, there I'm currently new to bukkit, also have learnt how to code java and such. I'm coding DoorProtection + KitPvP. DoorProtection, I'm still working on, but when I upload KitPvP, when my codes are all accurate and stuff, when I use the command ingame, it doesn't work, I need some help, if you could.

PS. I'm also new to coding, which might explain why, like missing codes.

 

ObservationPvP When your back on, may I see the code please?

 

ObservationPvP
Did you define your commands in the plugin.yml?

 

Yes, I did, but when I do the cmd it does completely nothing.

Okay then the code is

Code:

package me.ObservationPvP.Kits;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class PvP extends JavaPlugin {
 
       
 
    public void onCommand(CommandSender sender, Command cmd, String commandLabel, String args) {
        if(commandLabel.equalsIgnoreCase("PvP")) {
            Player player = (Player) sender;
            player.getInventory().clear();
            player.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD));
            player.getInventory().setHelmet(new ItemStack(Material.IRON_HELMET));
            player.getInventory().setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
            player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS));
            player.getInventory().setBoots(new ItemStack(Material.IRON_BOOTS));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));        }
       
       
       
}
}
 
       
       
       
       
       
       
       
       
       
       
 
 
   
   
   
   
   

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Is this your main class?
If it is, you need an onEnable() and ondisable(), but if it isn't, then you shouldn't be extending JavaPlugin, but implementing CommandExecutor

then in your onEnable() in the main class add

getCommand("the command").setExecutor(new the class it is in());

EG:
getCommand("test").setExecutor(new testclass());

 

ObservationPvP
For one use this.

Code:java

 if (cmd.getName().equalsIgnoreCase("pvp")) {

Instead of.

Code:java

 if(commandLabel.equalsIgnoreCase("PvP")) { {

Two can you post your plugin.yml?

 

use for loops

 

Err ... a compressed version to remind you "No one has learnt Java" Its an ongoing process ^^

Code:java

 
PlayerInventory pInv = player.getInventory();
 
// clear the inventory
pInv.clear();
 
// pInv.addItem(new ItemStack(Material.DIAMOND_SWORD)); // this would place it in slot 0 as you cleared it but you could also make this more clear
// pInv.setItem(0, new ItemStack(Material.DIAMOND_SWORD)); // add it to first slot
pInv.setItemInHand(new ItemStack(Material.DIAMOND_SWORD)); // give him a sword instantly as i do not know what happens if he had selected slot 4 but is given a sword into slot 1. I dont think that it will be auto selected to be placed in his hands.
 
// set armor
pInv.setHelmet(new ItemStack(Material.IRON_HELMET));
pInv.setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
pInv.setLeggings(new ItemStack(Material.IRON_LEGGINGS));
pInv.setBoots(new ItemStack(Material.IRON_BOOTS));
 
// depending on your preference you could also compress the last 4  lines to
pInv.setArmorContents(new ItemStack[] {
    new ItemStack(Material.IRON_HELMET),
    new ItemStack(Material.IRON_CHESTPLATE),
    new ItemStack(Material.IRON_LEGGINGS),
    new ItemStack(Material.IRON_BOOTS)
});
 
// fille the whole inventory 9 to 35 with MUSHROOM_SOUP
Arrays.fill(player.getInventory(), 9, 35, new ItemStack(Material.MUSHROOM_SOUP))
 

 

I've fixed the problem, thanks!

 

Even tho you solved it, i would recommend using

Code:java

        for (int i = 0; i < 35; i++){
            player.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));

For filling the soup instead of tons of lines for refilling.