So all of the commands are working besides the ones that remove names from the HashMap. Right now it has no problem adding them to the HashMap, no problem telling me who's in it, but when I try to remove them with either ./review done, or /review remove, I get an error. I get an error on /review done <player> but not with /review remove. Code: Code:java package me.Xerfox.MyReviews; import java.util.ArrayList;import java.util.HashMap;import java.util.logging.Logger; import org.bukkit.ChatColor;import org.bukkit.block.Block;import org.bukkit.command.Command;import org.bukkit.command.CommandSender;import org.bukkit.entity.Player;import org.bukkit.plugin.PluginDescriptionFile;import org.bukkit.plugin.java.JavaPlugin; public class Reviews extends JavaPlugin { public static Reviews plugin; public final Logger logger = Logger.getLogger("Minecraft"); public final HashMap<Player, ArrayList<Block>> players = new HashMap<Player, ArrayList<Block>>(); public void onEnable() { PluginDescriptionFile pdfFile = this.getDescription(); this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled"); } public void onDisable() { PluginDescriptionFile pdfFile = this.getDescription(); this.logger.info(pdfFile.getName() + " Has Been Disabled!"); } public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args) { Player player = (Player) sender; if (CommandLabel.equalsIgnoreCase("review")) { if (args.length == 0) { if (player.isOp()) { player.sendMessage(ChatColor.GREEN + "**** Admin Help Menu ****"); player.sendMessage(ChatColor.DARK_AQUA + "/review - Brings Up This Menu"); player.sendMessage(ChatColor.DARK_AQUA + "/getreview - Request a Review!"); player.sendMessage(ChatColor.DARK_AQUA + "/review list - Shows Amount of Reviews That Are Left!"); player.sendMessage(ChatColor.DARK_AQUA + "/review done <player> - Marks Review As Completed!"); player.sendMessage(ChatColor.DARK_AQUA + "/review remove - Remove a Review That You Have!"); } else { player.sendMessage(ChatColor.GREEN + "**** Help Menu ****"); player.sendMessage(ChatColor.DARK_AQUA + "/review - Brings Up This Menu"); player.sendMessage(ChatColor.DARK_AQUA + "/getreview - Request a Review!"); } } if (args.length == 1) { if (args[0].equalsIgnoreCase("remove")) { if(player.hasPermission("review.user")){ if(players.containsKey(player.getName())){ players.remove(player.getName()); player.sendMessage(ChatColor.GREEN + "You Have Successfully Removed Your Review!"); } } } if (args.length == 2) { if (args[0].equalsIgnoreCase("done")) { if (player.hasPermission("review.staff")){ Player target = getServer().getPlayer(args[0]); if (players.containsKey(target.getName())){ players.remove(target.getName()); sender.sendMessage(ChatColor.GREEN + "Successfully Completed The Review!"); } }else{ player.sendMessage(ChatColor.RED + "Player is not in the query!"); } } } if (args.length == 1) { if (args[0].equalsIgnoreCase("list")) { if (player.hasPermission("review.staff")){ StringBuilder sb = new StringBuilder(ChatColor.DARK_AQUA + "Players:"); for (Player name : players.keySet()) { sb.append('\n').append(name); } sender.sendMessage(sb.toString()); } } } } return true; } if (CommandLabel.equalsIgnoreCase("getreview")) { if(player.hasPermission("review.user")){ if (args.length == 0) { players.put(player, null); player.sendMessage(ChatColor.GREEN + "Your Review Request Has Been Successfully Sent!"); player.sendMessage(ChatColor.GREEN + "You Can Remove Your Review By Doing /review remove"); } } return true; } return false; }}
caelum19 This is the console: 06.10 19:57:50 [Server] INFO ... 15 more 06.10 19:57:50 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) 06.10 19:57:50 [Server] INFO at me.Xerfox.MyReviews.Reviews.onCommand(Reviews.java:88) 06.10 19:57:50 [Server] INFO Caused by: java.lang.NullPointerException 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:834) 06.10 19:57:50 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:877)
is that all there is from the console? there is a null pointer error which should be easy to fix. when does this occur?
caelum19 mollekake here is everything in the console. The server is popular so the errors are more towards the top 07.10 14:02:42 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]katie_hall, [Steve]keaganh123, [Steve]LordofCats5 07.10 14:02:42 [Server] INFO Moderator: [Mod]~DarKrow_ 07.10 14:02:42 [Server] INFO Co-Owner: [Co-Owner]~Xerfox 07.10 14:02:42 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 14:02:38 [Server] INFO ... 15 more 07.10 14:02:38 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) 07.10 14:02:38 [Server] INFO at me.Xerfox.MyReviews.Reviews.onCommand(Reviews.java:72) 07.10 14:02:38 [Server] INFO Caused by: java.lang.NullPointerException 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:834) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:877) 07.10 14:02:38 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:959) 07.10 14:02:38 [Server] INFO at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:523) 07.10 14:02:38 [Server] INFO at us.Myles.PWP.FakeSimpleCommandMap.dispatch(FakeSimpleCommandMap.java:99) 07.10 14:02:38 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) 07.10 14:02:38 [Server] INFO org.bukkit.command.CommandException: Unhandled exception executing command 'review' in plugin MyReviews v1.0.0 07.10 14:02:38 [Server] SEVERE null 07.10 14:01:37 [Server] INFO 1.1.0vs1.1.0 07.10 14:01:36 [Multicraft] The_Xerfox ran command Message of the Day 07.10 14:01:36 [Connect] User The_Xerfox, IP 192.227.156.10 07.10 14:00:37 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]katie_hall, [Steve]keaganh123, [Steve]LordofCats5 07.10 14:00:37 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 14:00:37 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 14:00:30 [Server] INFO postAttach added katie_hall aka [Steve]katie_hall to c5b5a9fc-9000-41d0-9972-adcd63a96f31 aka Wilderness. 07.10 14:00:21 [Multicraft] katie_hall ran command Message of the Day 07.10 14:00:20 [Connect] User katie_hall, IP 192.227.156.10 07.10 14:00:13 [Server] INFO Removed 25 Entities! 07.10 13:59:24 [Server] SEVERE No response/invalid key during pending players check. 07.10 13:59:24 [Server] SEVERE HTTP request failed due to timeout error. 07.10 13:59:13 [Server] INFO Warning Ground items will be removed in one minute! 07.10 13:59:11 [Server] INFO LordofCats5 just tried to change a non-editable sign. (Bukkit bug, or plugin conflict?) 07.10 13:59:10 [Server] INFO LordofCats5 has protected a block or door. 07.10 13:58:50 [Server] INFO AutoSave Complete 07.10 13:58:50 [Server] INFO AutoSaving 07.10 13:58:32 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:58:32 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:58:32 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:57:40 [Server] INFO �8World saved. 07.10 13:57:38 [Server] INFO CONSOLE: Forcing save.. 07.10 13:57:38 [Server] INFO CONSOLE: Enabled level saving.. 07.10 13:57:38 [Multicraft] Auto-saving world... 07.10 13:56:59 [Server] INFO §ecrtaken11 left the game. 07.10 13:56:59 [Server] INFO Connection reset 07.10 13:56:59 [Disconnect] User crtaken11 has disconnected, reason: disconnect.quitting 07.10 13:56:27 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]crtaken11, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:56:27 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:56:27 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:54:22 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]crtaken11, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:54:22 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:54:22 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:54:00 [Server] INFO postAttach added crtaken11 aka [Steve]crtaken11 to c5b5a9fc-9000-41d0-9972-adcd63a96f31 aka Wilderness. 07.10 13:53:33 [Server] INFO Removed 42 Entities! 07.10 13:53:04 [Multicraft] crtaken11 ran command Message of the Day 07.10 13:53:04 [Connect] User crtaken11, IP 192.227.156.10 07.10 13:53:02 [Server] INFO §eYandereQueen left the game. 07.10 13:53:02 [Disconnect] User YandereQueen has disconnected, reason: disconnect.quitting 07.10 13:53:02 [Server] INFO Connection reset 07.10 13:52:33 [Server] INFO Warning Ground items will be removed in one minute! 07.10 13:52:17 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5, [Steve]YandereQueen 07.10 13:52:17 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:52:17 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:51:32 [Server] INFO Hughbedo died 07.10 13:50:54 [Multicraft] YandereQueen ran command Message of the Day 07.10 13:50:54 [Connect] User YandereQueen, IP 192.227.156.10 07.10 13:50:11 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:50:11 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:50:11 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:49:13 [Server] INFO Connection reset 07.10 13:49:13 [Server] INFO Connection reset 07.10 13:48:43 [Server] INFO §eYandereQueen left the game. 07.10 13:48:43 [Disconnect] User YandereQueen has disconnected, reason: disconnect.quitting 07.10 13:48:43 [Server] INFO Connection reset 07.10 13:48:06 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5, [Steve]YandereQueen 07.10 13:48:06 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:48:06 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:47:33 [Server] INFO �8World saved. 07.10 13:47:33 [Server] INFO CONSOLE: Forcing save.. 07.10 13:47:33 [Server] INFO CONSOLE: Enabled level saving.. 07.10 13:47:33 [Multicraft] Auto-saving world... 07.10 13:47:26 [Multicraft] YandereQueen ran command Message of the Day 07.10 13:47:26 [Connect] User YandereQueen, IP 192.227.156.10 07.10 13:47:15 [Server] INFO LordofCats5 has released a container. 07.10 13:46:53 [Server] INFO Removed 25 Entities! 07.10 13:46:01 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:46:01 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:46:01 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:45:53 [Server] INFO Warning Ground items will be removed in one minute! 07.10 13:45:40 [Server] INFO LordofCats5 just tried to change a non-editable sign. (Bukkit bug, or plugin conflict?) 07.10 13:45:39 [Server] INFO LordofCats5 has protected a block or door. 07.10 13:45:36 [Server] INFO LordofCats5 has released a container. 07.10 13:44:02 [Server] INFO LordofCats5 just tried to change a non-editable sign. (Bukkit bug, or plugin conflict?) 07.10 13:44:01 [Server] INFO LordofCats5 has protected a block or door. 07.10 13:43:56 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:43:56 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:43:56 [Server] INFO BuildTeam: [BuildTeam]~Hughbedo 07.10 13:43:52 [Server] INFO AutoSave Complete 07.10 13:43:50 [Server] INFO AutoSaving 07.10 13:42:38 [Multicraft] Hughbedo ran command Message of the Day 07.10 13:42:38 [Connect] User Hughbedo, IP 192.227.156.10 07.10 13:41:51 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:41:51 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:40:13 [Server] INFO Removed 75 Entities! 07.10 13:39:46 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:39:46 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:39:13 [Server] INFO Warning Ground items will be removed in one minute! 07.10 13:38:43 [Server] INFO §eevilgoatmonkey left the game. 07.10 13:38:43 [Server] INFO Connection reset 07.10 13:38:43 [Disconnect] User evilgoatmonkey has disconnected, reason: disconnect.quitting 07.10 13:37:41 [Server] INFO Steve: [Steve]Assassin1726, [Steve]Azadora1, [Steve]CandyDetective, [Steve]Darkdrake84, [Steve]evilgoatmonkey, [Steve]keaganh123, [Steve]LordofCats5 07.10 13:37:41 [Server] INFO Moderator: [HIDDEN][Mod]~DarKrow_ 07.10 13:37:30 [Server] INFO �8World saved.
this seems even more like a bukkit problem... try updating Craftbukkit both on the server and in the plugin By the way I'd advice against testing plugins on public servers it can be...damaging
Well, I looked through your errors, and it appears that the error happens in two spots of the same type. One on line 72, and one on line 88. From what I can tell, player would be null, that is all that I can think that would be possible to be null. You are doing Player player = (Player) sender; before you check if the sender is a player, that could very well be the bulk of your problem right there.
