Plugin is perfect - Need someone to double check though

My plugin works exactly like I intended it to. The only problem is random lag spikes. So if someone were to be kind enough to just check this out real quick, it would be a great help and I would really appreciate it.

http://pastebin.com/JCXc779h

 

It would be nice to get some more information. What is your plugin supposed to do? Could you potentially also add some comments in the code so it's easier to understand what you were trying to do? When does it get laggy?

 

May I suggest splitting your plugin into more than one file?

 

I would like to check it out, but can you split it in multiple files and put it on GitHub? It just gets much less complicated that way. Documention works as well.

 

Code:java

 
if(event.getEntity() instanceof Player){
    if(event.getCause() == EntityDamageEvent.DamageCause.FALL){ // EntityDamageEvent shouldn't be there
        event.setCancelled(true);
    }
}
 

Problem 1: EntityDamageEvent is not required for the DamageCause event

Code:java

 
for(Player p : Bukkit.getOnlinePlayers()){
    if(p != e.getPlayer()){
        p.sendMessage(ChatColor.LIGHT_PURPLE + e.getPlayer().getName() + " has joined the PvP Arena!");
    }
}
 

Problem 2: Why do you want the original player not to have the join message, you can also use Bukkit.broadcastMessage("message") if you want to broadcast the join message. At the very least you could reduce the load on the server by sending blank lines...

Code:java

q.sendMessage("");
q.sendMessage("");
q.sendMessage("");
q.sendMessage("");
q.sendMessage("");
 

Code:java

 
@EventHandler
public void onTeleport(PlayerTeleportEvent event)
{
    Player player = event.getPlayer();
        for (Player p : Bukkit.getOnlinePlayers())
        {
            if (p.canSee(player))
            p.showPlayer(player);
        }
}

Warning 3: Do you really need to show the player to all the players, this is the possible lag cause, I understand its the new TP lag when they teleport though.


And I haven't checked the onCommand method (I gotta go)

 

You should create a bot that makes this comment on every single thread

 

This is only for cleanliness but in the onEnable() you can make the for loops 1 line.

e.g

Code:

for (String key : this.getConfig().getConfigurationSection("hwinstreak").getKeys(false)) hwinstreak.put(key, this.getConfig().getInt("hwinstreak." + key));

 

It's not really cleaner to use a sing line.

 

Ultimate_n00b In my opinion it is, but they can have it however he wants I was just putting it out there in case they didn't know you can do that.

 

Alright guys thanks a lot. I'll be doing some of the things stated here.
Plo124 especially. Just wondering, if I have multiple classes can it reduce lag?

 

Slokh Multiple classes makes it easier to organise your data, it might reduce lag, but probably not.

 

Try removing this and see if the lag stops:

Code:java

        @EventHandler
        public void onTeleport(PlayerTeleportEvent event)
        {
          Player player = event.getPlayer();
          for (Player p : Bukkit.getOnlinePlayers())
          {
            if (p.canSee(player))
                p.showPlayer(player);
          }
        }

It is probably the only intensive operation;

 

Plo124 and FurmigaHumana So do you know any other way to make it so that people aren't invisible on teleport?

 

Slokh I don't know how to do this but you can resend the packet for visible people. I don't know what packet it is either, but I know you can because VanishNoPacket stops a packet from being sent (i think). So, you could just do the opposite.

Also, going by the code which FurmigaHumana posted, you're checking if the players can see the other player. Then inside that if statement you're showing the player. I think you wanted to check if the player can't see another player instead.