Random Teleport function not working

My random teleport function doesn't work. It makes the player freeze and unable to interact, then it kicks them and wont let them join. Can anyone spot an error?

Code:java

public void Random_Teleport_World(Player player){
int rand_x,rand_z;
rand_x = generator.nextInt(1000);
rand_z = generator.nextInt(1000);
int y = 0;
boolean safe = false;
Location loc;
World world = player.getWorld();
while(!safe){
y++;
loc = new Location(world, rand_x, y, rand_z);
if(!(loc.subtract(0, 1, 0).getBlock().getType().equals(Material.AIR)||loc.subtract(0, 1, 0).getBlock().getType().equals(Material.LAVA))){
if(loc.getBlock().getType().equals(Material.AIR) && loc.add(0,1,0).getBlock().getType().equals(Material.AIR)){
safe = true;
player.teleport(loc);
}
}else if(y >= 254){
y = 0;
rand_x = generator.nextInt(1000);
rand_z = generator.nextInt(1000);
}
}
 
}

 

Wait... I'm confused. You're trying to make a random teleport function, but you want it freeze, and kick them? I don't see anything in the code about kicking the player. I'm just probably not seeing it

 

I think he means he wants to teleport them somewhere there's no lava and just air in the two blocks he's checking.
Instead of doing that, it freezes the player for a bit and they get kicked from the server.

 

WauloK @RunningStudios
Yeah, Thats whats happening. The wording was strange

 

Your condition is never reached, because a block can't be air and not-air at the same time (this is what you are checking here at some point) -> endless loop -> server freezes

The problem is, that location.subtract(..) and location.add(..) modify the location object, therefore your conditions don't work like you probably expect them to work..

Step by step explanation: you call:
!(loc.subtract(0, 1, 0).getBlock().getType().equals(Material.AIR))
-> loc.subtract(0, 1, 0) -> loc is now at y - 1 and there is no air
!(loc.subtract(0, 1, 0).getBlock().getType().equals(Material.LAVA))
-> loc is now at y - 2 and there is no lava
loc.getBlock().getType().equals(Material.AIR)
-> loc is still at y - 2 and there is air (air != lava so this is possible)
loc.add(0,1,0).getBlock().getType().equals(Material.AIR)
-> loc is now again at y - 1 and there has to be air in order for your condition to be successfull
However: there can't be air because the first condition (see above at y - 1) checked, that there is no air..

-> endless loop

You could add a .clone() whenever you call subtract or add on loc, or you get the block at your newly created location and call something like block.getRelative(BlockFace.DOWN or BlockFace.UP).getType()..

 

So y=0 which is bedrock. Add 1 so y=1.
This:

Code:java

if(!(loc.subtract(0, 1, 0).getBlock().getType().equals(Material.AIR)||loc.subtract(0, 1, 0).getBlock().getType().equals(Material.LAVA))){

Pseudo-code:

This could be the problem. You only get teleported if the block at under feet is not air or it is lava.
At bedrock level, feet are on bedrock and face is at dirt level.
I could be wrong. My brain hurts with this code XD

 

Not sure anymore if the problem is this function. My other function do the same thing
Edit: nevermind

 

Code:java

 
public void Random_Teleport_World(Player player) {
  int rand_x = generator.nextInt(1000);
  int rand_z = generator.nextInt(1000);
  int y = 0;
  boolean safe = false;
  Location loc;
  World world = player.getWorld();
  while (!safe){
    y++;
    loc = new Location(world, rand_x, y, rand_z);
    Block block = loc.getBlock();
    Material downType = block.getRelative(BlockFace.DOWN).getType();
    if (downType != Material.AIR && downType != Material.LAVA) {
      if (block.getType() == Material.AIR && block.getRelative(BlockFace.UP).getType() == Material.AIR) {
        safe = true;
        player.teleport(loc);
      }
    } else if (y >= 254){
      y = 0;
      rand_x = generator.nextInt(1000);
      rand_z = generator.nextInt(1000);
    }
  }
}