Solved Attempting to extend CraftPlayer; keeps saying incompatible return types.

"The return types are incompatible for the inherited methods Damageable.getHealth(), CraftLivingEntity.getHealth()"

Code:java

package com.tenko.npc;
 
import java.util.List;
import java.util.ArrayList;
import java.util.Random;
 
import net.minecraft.server.v1_6_R2.Entity;
import net.minecraft.server.v1_6_R2.EntityInsentient;
import net.minecraft.server.v1_6_R2.EntityLiving;
import net.minecraft.server.v1_6_R2.EntityPlayer;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.craftbukkit.v1_6_R2.CraftServer;
import org.bukkit.craftbukkit.v1_6_R2.entity.CraftEntity;
import org.bukkit.craftbukkit.v1_6_R2.entity.CraftLivingEntity;
import org.bukkit.craftbukkit.v1_6_R2.entity.CraftPlayer;
import org.bukkit.entity.Player;
import org.bukkit.util.Vector;
 
import com.google.common.collect.Lists;
import com.tenko.NovEngine.Option;
import com.tenko.npc.controllers.NPCControllerJump;
 
public abstract class BaseNPC extends CraftPlayer {
 
public static EntityInsentient SCAPEGOAT = new EntityInsentient(null){};
 
public BaseNPC(CraftServer server, EntityPlayer entity){
super(server, entity);
//this.goals = new PathfinderGoalSelector(entity.world.methodProfiler);
//goals.a(new PathfinderGoalLookAtPlayer(this, EntityHuman.class, 0.04F));
}
 
private ArrayList<String> quotes = Lists.newArrayList();
private ArrayList<Option> options = Lists.newArrayList();
 
private int chatIndex = 0;
//private PathfinderGoalSelector goals;
private Random random = new Random();
 
public abstract void lookAt(Location loc);
public abstract void die();
public abstract void teleportTo(Location loc);
 
public abstract String getName();
 
public ArrayList<String> getQuotes(){
return quotes;
}
 
public ArrayList<Option> getOptions(){
return options;
}
 
public void setQuotes(List<String> list){
quotes = new ArrayList<String>(list);
}
 
public void setOptions(List<Option> list){
options = new ArrayList<Option>(list);
}
 
public void chat(Player plyr){
if(quotes.size() > 0){
plyr.sendMessage("<" + ChatColor.RED + getName() + ChatColor.RESET + "> " + quotes.get(chatIndex).replace("%plyr%", plyr.getName()).replace("%ai%", getName()));
chatIndex++;
if(chatIndex >= quotes.size()){
chatIndex = 0;
}
}
}
 
public void chat(Player plyr, String message){
plyr.sendMessage("<" + ChatColor.RED + getName() + ChatColor.WHITE + "> " + message.replace("%plyr%", plyr.getName()).replace("%ai%", getName()));
}
 
public double calculateYaw(Vector motion){
double dX = motion.getX();
double dZ = motion.getZ();
double yawZ = 0;
 
if(dX != 0){
if(dX < 0){
yawZ = 1.5 * 3.141592;
} else {
yawZ = 0.5 * 3.141592;
}
 
//I really don't want to Math.atan.
yawZ -= Math.atan(dZ / dX);
} else if(dZ < 0){
yawZ = 3.141692;
}
 
return -yawZ * 180 / 3.141592;
}
 
//This is probably going to be amazingly inaccurate.
public double fastAtan(double var){
//pi/4 * x - x * (|x| - 1) * (0.2447 + 0.0663*|x|)
return 0.78539 * var - var * (Math.abs(var) - 1) * (0.2447 + 0.0663*Math.abs(var));
}
 
public NPCControllerJump getJumpController(){
return null;
}
 
public Random getRandom(){
return random;
}
 
public EntityLiving getLivingHandle(){
return (EntityLiving)getHandle();
}
 
}

I'm referencing CraftBukkit and only CraftBukkit.

This error doesn't make any sense; does CraftBukkit have an error with changing float and double numbers?

Edit: It looks like they both return double. Weird.

 

This is caused by the new getHealth system where the devs have created some trickery to allow the getHealth() functions to return either a double or an int in order to provide backwards compatibility.

 

Extending CraftPlayer wat why. And yeah, it's because of the new getHealth system. Paste the error?

 

I did; it's the one at the top. I need to do this so I can create custom entities, and I want to make it so I can use Player methods within the entity.

Do you know if there's a way around this? I checked all of the sources; everything that is normalized (aka, not INVALID_getHealth()) returns a double as it should.

 

Cirno
I had this problem too, unfortunately, I could not find an quick fix for it. This error is caused by conflicting intefaces, (CraftPlayer implements a interface with a getHealth() method that returns int and another interface with a getHealth() method returning double). Here's what I noticed and tried doing:

I tried creating a class implementing Player, it gave errors for getMaxHealth(), getHealth(), and getLastDamage() because of return types.

There are no errors with this code:

Code:java

public class CraftHumanNPC extends CraftPlayer {
 
public CraftHumanNPC(CraftServer server, EntityHumanNPC entity) {
super(server, entity);
}
 
@Override
public EntityHumanNPC getHandle() {
return (EntityHumanNPC) super.getHandle();
}
}
 

But there is an incompatible return type error with this code:

Code:java

 
public class CraftHumanNPC extends CraftPlayer implements HumanNPC {
 
public CraftHumanNPC(CraftServer server, EntityHumanNPC entity) {
super(server, entity);
}
 
@Override
public EntityHumanNPC getHandle() {
return (EntityHumanNPC) super.getHandle();
}
 
}
 

The first code block I posted (will be refered to as example A) does not implement another interface, the second code block I posted (will be refered to as example B) does implement another interface (the HumanNPC interface contains nothing and EntityHumanNPC is my custom EntityPlayer class).

Overriding the getHealth method in example A gave the incompatible return type error, but you can override other methods (not the getHealth, getMaxHealth or getLastDamage methods) and there is no problem.

Also, it is possible to cast a class to any interface (it doesn't matter if the class implements the interface) as long as the class has the methods within that interface.
So this tells me that I can work around this error by using the default health system and I can do custom stuff for everything else, and even though I can't implement anything within my custom CraftPlayer class, I can still cast it to my HumanNPC class. The only downfall about this, is that I can't make custom getHealth methods.

But, it seems like you're using an abstract class for this. I tried copying your code, removing the abstract modifier and getting rid of all of the abstract methods, and it gave no errors (except for the Option and NPCControllerJump classes not existing).

To fix this, you could just not use an abstract class and instead make all your abstract methods, normal methods with empty bodies and override those. But this means that classes extending your BaseNPC class does not have to override those methods. You could make your own rule to yourself to make sure every class extending BaseNPC has those methods, but if other people are going to use this, they might not follow that rule. So, to work around this, you could add default stuff to what are supposed to be your abstract methods and just not call super in your classes extending BaseNPC.

But there's still the problem of "But I want to add my own health stuff...". So here's what I tried to fix that.
I made my class extending CraftPlayer final and made something like this:

Code:java

 
public class CraftHumanNPC2 implements HumanNPC {
final CraftHumanNPC npc;
 
public CraftHumanNPC2(CraftHumanNPC npc) {
this.npc = npc;
}
 
public PlayerInventory getInventory() {
return npc.getInventory();
}
 
public CraftHumanNPC2 setHealth(double health) {
npc.setHealth(health);
return this;
}
 
public double getHealth() {
return 42; // Custom stuffz
}
}
 

The above code doesn't have any errors and acts like a "wrapper" class. In this wrapper class you add all the methods belong to the Player interface and just call the same method in the class extending CraftPlayer.
You could then extend the wrapper class and use it for everything and never use the class extending CraftPlayer anywhere else

 

Wow... I... Just wow. Thanks. I've never really seen someone post this much (I don't go much on Plugin Dev for this kind of stuff, so maybe I'm just blind). You deserve internets.
I've said it once, but, thank you.

edit: Just an off topic; is your avatar of the main char (forgot his name) from Guilty Crown? or is it main char from Kore wa Zombie Desu Ka?

 

Cirno I think it's Kirigaya Kazuto from SAO

 

Or... You could just add Bukkit to your build path above CraftBukkit...

 

Wolvereness But that's too easy xD