Solved Whats wrong with this code !?!?

Someone please tell me whats wrong with the code below, this is a simple plugin that "sethome" and "home". i tested it "sethome" command doesnt give any errors. but "home" command doesn't work
but when i sethome manually with a bed and then "home" command work perfectly.

Code:java

 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("sethome")){
            if(player.isOp()){
                player.sendMessage(ChatColor.BLUE + "Welcome to your new home!");
                player.setBedSpawnLocation(player.getLocation());           
 
            }else {
                player.sendMessage(ChatColor.RED + "No Permissions");
            }
        }
        if(cmd.getName().equalsIgnoreCase("Home")){
            player.sendMessage(ChatColor.GREEN + "Teleporting to home");
            player.teleport(player.getBedSpawnLocation());
        }
        return false;
 
    }
}

anyone? please!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Please only bump your posts once every 24 hours.


You didn't even specify what "didn't work", so we can't really help you. Are you getting errors in the console? Any weird crashes? Did your computer explode?

 

try

Code:java

player.setBedSpawnLocation(player.getLocation(), true);

seems like your version only sets bedspawn, if there is a valid bed.

 

MineDoubleSpace The code looks fine except you forgot to add 'return true;' when the command has been executed.
Have you added the home command to your plugin.yml file?

 

Adversarius TheGreenGamerHD JoshArgent


Still getting this console error

And plugin.yml is set, it sentMessage to the player, it just doesnt do the main job

Code:

22:55:05 [INFO] Preparing start region for level 2 (Seed: 3036716045621622727)
22:55:05 [INFO] [Home] Enabling Home v1.0
22:55:05 [INFO] Home Version 1.0 Has Beed Enabled!
22:55:05 [SEVERE] Error occurred while enabling Home v1.0 (Is it up to date?)
java.lang.NullPointerException
        at me.mds.home.homeset.onEnable(homeset.java:24)
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader
.java:457)
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage
r.java:381)
        at org.bukkit.craftbukkit.v1_6_R2.CraftServer.loadPlugin(CraftServer.jav
a:282)
        at org.bukkit.craftbukkit.v1_6_R2.CraftServer.enablePlugins(CraftServer.
java:264)
        at net.minecraft.server.v1_6_R2.MinecraftServer.l(MinecraftServer.java:3
13)
        at net.minecraft.server.v1_6_R2.MinecraftServer.f(MinecraftServer.java:2
90)
        at net.minecraft.server.v1_6_R2.MinecraftServer.a(MinecraftServer.java:2
50)
        at net.minecraft.server.v1_6_R2.DedicatedServer.init(DedicatedServer.jav
a:151)
        at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java
:391)
        at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:5
82)
22:55:05 [INFO] Server permissions file permissions.yml is empty, ignoring it
22:55:05 [INFO] Done (1.479s)! For help, type "help" or "?"
22:55:06 [INFO] ----- Bukkit Auto Updater -----

 

this error occurs in your onEnable().
Need to see your code of it.

 

Code:java

 
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Has been Disabled!");
    } 
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Beed Enabled!");
    }
 

This is my OnEnable() Adversarius

 

Then i would guess your logger-variable isnt initialized or created correctly.

 

Code:java

package me.mds.home;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class homeset extends JavaPlugin{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static homeset plugin;
 
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Has been Disabled!");
    } 
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Beed Enabled!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("sethome")){
            if(player.isOp()){
                player.sendMessage(ChatColor.BLUE + "Welcome to your new home!");
                player.setBedSpawnLocation(player.getLocation());               
            }else {
                player.sendMessage(ChatColor.RED + "No Permissions");
            }
        }
        if(cmd.getName().equalsIgnoreCase("Home")){
            player.sendMessage(ChatColor.GREEN + "Teleporting to home");
            player.teleport(player.getBedSpawnLocation());
        }
        return true;
 
    }
}

Here is the whole code Adversarius

 

The exception says line 24 in your code.
which line is it in the posted code? Because line 24 is empty here.

 

For what your doing your don't really need an OnEnable or OnDisable ?

 

MineDoubleSpace

Could you please post your plugin.yml also?

 

Code:

name: Home
main: me.mds.home.homeset
version: 1.0
author: MDS
commands:
  home:
      description: teleport player to home
  sethome:
      description: set player home

This is the plugin.yml pretty basic. Hoolean

and i removed line 24 which was just a blank line and it stopped giving me the console error, but the plugin is still not working, i'm getting an internal error when i use "/home"

Here is the problem i think what cause the error :
when I "/sethome" bedLocation doesnt update.
but when I set bed location manually by sleeping on a bed and using the command "/home"
then it teleports me to the bed, historio Adversarius

 

MineDoubleSpace

Could you please post your new code and the full error!

 

MineDoubleSpace Maybe look? at https://github.com/Bukkit/HomeBukkit/tree/master/src/main/java/com/dinnerbone/bukkit/home

 

did you changed your code like i said in post #4 to
player.setBedSpawnLocation(player.getLocation(), true);

 

That doesn't use player.setBedSpawnLocation() and is unneccesarily complicated for MineDoubleSpace 's needs.

 

Console error :

Code:

23:31:26 [INFO] MineDoubleSpace issued server command: /sethome
23:31:28 [INFO] MineDoubleSpace issued server command: /home
23:31:28 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'home
' in plugin Home v1.0
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:18
9)
        at org.bukkit.craftbukkit.v1_6_R2.CraftServer.dispatchCommand(CraftServe
r.java:523)
        at net.minecraft.server.v1_6_R2.PlayerConnection.handleCommand(PlayerCon
nection.java:964)
        at net.minecraft.server.v1_6_R2.PlayerConnection.chat(PlayerConnection.j
ava:882)
        at net.minecraft.server.v1_6_R2.PlayerConnection.a(PlayerConnection.java
:839)
        at net.minecraft.server.v1_6_R2.Packet3Chat.handle(SourceFile:49)
        at net.minecraft.server.v1_6_R2.NetworkManager.b(NetworkManager.java:296
)
        at net.minecraft.server.v1_6_R2.PlayerConnection.e(PlayerConnection.java
:118)
        at net.minecraft.server.v1_6_R2.ServerConnection.b(SourceFile:37)
        at net.minecraft.server.v1_6_R2.DedicatedServerConnection.b(SourceFile:3
0)
        at net.minecraft.server.v1_6_R2.MinecraftServer.t(MinecraftServer.java:5
90)
        at net.minecraft.server.v1_6_R2.DedicatedServer.t(DedicatedServer.java:2
26)
        at net.minecraft.server.v1_6_R2.MinecraftServer.s(MinecraftServer.java:4
86)
        at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java
:419)
        at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:5
82)
Caused by: java.lang.NullPointerException
        at org.bukkit.craftbukkit.v1_6_R2.entity.CraftPlayer.teleport(CraftPlaye
r.java:385)
        at org.bukkit.craftbukkit.v1_6_R2.entity.CraftEntity.teleport(CraftEntit
y.java:198)
        at me.mds.home.homeset.onCommand(homeset.java:36)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
        ... 15 more
>

java code :

Code:java

package me.mds.home;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class homeset extends JavaPlugin{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static homeset plugin;
 
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Has been Disabled!");
    } 
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Beed Enabled!");
    }
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("sethome")){
            if(player.isOp()){
                player.sendMessage(ChatColor.BLUE + "Welcome to your new home!");
                player.setBedSpawnLocation(player.getLocation());               
            }else {
                player.sendMessage(ChatColor.RED + "No Permissions");
            }
        }
        if(cmd.getName().equalsIgnoreCase("Home")){
            player.sendMessage(ChatColor.GREEN + "Teleporting to home");
            player.teleport(player.getBedSpawnLocation());
        }
        return true;
 
    }
}

historio Adversarius

 

yes i did tried it but still didn't work


That worked! thanks everyone for helping me! <33

Hoolean Adversarius

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Additionally to what Adversarius said, change:

Code:

if(cmd.getName().equalsIgnoreCase("Home")){
    player.sendMessage(ChatColor.GREEN + "Teleporting to home");
    player.teleport(player.getBedSpawnLocation());
}

to:

Code:

else if(cmd.getName().equalsIgnoreCase("home")){
    player.sendMessage(ChatColor.GREEN + "Teleporting to home");
    Location bedLocation = player.getBedSpawnLocation());
    if(bedLocation == null) {
        player.sendMessage(ChatColor.RED + "You don't have your home location set! Set it with /sethome or by sleeping!');
    } else {
        player.sendMessage(ChatColor.GREEN + "Teleporting to your home...");
        player.teleport(bedLocation);
    }
}

 

Thanks! I'm just starting on java.. Glad that you could help me <3

 

Sorry for not helping D:

 

Come on xD, you did help

 

Thanks