Solved Where is the mistake ?

Hi, I'm tryng to create a plugin, that should play a sound every time a player join the server.
I've tried with this code here

Code:java

package it.multicraft;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.Sound;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class JSound extends JavaPlugin {
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        for(Player player: Bukkit.getOnlinePlayers()){
            Location location = player.getLocation();
            player.playSound(location, Sound.NOTE_PIANO, 100, 1);
 
        }
    }
}
 

Eclipse and the console don't mark any error.

Now, can you tell me where is the mistake ?

 

Did you register your events?

 

chasechocolate Obviously not. It looks as though he is trying to create an EventHandler method in the main class, which, by the way, does not implement Listener nor is registered as an event listener

MCinemaGamer I suggest you look a bit more into how the Bukkit API works.

 

I've tryed with this code here. I created a second class called "Listener". I'm new at plugin development, and I'm working hard studyng the Bukkit API.
Here's the main class

Code:java

package it.multicraft.JSound;
 
import it.multicraft.JSound.JoinListener;
 
import org.bukkit.plugin.java.JavaPlugin;
 
public class JSoundMain extends JavaPlugin {
    public void onEnable(){
 
    }
    public void onDisable(){
        getServer().getPluginManager().registerEvents(new JoinListener(), this);
    }
 
}

And this is the Listener class

Code:java

package it.multicraft.JSound;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.Sound;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class JoinListener implements Listener {
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        for(Player player: Bukkit.getOnlinePlayers()){
            Location location = player.getLocation();
            player.playSound(location, Sound.NOTE_PIANO, 100, 1);
        }
    }
 
}

Thanks for the help

 

MCinemaGamer You're supposed to register your events when the plugin enables, not when it disables...

 

whops.... Sorry, I'm very distracted and I'm creating this plugin with a friend... He's not a genius
By the way, I'll try without this stupid mistake.

 

The onDisable method is called when the plugin disables. Most of the time, when the server shuts down.

 

Hi, thanks everyone, now it works perfectly !