Not Being Added To List

So basically I'm just trying out doing a queue system and whatnot. In theory, I would think this would work, but it's not. Actually, I can't even tell if it would work because I'm not being added to the list.

Code:java

public class Queue extends BukkitRunnable implements CommandExecutor
{
public ArrayList<String> queue = new ArrayList<String>();
private Core plugin;
 
public Queue(Core plugin)
    {
    this.plugin = plugin;
    }
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
    {
    PlayerData pData = new PlayerData(plugin);
    Player player = (Player) sender;
 
    if(!(pData.getPlayerData().isSet(player.getName() + ".allow-to-queue")) || pData.getPlayerData().getBoolean(player.getName() + ".allow-to-queue"))
        {
        player.sendMessage(ChatColor.RED + plugin.getName() + ": " + ChatColor.GREEN + "Added to queue. A match will be found momentarily.");
        pData.getPlayerData().set(player.getName() + ".allow-to-queue", false);
        queue.add(player.getName());
        pData.savePlayerData();
        return true;
        }
 
    player.sendMessage(ChatColor.RED + plugin.getName() + ": " + ChatColor.YELLOW + "You are unable to queue at this time.");
    return true;
    }
 
public void run()
    {
    System.out.print(queue.size());
 
    for(String players : queue)
        {
        if(queue.size() < plugin.getConfig().getInt("queueNumber"))
            Bukkit.getPlayer(players).sendMessage(ChatColor.RED + plugin.getName() + ": " + ChatColor.YELLOW + "A match was not found. Still searching...");
 
        else
            for(byte counter = 0; counter <= plugin.getConfig().getInt("queueNumber"); counter++)
                Bukkit.getPlayer(queue.get(counter)).sendMessage(ChatColor.RED + plugin.getName() + ": " + ChatColor.GREEN + "A match was found! Good luck!");
        }
 
    }
 
}

When I run the command everything goes fine. I get the text saying I've been adding, my allowed-to-queue changes successfully. However, my name is not being added to the list. I have the scheduler run every 30 seconds and each time it runs it displays nothing is in the list and I don't get any of the two messages that should occur. Anyone tell me what I'm doing wrong?

 

I'm not sure how you're scheduling the task and setting the executor, but if you're doing it like this:

Code:

this.getCommand("commandname").setExecutor(new Queue());
Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Queue(), 0, 600);

Then it's creating two separate instances with a different ArrayList<String> queue

 

I wouldn't try to use the same class as a BukkitRunnable and a CommandExecutor...

And when you check the list, retrieve it from the CommandExecutor object, not a BukkitRunnable instance (which is a temporary subclass and, as Polaris29 mentioned, is maintaining a different list than your command executor).

Quite frankly, I think your best bet is to maintain a central list in your main class, which both forms of the Queue access.

 

Alright, that actually helped. I basically just made a object of the class in my main and replaced all the instances instead. So now it looks like this.

Code:java

public void onEnable()
{
Queue queue = new Queue(this);
getCommand("queue").setExecutor(queue);
queue.runTaskTimer(this, 0, 600);
}

Thanks for the hint.