Easiest way to determine player's cause of death

Hi all, struggling to find the easiest way to determine a players cause of death.
Well actually I've found a way, my solution so far is basically upon EntityDamageByEntityEvent schedule a 1 second delayed task to check if the entity is dead.

Is there no easier way to do this? AFAIK this is the only way to get the LivingEntity cause
(EntityDeathEvent is useless for this, however works great when its a player killing an entity but not vice-versa)

I was trying to use getLastDamageCause on EntityDeathEvent with a few variants, and no luck

E2A:
I'm trying to get the mob (LivingEntity) that killed the player.

It's easy to get the player that killed the mob, or the damagecause that killed the player. But not what I want

This is what I have, and it works, but I am asking if anyone knows a more effective way

Code:

 
    @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)
    public void trackPlayerDeaths(EntityDamageByEntityEvent event) {
        if ((event.getEntity() instanceof Player) && (event.getDamager() instanceof LivingEntity)) {
            final Player victim = (Player)event.getEntity();
            final LivingEntity killer = (LivingEntity)event.getDamager();
         
            plugin.getServer().getScheduler().scheduleAsyncDelayedTask(plugin, new Runnable() {
                public void run() {
                    if (victim.isDead()) {
                        // blah blah blah
                    }
                }
            }, 20L);
        }
    }

Huge problem with this is that being attacked by multiple entities sets off a lot of these events when I only need it once

 

PlayerDeathEvent?
if(event.getCause() == such and such)

 

event.getCause doesn't exist in playerdeathevent.

Also I NEED LivingEntity to be returned, not damage cause or anything else

 

Code:

if(e.getLastDamageCause().equals(DamageCause.POOP))
{
  //stuff 

Something like that.

 

Just said I need LivingEntity nothing else

 

event.getEntity()

 

Returns the entity that just died

 

You did not specify which entity you wanted, just a LivingEntity
If you want the killer: .getKiller()
If you want the damager: .getDamager()

 

Yes getDamager on EntityDamageByEntityEvent is what I'm using currently, works well but I am wondering if there isn't an easier way instead of relying on a scheduled task to check if the attacked entity has died.

 

So you need to know how player died, yes ?
In PlayerDeathEvent, it is possible to do this:

Code:

event.getEntity().getLastDamageCause().getCause()

It returns DamageCause. Is that what you want ?

 

It seems like he wants a way to know how to check if the entity has died without a scheduler or EntityDeathEvent

 

Isn't it what the thing you quoted does ?

 

But I think for non-player entities as well, not sure though

 

Yo sho ?
Edit: I see yo no sho.

 

...
Also, I checked, he wants a living entity, not specifically a player

 

I'm trying to get the mob that killed the player.

It's easy to get the player that killed the mob, or the damagecause that killed the player. But not what I want

This is what I have, and it works, but I am asking if anyone knows a more effective way

Code:

 
    @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)
    public void trackPlayerDeaths(EntityDamageByEntityEvent event) {
        if ((event.getEntity() instanceof Player) && (event.getDamager() instanceof LivingEntity)) {
            final Player victim = (Player)event.getEntity();
            final LivingEntity killer = (LivingEntity)event.getDamager();
         
            plugin.getServer().getScheduler().scheduleAsyncDelayedTask(plugin, new Runnable() {
                public void run() {
                    if (victim.isDead()) {
                        // blah blah blah
                    }
                }
            }, 20L);
        }
    }

Huge problem with this is that being attacked by multiple entities sets off a lot of these events when I only need it once

 

This is what you're looking for right?

Code:java

@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
public void trackPlayerDeaths(EntityDamageByEntityEvent event) {
    if ((event.getEntity() instanceof Player) && (event.getDamager() instanceof LivingEntity)) {
        Player victim = (Player) event.getEntity();
        LivingEntity killer = (LivingEntity) event.getDamager();
 
        if (event.getDamage >= victim.getHealth()) {
            // Do Stuff
        }
    }
}

 

EDIT: Oops.
Use PlayerDeathEvent:

Code:

    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        EntityDamageEvent lastDamage = event.getEntity().getLastDamageCause();
    }

 

Great thank you this is better! However still getting multiple triggers when being attacked by multiple enemies, any idea how to avoid this? I'm trying to think of something now.

Not what I need bro

 

You need to listen to EntityDamageByEntity as you do now, but check

Code:

if(victim.getHealth()-event.getDamage() > 0) {
return;
}

It works. I use it in quester.

 

Code:

public void onPlayerDeath(PlayerDeathEvent ev){
Player p =event.getEntity();
if(ev instanceof EntityDamageEntityEvent){
EntityDamageEntityEvent even = (EntityDamageEntityEvent)ev;
//get killer, damagecauses, anything.
}
}

 

Lolmewn Almost...

Code:java

public void onPlayerDeath(PlayerDeathEvent ev)
{
    Player p =event.getEntity();
    EntityDamageEvent ev2 = p.getLastDamageCause();
    if(ev2 instanceof EntityDamageEntityEvent)
    {
        EntityDamageEntityEvent even = (EntityDamageEntityEvent)ev2;
        //get killer, damagecauses, anything.
    }
}

But there's something more scary in this thread:

...

...

... What is 'Thread-Safety' and how it affects me?

 

V10lator Close enough

 

It's async because all I need to do is add a mysql entry to my db scheduler, that should be OK?

You mean EntityDamageByEntityEvent?
Cannot cast from PlayerDeathEvent to EntityDamageByEntityEvent
and EntityDamageEvent gives Incompatible conditional operand types PlayerDeathEvent and EntityDamageEvent

Thank you very much for your help, will report back on how it goes

Edit: The problem is being hit by lots of entities causes this problem because the event is fired each time we're hit, it never actually triggers the code you posted.

 

aciid what about the code that V10lator posted?

 

aciid Well, as long as you know the difference between async an sync and are sure that victim.isDead() is thread safe it should be fine. I just posted this because (from my experience) most devs don't know it and use async blindly.

 

Legend!! Works perfectly, completely missed the code you posted x)
Thanks for all your help guys

 

Interesting. I don't really understand why it happens but I will definitely change it to the one you use.

 

I'm guessing player.isDead() checks if their hp is 0 or less

 

I mean why my solution bugs out so hard.