Scheduler time configurable ?

What I got:
- It starts from 10 seconds.
- At 5 seconds it starts to send the countdown to the player.
- After that it puts the player on a hashmap and stops/kills the task.

What I need:
- I want to make the timer/cooldown configurable.

Code:

private int warmup = 10;
int stopper;
 
    public void startCountdown(final Player player) {
        stopper = this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
              public void run() {
                  if (warmup == 5) {
                player.sendMessage(ChatColor.RED + "5");
                  }
                  if (warmup == 4) {
                player.sendMessage(ChatColor.RED + "4");
                  }
                  if (warmup == 3) {
                player.sendMessage(ChatColor.RED + "3");
                  }
                  if (warmup == 2) {
                player.sendMessage(ChatColor.RED + "2");
                  }
                  if (warmup == 1) {
                player.sendMessage(ChatColor.RED + "1");
                  }
                  if (warmup == 0) {
                 trash.put(player, true);
                  player.sendMessage(ChatColor.GREEN + "Timer is up.");
                 stop();
                  }            
                  warmup--;
              }
          }, 200L, 20L);
  }
 
  public void stop() {
      this.getServer().getScheduler().cancelTask(this.stopper);
      warmup = 10;
  }

 

@recon88
on your "200L" for example make it so:

Code:

this.getConfig().getLong("My_Long_Variable");

or Same thing for your repeating value:

Code:

}, this.getConfig().getLong("My_Long_Variable"), this.getConfig().getLong("My_Other_Long_Variable"); 

Full example:

Code:java

 
            plugin.getServer().getScheduler().scheduleAsyncRepeatingTask(plugin, new Runnable() {
                public void run() {
 
                }
            }, plugin.getConfig().getLong("Long_Value"), plugin.getConfig().getLong("Other_Long_Value"));
 

 

I still don't get it.

This happens now:
- Using command
- 10 seconds timer starts
- After that the 5 seconds countdown starts

Expected
- Using command
- 10 seconds timer starts
- 5 seconds later the countdown starts

Code:

private int warmup = 10;
int stopper;
    public void startCountdown(final Player player) {
        Long timer = this.getConfig().getLong("Warmup Time") * 20; // Simple maths to set seconds in the config.
        stopper = this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
              public void run() {
                  if (warmup == 5) {
                      player.sendMessage(ChatColor.RED + "5");
                  }
                  if (warmup == 4) {
                      player.sendMessage(ChatColor.RED + "4");
                  }
                  if (warmup == 3) {
                      player.sendMessage(ChatColor.RED + "3");
                  }
                  if (warmup == 2) {
                      player.sendMessage(ChatColor.RED + "2");
                  }
                  if (warmup == 1) {
                      player.sendMessage(ChatColor.RED + "1");
                  }
                  if (warmup == 0) {
                      trash.put(player, true);
                    player.sendMessage(ChatColor.GREEN + "Timer is up.");
                      stop();
                  }   
                  warmup--;
              }
          }, timer, 20L);
  }
 
  public void stop() {
      this.getServer().getScheduler().cancelTask(this.stopper);
      warmup = 10;
  }

Still can't find the solution.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Set warmup to 5 and your "Warmup Time" config to 5.

 

That would not fix it... I don't want a static 10seconds timer.. I want it to be configurable as I already said.

 

Code:java

private int warmup = 5;
int stopper;
    public void startCountdown(final Player player) {
        Long timer = (this.getConfig().getLong("Warmup Time") - 5) * 20; // Simple maths to set seconds in the config.
        stopper = this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
              public void run() {
                  if (warmup == 5) {
                      player.sendMessage(ChatColor.RED + "5");
                  }
                  if (warmup == 4) {
                      player.sendMessage(ChatColor.RED + "4");
                  }
                  if (warmup == 3) {
                      player.sendMessage(ChatColor.RED + "3");
                  }
                  if (warmup == 2) {
                      player.sendMessage(ChatColor.RED + "2");
                  }
                  if (warmup == 1) {
                      player.sendMessage(ChatColor.RED + "1");
                  }
                  if (warmup == 0) {
                      trash.put(player, true);
                    player.sendMessage(ChatColor.GREEN + "Timer is up.");
                      stop();
                  }   
                  warmup--;
              }
          }, timer, 20L);
  }
 
  public void stop() {
      this.getServer().getScheduler().cancelTask(this.stopper);
      warmup = 6;
  }

 

Silly me! :/

Thanks.

 

Can clean that up a bit...

Code:java

private int warmup = 5;
int stopper;
 
public void startCountdown(final Player player) {
    Long timer = (this.getConfig().getLong("Warmup Time") - 5) * 20; // Simple maths to set seconds in the config.
    stopper = this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
        public void run() {
            if (warmup > 0) {
                player.sendMessage(ChatColor.RED + Integer.toString(warmup));
                warmup--;
            } else {
                trash.put(player, true);
                player.sendMessage(ChatColor.GREEN + "Timer is up.");
                stop();
            }
        }
    }, timer, 20L);
}
 
public void stop() {
    this.getServer().getScheduler().cancelTask(this.stopper);
    warmup = 5;
}

 

Is Interger.toString neccesary if you have no other string in your message.
I have this code in 1 of my plugins and it works just fine.

Code:

int cd = getConfig().getInt("Countdown");
 
if ( cd % 30 == 0 && cd > 0 ){
                    Bukkit.getServer().broadcastMessage(ChatColor.DARK_RED + "THE GAME WILL BEGIN IN " + cd + " SECONDS!");
                }

 

the_merciless Yes, the Integer.toString is necessary in the "clean that up a bit" code, otherwise you'd get an error along the lines of operator + isn't defined for ChatColor and int. Using + on a string and an int is fine since Java will compile + to use a StringBuilder.

E.g.
System.out.println("Hello, we have " + currentPlayers + " players online. Max seen is " + maxSeenPlayers);
would compile to something like...
System.out.println(new StringBuilder("Hello, we have ").append(currentPlayers).append(" players online. Max seen is ").append(maxSeenPlayers).toString());

Also, instead of doing player.sendMessage(ChatColor.RED + Integer.toString(warmup)); could do player.sendMessage(ChatColor.RED.toString() + warmup); or even player.sendMessage(ChatColor.RED.toString() + Integer.toString(warmup));

 

Code:

                  if (warmup > 0) {
                      player.sendMessage(ChatColor.RED + Integer.toString(warmup));
                      warmup--;

Output:
5
3
1

Instead of:
5
4
3
2
1

 

Understood, thanks for the info

(sorry to hijack the thread i just had to ask out of interest)

 

Are you decrementing warmup elsewhere?

 

Code:

    private int warmup = 5;
    int stopper;
 
    public void startCountdown(final Player player) {
        Long timer = (this.getConfig().getLong("Warmup Time") - 5) * 20;
        stopper = this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
              public void run() {
                  if (warmup > 0) {
                      player.sendMessage(ChatColor.RED + Integer.toString(warmup));
                      warmup--;
                  } else {
                      trash.put(player, true);
                    player.sendMessage(ChatColor.GREEN + "Timer is up.");
                      stop();
                  }         
                  warmup--;
              }
          }, timer, 20L);
    }
 
  public void stop() {
      this.getServer().getScheduler().cancelTask(this.stopper);
      warmup = 5;
  }

 

Yes, you're decrementing it twice. Once inside the if and another time outside of the if.

 

I see.. My mistake.
Works now. Thanks =)