p.hasPlayedBefore() not functioning

Hi, I was making a very simple plugin.

I have no clue what's causing the issue, but whenever I sign on (regardless of playing before or not), it says "Welcome, ...!". Here is my code:

Code:

package suirisx;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Server;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.Plugin;
 
public class playerJoinListener implements Listener {
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
Player p = event.getPlayer();
if (p.hasPlayedBefore() == true) {
p.getServer().broadcastMessage(ChatColor.LIGHT_PURPLE + "Welcome back, " + event.getPlayer().getName() + ChatColor.LIGHT_PURPLE + "!");
} else {
p.getServer().broadcastMessage(ChatColor.LIGHT_PURPLE + "Welcome, " + event.getPlayer().getName() + ChatColor.LIGHT_PURPLE + "!");
}
 
 
public playerJoinListener(Plugin plugin) {
 
}
 
}

If you could please help identify the problem, it would be fantastic.
Thanks.

 

Just try

Code:

if (p.hasPlayedBefore()) { //code }

instead of using == true

 

I actually had it that way earlier, and talked to a friend who had been making Bukkit plugins before. He said to try that. I didn't change it back.

I'll try again

Nothing.

Also, just realized I'm missing a brace.

It still doesn't work.

 

just to clarify, has played before will check if theyve played on the -map- before.

 

This worked for me:

Code:java

     public void onPlayerJoin(PlayerJoinEvent event) {
        Player p = event.getPlayer();
        if (p.hasPlayedBefore()) {
            p.sendMessage("§dWelcome back, " + p.getName() + "!"); }
        else {
            p.sendMessage("§dWelcome, " + p.getName() + "!");
        }
    }

 

I've only got 1 map loaded, and it still doesn't work.

I plugged that code into the plugin, and it still says Welcome rather then Welcome back.

Here's WelcomePlugin.java

Code:

package suirisx;
 
import java.util.logging.Logger;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.event.Listener;
 
public class WelcomePlugin extends JavaPlugin implements Listener {
 
Logger log;
public final playerJoinListener pjl = new playerJoinListener(this);
 
 
public void onEnable() {
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(pjl, this);
 
}
 
public void onDisable() {
}
}

playerJoinListener.java:

Code:

package suirisx;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.Plugin;
public class playerJoinListener implements Listener {
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
        Player p = event.getPlayer();
        if (p.hasPlayedBefore()) {
            p.sendMessage("§dWelcome back, " + p.getName() + "!"); }
        else {
            p.sendMessage("§dWelcome, " + p.getName() + "!");
        }
    }
 
 
public playerJoinListener(Plugin plugin) {
 
}
}

Thanks :3

 

hmm, you might want to try doing the opisite

Code:java

 
if(!p.hasPlayedBefore() {
p.sendMessage("Welcome");
else {
p.sendMessage("Welcome back!");
}

 

I tried that. There's no avail.

Thanks for your help, everybody. I've still yet to get this to work.

 

Bump? Still no progress.

Anyone else think this is a Bukkit issue?

 

Try using p.getLastPlayed() will return 0 if they have never played before

 

I'll try that.

No luck. :I

 

server is saved?after log out?dont know if thats the problem...try saving it

 

Alright. I'll try that, although sometimes I'll just sign in then out, and then back in again. It should work? I'll post back later if that seems to fix it.