Changing A monster spawner

I want to be able to change a monster spawner by placing a sign above it saying:

Code:

[MS]
Mobtype

But that won't work. Here's what I got so far:

Code:java

 
package org.awesomecraft.plugins.monsterspawners;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.block.BlockFace;
import org.bukkit.block.CreatureSpawner;
import org.bukkit.entity.CreatureType;
import org.bukkit.event.block.BlockListener;
import org.bukkit.event.block.SignChangeEvent;
 
/**
 *
 * @author Will
 */
public class MonsterBlockListener extends BlockListener {
@Override
public void onSignChange(SignChangeEvent event) {
Block block = event.getBlock().getRelative(BlockFace.DOWN); //Block underneath the sign
if(block.getType() == Material.MOB_SPAWNER) {
if(event.getLine(1).equalsIgnoreCase("[MS]")) {
    if(event.getLine(2) != null ) {
        CreatureSpawner spawner = (CreatureSpawner) block.getState();
        if(event.getLine(2).equalsIgnoreCase("Chicken")) {
        spawner.setCreatureType(CreatureType.CHICKEN);
        }
        if(event.getLine(2).equalsIgnoreCase("Cow")) {
            spawner.setCreatureType(CreatureType.COW);
        }
        if(event.getLine(2).equalsIgnoreCase("Creeper")) {
            spawner.setCreatureType(CreatureType.CREEPER);
        }
        if(event.getLine(2).equalsIgnoreCase("Ghast")) {
            spawner.setCreatureType(CreatureType.GHAST);
        }
        if(event.getLine(2).equalsIgnoreCase("Giant")) {
            spawner.setCreatureType(CreatureType.GIANT);
        }
        if(event.getLine(2).equalsIgnoreCase("Pig")) {
            spawner.setCreatureType(CreatureType.PIG);
        }
        if(event.getLine(2).equalsIgnoreCase("PigZombie") || event.getLine(2).equalsIgnoreCase("Pig Zombie")) {
            spawner.setCreatureType(CreatureType.PIG_ZOMBIE);
        }
        if(event.getLine(2).equalsIgnoreCase("Sheep")) {
            spawner.setCreatureType(CreatureType.SHEEP);
        }
        if(event.getLine(2).equalsIgnoreCase("Skeleton")) {
            spawner.setCreatureType(CreatureType.SKELETON);
        }
        if(event.getLine(2).equalsIgnoreCase("Slime")) {
            spawner.setCreatureType(CreatureType.SLIME);
        }
        if(event.getLine(2).equalsIgnoreCase("Spider")) {
            spawner.setCreatureType(CreatureType.SPIDER);
        }
        if(event.getLine(2).equalsIgnoreCase("Squid")) {
            spawner.setCreatureType(CreatureType.SQUID);
        }
        if(event.getLine(2).equalsIgnoreCase("Zombie")) {
            spawner.setCreatureType(CreatureType.ZOMBIE);
        }
        if(event.getLine(2).equalsIgnoreCase("Wolf")) {
            spawner.setCreatureType(CreatureType.WOLF);
        }
        if(event.getLine(2).equalsIgnoreCase("Cave Spider")) {
            spawner.setCreatureType(CreatureType.CAVE_SPIDER);
        }
        if(event.getLine(2).equalsIgnoreCase("Enderman")) {
            spawner.setCreatureType(CreatureType.ENDERMAN);
        }
        if(event.getLine(2).equalsIgnoreCase("Silverfish")) {
            spawner.setCreatureType(CreatureType.SILVERFISH);
        }
        if(event.getLine(2).equalsIgnoreCase("Ender Dragon")) {
            spawner.setCreatureType(CreatureType.ENDER_DRAGON);
        }
        if(event.getLine(2).equalsIgnoreCase("Villager")) {
            spawner.setCreatureType(CreatureType.VILLAGER);
        }
 
    }
else {
event.setLine(2, "Error");
}
}
 
}
}
 
}
 

I receive no errors, nothing. It doesn't actually respond even when I put nothing on the second line:

Code:java

if(event.getLine(1) != null) {
//bla bla bla...
}
else {
event.setLine(2, "Error");
}

Thanks,

Billofbong

 

A sign has 4 lines, but they are not 1-4, they are 0-3, 0 being the first, 3 the last. Change those and see what happens. And if you want, I'll provide a "rough" copy of yours with all of that coded.

 

@steaks4uce
I hate to say it, but you happen to be one of the biggest dicks on the forums. You're full of yourself, grow up.

@billofbong
When I get a chance later today, I can assist you with this code here. I'm just too tired atm to be productive.

 

If you want to get mad because I tried to help, suite yourself, but if you're coming out with guns blazing, you better expect return fire. How I say things, it's yours to interpret, but if you take everything like it's against you, you're just paranoid. And just for starting a war, you can't talk, because you need to grow up.

I would imagine it would be something like this, also, I think you get the CreatureSpawner from the block and not it's state, but if not, it's an easy change. Also, this is just a rough version, some things might need changing.

Code:

Block spawner = event.getBlock().getRelative(BlockFace.DOWN);
if (spawner.getType().equals(Material.MOB_SPAWNER)) { //Make sure it is a spawner
    if (event.getLine(0).equalsIgnoreCase("[MS]")) { //Make sure its the correct sign
         event.setLine(0, ChatColor.GREEN + "[MS]"); //Fancy effects, yay!
         CreatureType ctype = CreatureType.fromName(event.getLine(1)); //Try and get creature from the text
         if (ctype != null) { //Not sure if this is needed
              CreatureSpawner cspawner = (CreatureSpawner) spawner; //Get the spawner from the block
              try { //Just in case of error with the creaturetype being null
                  cspawner.setCreatureType(ctype);  //Set it to our type
              } catch (Exception ex) {}
         }
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.