[INACTIVE][ECON] BetterShop 1.6.5- iConomy Global Command-based Shop [602 & 677]

Discussion in 'Inactive/Unsupported Plugins' started by jjfs85, Feb 4, 2011.

  1. Offline

    jjfs85

    BetterShop - The "better" global command-based shop that ties into iConomy:
    Version: v1.6.5 (1.6.5.3)
    Download: (static jar) BetterShop.jar
    (older, 602 compatible) BetterShop_1.6.2.8.jar
    (older, 556 compatible) BetterShop_1.6.2.5.jar
    (older versions are not supported, sorry)
    Authors: jascotty2, and jjfs85, with a little help from lologarithm.

    Webpage coming soon.

    Want the most up-to-date info on usage, features, the changelog, and more?
    Read the README!

    Plugin Information (as of v1.6.5.3 - 4/11/11)

    Commands (open)

    • /shop
      • for those used to a plugin having one command, this is another way to get to the following commands
    • /shophelp (shelp) [command]
      • shows you all the commands you can use
      • can show specific help for a command
    • /shoplist (sl,slist) [pagenum]
      • shows a listing of items for sale
      • (if -1, all, or full given, will show full list. (mainly for console use))
    • /shopitems (sitems)
      • show full listing of items in shop, without prices
    • /shopcheck (sc,scheck) <item>
      • lookup a specific item so you don't have to read through pages of prices
    • /shopbuy (buy,sbuy) <item> [amount]
      • buy an item for the price in the shopshop ("all" is accepted as an amount)
    • /shopbuyall (buyall,sbuyall) <item>
      • buy all of an item that you can hold
    • /shopsell (sell,ssell) <item> [amount]
      • sell an item for the price in the shop
    • /shopadd (sadd): <item> <buy> [sell]
      • add an item to or update an item in the price list
    • /shopremove (sremove): <item>
      • remove an item from the price list
    • /shopload (sload):
      • reload prices from pricelist database
    • /shopsellall (sellall): [inv] [item [...]]
      • Sell all of item from your inventory (alias to command /shop sell all)
      • (inv will not search lower 9 slots)
    • /shopbuystack (buystack): <item> [item | amount]
      • buy a stack of an item (usually 64)
    • /shopsellstack (sellstack) <item> [amount]
      • sell a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba):
      • repeat last buy action
    • /shopsellagain (sellagain,ssa):
      • repeat last sell action
    • /shopkits (skits):
      • show a listing of avalliable kits (will be elaborated later)


    Dependencies (open)

    BetterShop's dependencies:

    Economy plugins supported:


    iConomy
    - or
    BOSeconomy

    Supported Plugins:

    • Permissions v2.5.0+ by people - permissions and groups plugin
    or​
    • GroupManager by not Zenexer after all- a replacement for Permissions that is fully compatible with plugins that require it (using FakePermissions)
    • Help 0.2+
    • MinecraftIM


    Features (open)

    Features:
    configurable
    • Fully configurable colors and message text in config.yml file
    • shoplist can have text alignment (read config for more info): <item> <l(eft-aligned)> <buy and sell info>
      • - uses minecraft font character spacing, so is very close to perfectly aligned in chat
    • shoplist can optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • Items can be colored in the new itemsdb.yml file
    • also in itemsdb.yml: kits!
      • - define your own kits that the shop can sell
      • - three examples provided, edit and add to your liking
    • Configurable Options:
      • -max pagesize when printing shoplist
      • -whether to broadcast all transactions publicly
      • -name of the pricelist file/table
      • -customsort: a custom sorting order, so you can have items at the top of the shop list
      • -allowbuyillegal: if someone without BetterShop.admin.illegal can buy illegal items
      • -whether maxstack should be honored
      • -if used tools can be bought back
      • -default color for items
    shop flexibility
    • shopcheck will run a name comparison check, and return all matching items
    • Item sub-type support for dye colors, cloth colors, etc: magentacloth = 35:2 = cloth:magenta
    • "all" is a valid amount when buying or selling: "/sell cobblestone all" or "/sell all cobblestone"
    • damaged tools can be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    • buystack can be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • not just items can be bought anymore: can now buy LivingEntities, like dogs (wolf)
    • signs can be used for buying & selling
      • Code:
         [*][BetterShop]
         [*]buy [amt], buyall, buystack, sell [amt], sellall, sellstack
         [*]item name (recommended) or id:data, or for sellall: onhand, inv
         [*](unused line)
         [*]
      • to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • left-click for price check (or activate), right-click to buy/sell
      • if a unauthorized player destroys a block a sign is on, is canceled
      • can scan for uxexpected sign destruction (tnt) & replace it
    administration
    • Every item and subtype can be priced differently
    • Disable buying or selling of an item by giving it a price of -1 (0 makes it free)
    • command aliases to stop carpal tunnel
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • MySQL pricelist support
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
      • (flatfile is cached until manually updated)
    • Transaction records (MySQL or flatfile as .csv)
    • Downloads mysql-bin.jar dependency automatically
    • buy/sell cap in program set to 999,999,999 (not that you'd be using that much, but the cap is to prevent other errors)
    • if encounters errors while editing a player's account, will attempt to reload iConomy (i've had issuses with it before)
    • can backup the current pricelist: /shop backup
    • on start, can check the download page to see if there is an update available
    • /shop ver[sion] shows version # and if is up-to-date
    • shop can be given a finite stock from which to buy & sell
    • /shop ver[sion] to check the current version & see if there's an update
    • MinecraftIM support: forward errors or all messages
    • checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • help main page integration can be disabled
    • global shop can be disabled & only allow signs to be used


    Installing (open)

    Installation instructions:

    New Installation?
    Upgrading?

    • lots more added to config.yml all the time..
    • to 1.6.3+ ? Itemsdb.yml has been expanded to include entities
    • from before v1.6.1.3 ? Itemsdb.yml has been expanded:
      • not required to update, but recommended
      • if you've already edited yours, you can look here and see what i've added
        • mainly: leaves, charcoal, tools & armor damage, some more aliases
    • from version 1.5.9b - 1.6.1.0 and use MySQL transaction logging?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
      • ALTER TABLE BetterShopMarketActivity CHANGE COLUMN SOLD SOLD TINYINT;
        • optional, but useful for php
    • from version between 1.5.5 - 1.5.9 and use MySQL pricelist?
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN BUY BUY DECIMAL(11,2);
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN SELL SELL DECIMAL(11,2);
    • from an earlier version?
      • Will import your old pricelist.yml into the db you have setup in the config :)
      • Items.db is no longer used - delete it :)
    Permissions:

    Just add the following nodes to Permissions' world.yml file (or data.yml file for GroupManager):


    - 'BetterShop.user.*'
    ^ Allows the user to use the list, sell, buy, and help commands
    - 'BetterShop.admin.*'
    ^ Allows the user to use the add, remove, and load commands

    Alright, so you have the plugins in place and set up, and permissions nodes added to the Permissions' config.yml. Now just place the BetterShop.jar file in the server's plugins directory. Then just start the server and add things to the shop. That's all!

    Adding Items:
    There are two ways to add things to the shop:
    1. Recommended, but slow: use /shopadd [item] [buy-price] [sell-price]
    2. Faster: use a text editor or spreadsheet program to edit the pricelist.csv


    TODO (open)

    features listed here may already be in the works, or may be on the back burner
    if you want a new feature, or want something sooner, ask :)

    • calculated/derived item prices
    • /shopvalue item[@amount] item to show the current trade value for two items
    • discount system: users or groups can be charged less/more for an item or all items (sell prices also affected)
    • dynamic market pricing, based off of logged market activity
    • region shops (items added while in a region defined as a shop are only added to that shop)
    • add option for amount in stock for surplus decreases how much item is worth to the shop
    • /shop alias <item> - show the itemname, with a list of aliases
    • add pages for /shopitems
    • more descriptive kit listing, similar to shoplist:
      • - pages
      • - show what makes up a kit
      • - enable admin.add to see avaliable kits
    • SQLite support?
    • tie item prices to stock quotes?
    • craftables' stock is tied to source material stock (if using sell craftables)
    • make LivingEntities follow the owner around?
    • change buystock if itemStock is enabled so that if trying to buy multiple stacks (buystack item 20) and stock runs out to stop buying (stop showing "out of stock")
    • individually-customizable restock stock values per-item
    • chest shop interface ?
    • automatically add missing config nodes (preserving comments)
    • add a simple builtin economy system, if none found?
    • add categories to items
      • - can search, buy, & sell with category
    • user-owned shops (signs, linked to chests)
    • 4th line for configurable prices or shop profit owner


    Changelog (open)

    Changelog:
    (the (?) means plugin didn't report that as the version.. sorry :))

    Version 1.6.5.3 - 4/11/11 - jascotty2
    • added option to disable sign protection
    • added sign action wait, to prevent sign click spamming
    • fixed a nullpointer error when selling
    Version 1.6.5.2 - 4/11/11 - jascotty2
    • removed spawnwolf debugging line
    • wolves bought have correct health
    Version 1.6.5.1 - 4/10/11 - jascotty2
    • removed a debugging line
    • wolfs bought have their owner already set (need to increase health)
    Version 1.6.5.0 - 4/10/11 - jascotty2
    • corrected new settings (missed some previously)
    • fixed default sign pricecheck showing wrong one
    • fixed messenger formatting error
    • misc. null fixes
    • BOSEconomy support added
    • changed block protection from scan to save (should improve performance)
    • added tnt protection, in the form of a scanner that routinely checks that all shop signs & their anchors still exist
    • added syntax check for /buy & /sell # [item] (like the sign syntax)
    • allowbuyillegal now defaults to true
    • fixed color set (hidden logic error)
    • signs can have the item name colored according to the defined item color
    Version 1.6.4.2 - 4/9/11 - jascotty2
    • fixed sign destroy permission check to only check bettershop signs
    Version 1.6.4.1 - 4/8/11 - jascotty2
    • "inhand" and "inv" added as valid sellall/buyall items (signs only)
      • - "in hand" buys/sells all of the type of item in the player's hand
    • sign destroy protection algorithm improved (still can't check for explosions :( )
    Version 1.6.4.0 (?) - 4/8/11 - jascotty2
    • stock message error fixed when selling too much
    • fixed <curr> causing a server freeze
    • added amount to pricecheck, so can check the result buy/sell price
    • fixed a buying error when already has some of the item
    • added a sign interface
      • - first line: [BetterShop] (not case-sensitive)
      • - second line: action: buy [amt], buyall, buystack, sell [amt], sellall, sellstack
      • - third line: item (name, id, etc)
      • - fourth line: unused (was going to make price, but decided on pricecheck instead)
      • - to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • - left-click to pricecheck
      • - right-click to run action
    • if a unauthorized player destroys a block a sign is on, is canceled
    • fixed column check for table updating
    • updated for 670
    • configuration nodes are moved to more organised parent nodes (easier to edit if using an intelligent text editor)
      • - older nodes are still supported (for now)
    Version 1.6.3.6 - 4/6/11 - jascotty2
    • again, previously forgot to update the date in last version
    • - added additional checks to prevent future false-positives
    • -- (also checks if comment on download matches plugin, not if plugin >= comment version)
    • figured out the integrity check errors :)
    • now runs checks on changed tables to check if needs updating (and adds columns as necessary)
    • - just transaction log table for now (only table with added columns)
    • another option added: AutoUpdate
      • - if a new update is found, will download & install
      • - can also run manually with /shop updade (OP-only, since forces update & restarts server plugins)
    Version 1.6.3.5 - 4/4/11 - jascotty2
    • fixed a rare null exception in integretycheck?
    • fixed saving errors when transaction logging disabled
    • implemented infinite stock (setting stock to -1 makes infinite)
    • # 1,000+ downloads in one day!
    Version 1.6.3.4 - 4/3/11 - jascotty2
    • fixed a rare invalid function signature error
    • fixed if a player tries to buy/sell air
    • OPs now completely bypass security checks
    • more changes to error reporting format: added a custom message
    • # 10,000+ lines of code :)
    Version 1.6.3.3 - 4/2/11 - jascotty2
    • renamed monstertamer package, to avoid conflicts if you're using the monstertamer plugin
    • should have a reported bug in integrety check taken care of.. not sure of the cause, though
    Version 1.6.3.2 - 4/2/11 - jascotty2
    • fixed more error reporting bugs (still can't find one stupid stock flatfile bug)
    • added stock messages to config
    Version 1.6.3.1 - 4/1/11 - jascotty2
    • fixed chickens & buying more than one animal
    • updated error reporting(again)
    • rand libary update for my (jascotty2's) version of CookieMonster
    Version 1.6.3 - 4/1/11 - jascotty2
    • fixed buy/sell == 0 ? no (in shoplist, 0 incorrectly showed as no)
    • updated for 612 (and 600+ .. had accidently been using the wrong libary)
    • LivingEntities can now be purchased! :D
      • special thanks to fullwall for the MonsterTamer plugin, from which this ability comes from (1.3)
      • if capable, will attack the anything attacking the purchaser (if nearby)
    Version 1.6.2.8 - 3/31/11 - jascotty2

    • nullpointer fixed if running 602 with old groupmanager
    • other misc. null fixes
    • removed redundant reload points for iConomy
    • repaired a mysql totalTransactionLog format error
    • error reporting now begins with a portion of the date, so i can see them listed in order
    • more info added to error reports.. still can't figure out the stock flatfile save bug
    Version 1.6.2.7 - 3/30/11 - jascotty2

    • improved error reporting format & removed a few unnecessary send triggers
    Version 1.6.2.6 - 3/30/11 - jascotty2

    • now checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • now compatible with bukkit 602
    • help main page integration can be disabled
    • hidden changes to get one step closer to dynamic pricing
    Version 1.6.2.5 - 3/28/11 - jascotty2

    • forgot to update the date in the last release, so a false 'newer release' was showing up
    • fixed help support when help loaded before bettershop
    Version 1.6.2.4 - 3/25/11 - jascotty2

    • Added support for my new plugin: MinecraftIM :)
    • removed a stock debugging line i forgot to remove
    • manually set locale for updating date format.. should fix non-us countries?
    Version 1.6.2.3 - 3/23/11 - jascotty2

    • added stock db to reload
    • fixed a stock update on sell
    • updated plugin commands to include sellstack (oops :oops:)
    Version 1.6.2.2 - 3/23/11 - jascotty2

    • more commands added to register with help
    • fixed a MySQL update syntax error for stock
    Version 1.6.2.1 - 3/23/11 - jascotty2

    • fixed a plural search bug
    • added /sellstack (much like buystack)
    • fixed a buyagain logic error
    • /shop import <file> - insert values from file in plugin folder
    • /shop restore <file> - clear shop & load from saved backup file
    • flatfile itemstock repaired
    Version 1.6.2 - 3/23/11 - jascotty2

    • stock option - items can have a finite amount
      • selling to the shop increases the stock, buying decreases
      • can have a minimum update interval: time before will reset stock to initial amounts
      • maximum stock: most will hold
      • noOverStock: will not allow selling if item stock is full
    • note on stock: does not track each item's damage values (if tools)
      • (selling a damaged good allows 1 intact to be bought)
    • /shop restock (permission BetterShop.admin.restock) to update how much stock the shop has
    • permission node BetterShop.admin.backup added for backing up the pricelist
    • added Help plugin integration: will automatically register commands with help
    • added some more MySQL db connection reconnect points (autoReconnect=true not working is becomming irritating)
    • more checking for iConomy account editing failures (i've had more problems with it)
    • fixed a format error if using a replacement char in listing (like <l.>)
    • retructured sellall inventory editing
    • # passed 7500 lines of code! (430KB)
    Version 1.6.1.4 - 3/21/11 - jascotty2

    • (hopefully) fixed MySQL region formatting errors (such as europe where the decimal is a comma)
    • addto/updated help menu
    • added [command] to help: lookup a specific command (also accepts aliases)
    • fixed flatfile total transactions log
    • shop ver[sion] also shows if the plugin is up-to-date
    Version 1.6.1.3 - 3/20/11 - jascotty2

    • default color for items
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • fixed transaction log insert missing the price
    • was having problems reading bit from php, so shanged SOLD column from bit to tinyint
      • alter table BetterShopMarketActivity change column SOLD SOLD TINYINT;
    • finished flatfile support for transaction logging
    Version 1.6.1.2 - 3/20/11 - jascotty2

    • runs MySQL connection check before executing database queries, and manually attempts reload if not connected
      • (still trying to iron out MySQL connection bugs, but this should end those errors)
    • removed list debugging lines i forgot to remove earlier
    Version 1.6.1.1 - 3/19/11 - jascotty2

    • removed double negative add check.. can add an item for -1, -1
    • fixed some Item errors: color and .equals(ItemStack).. fixes itemdb colors and sellall
    • fixed page numbering for when there are hidden items
    • fixed sell for 0: a <= instead of < .. thought i'd fixed that, but apparently not all of those.
    Version 1.6.1 - 3/19/11 - jascotty2

    • update check is optional (in config)
    • /shop backup to save pricelist to a backup csv file
    • updates itemsdb on shopload, in case the admin wanted to update colors/kits and such
    • added price column in marketHistory table
      • upgrading from older version?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
    • added flatfile support for transaction logging (uses csv)
    • removed pricelist save file on close (is already saved on edit)
    • if an item is marked as no buy, no sell, don't show on shoplist
    • itemsdb names can be saved (and outputted) with title formatting (eg RedstoneTorch)
    • - included itemsdb also expanded & names formatted
    • case-insensitive item matching
    Version 1.6.1 alpha - 3/18/11 - jascotty2

    • Checks git to see if there is a newer version avaliable
    • fixed price = 0 to be free
    • fixed null in sellall if selling all sellable
    Version 1.6.0f - 3/18/11 - jascotty2

    • better error check for config & importing old yml pricelist
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
    • fixed sell bug (selling one would credit for amount in the first stack)
    Version 1.6.0e - 3/17/11 - jascotty2

    • fixed a removal error - there was a typecast exception previously
    Version 1.6.0d - 3/17/11 - jascotty2

    • if the old PriceList.yml file exists, will import into whatever db is enabled, then rename the file
    • fixed public message bug - would send broadcast (num_players-1) times
    Version 1.6.0c (?) - 3/17/11 - jascotty2

    • added more options: allowbuyillegal, usemaxstack, buybacktools
    • fixed buystack history
    • major buystack logic error repaired - previously didn't work correctly
    • buystack can now be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • damaged tools can now be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    Version 1.6.0b (?) - 3/16/11 - jascotty2

    • fixed a minor buy error if tried to buy more than they can hold, and could hold 0 more
    • major MySQL problem fixed - pricelist table wasn't being created
    Version 1.6.0 - 3/16/11 - jascotty2

    • major code restructure & reorganization
    • changed item db to a more descriptive yml file
      • can define what items make an item (for calculated/dynamic costs)
      • can change what color it will be outputted as in the listing
      • define kits (sold.. store won't buy them)
    • MySQL buy & sell fields increased to decimal(11,2), and cap in program set to 999,999,999
    • shoplist can now optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • removed value check - can now "sell" items that sell for 0
    • added /shop command alias - for if a user is more used to "/shop help" than "/shophelp"
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • now does pre-check for if user can hold as much as they're trying to buy
      • and "all" to try to buy as many as they can hold
    • items can be marked as illegal, and can only be purchased by a select few (using permissions)
      • also not shown to users who cannot buy them, except with pricecheck
    • option in config to make transactions publicly broadcasted
    • option in config to have a custom sort order
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • now shows what items were sold when using shopsellall
    • fixed bug where single sell parameter would == sell [item] all
    • all, full, -1 added as a pricelist pagenumber: will print the full list (intended for console use)
    • marketactivity table truncate logic repaired..
    • marketactivity MySQL table changed with primary key(DATE, USER, ID) (instead of DATE, USER) to resolve conflicts with sellall
    • items can be marked as 'legal: false', and only those with permissions can buy them (can still sell)
    • if encounters errors while editing a player's account, will attempt to reload iConomy
    • sellall can be given "inv" as first parameter to only sell from inventory (not in quick access slots)
    • shopcheck given partial name matching: "/shopcheck wool" (not "shopcheck 35") will show all colored wool prices :)
    • fixed sellall bug when an item not for sale
    • /shopbuystack (buystack): buy a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba): repeat last buy action
    • /shopsellagain (sellagain,ssa): repeat last sell action
    • /shopkits (skits): show a listing of avalliable kits (will be elaborated later)
    • can now buy kits :)
    • /add now has sell as an optional parameter.. will set to -1 if not given (or if is a kit)
    Version 1.5.9b - 3/11/11 - jascotty2

    • width outputting in minecraft chat (for /shoplist): now can have item (or listing) right-align, left-align, or centered
    • implemented transaction log and total transactions record
    • no longer dependent on permissions: if missing, ops have .admin.* & everyone has .user.*
    • bugs: MySQL buy & sell is decimal(6,2), limiting price to 9,999 (plus a nondescriptive error)
      • to fix (db minecraft, table BetterShop):
      • alter table minecraft.BetterShop change column buy buy decimal(11,2);
      • alter table minecraft.BetterShop change column sell sell decimal(11,2);
    • unknown error: MySQL connection seems to get dropped & won't connect until restart plugin
      • seems to stem from iConomy (v4.4 (Arcadia)) or v0.2 [Coelho].. i only have 4.4, but .2 is being logged
      • shopload should fix this, but iconomy will still be down.. if you have a plugin like hotswap, reload iConomy
    • not a bug, but forgot to remove: debug output of select statements being executed
    Version 1.5.8(?) - 3/10/11 - jascotty2

    • fixed a sell error for one parameter
    • major-ish code restructure - removed data redundancy
    • / shopsell all [item] (alias to /shopsell [item] all)
    Version 1.5.7(?) - 3/10/11 - jascotty2

    • / shopsell [item] all added: sell all of an item that you have
    • fixed total sell value min to .01 instead of 1 (if your server uses low prices)
      • before this fix, one could get around this check by trying to sell alot of an item
    • now automatically downloads mysql dependency (zip from mysql mirror & unzip or from iConomy mirror)
    Version 1.5.5(?) - 3/9/11 - jascotty2

    • Pricelist can now be in a MySQL database
    Version 1.5.4 - 3/2/11

    Fixed some lingering bugs with lologarithm's help.


    Version 1.5.3
    Fixed sell 0 < sellprice < 1 bug.


    Version 1.5.2
    Now it'll convert your old pricelist.yml to the new 1.5.x format automagically!


    Version 1.5.1
    Fixed the bug where setting a price to -1 didn't disable it
    Fixed the "LOLWTFDOESN'TWORK" bug.
    Made price-list listing configurable in config.yml. The way it was 'sposta be.

    (older versions not shown..)

     
  2. Offline

    RustyDagger

    I like the idea of the server stock then i would finally allow my users to buy items from the shop.I have had iconomy in the past and only ever allowed selling. and buying from player based shops.

    I don't like the server creating items. never have and never will. This plugin will be a must have for me after its next update.
     
  3. Offline

    dragonking

    why do some items in my list not pop up ingame, is there a limit on 6 shoplist pages???
     
  4. Offline

    jjfs85

    If you could be more specific about which items aren't showing up, that'd help. I can tell you that on my server I currently have 16 pages of items that can be viewed ingame. I'd also suggest pastebinning your PriceList.yml. you may have a formatting error somewhere in there.
     
  5. When I do /shopadd 35.1 etc, it says "what the heck is 35.1?". How do I go about adding different colour wools, different dyes?
     
  6. Offline

    Zawmbee

    Whenever I type any of the commands, it just repeats them back to me in red text. What am I doing wrong?
     
  7. Offline

    Arisilde

    Is there a way to make it so you can sell and item but not buy it? and is there a way to set aliases to the commands?
     
  8. Offline

    dragonking

    i will say that i added all items through the text file by changing the values etc. and that you can buy/sell stuff that dosnt show up in the shop list so the values work but dont show up
     
  9. Every ninth item on the list is now showing up with /shoplist. But is available to buy/sell.
     
  10. Offline

    Lewis

    Hi!

    Have the plugin installed and seems to be working for myself, the Admin. However despite giving permissions to my Users, they keep getting the message "You do not have permission" I have the Permissions set up absolutely right, and am using the individual nodes rather than the BetterShop.user* as I don't want things to be purchased.

    I would appreciate it if you could spread some light on this situation for me!

    Thanks :)
     
  11. Offline

    highwisdom

    very nice! this shop plugin had a hand up on the competition simply for having the /shopcheck command.

    Suggestions:
    1. more than anything..better display colors..all pink is a pain to read
    2. Having admins type longer commands to edit the shop inventory every so often is ok, but players will be using this alot..soo...shorter commands would be good..at LEAST these: /buy, /sell, /check
    3. optional limited item stock. having infinite amounts of all items for sale = everything becomes valueless.
    4. listing items alphabetically

    bug:
    - items not listed in the shop can be sold..but they just dissappear, no money is received.
     
  12. Offline

    jjfs85

    Use the 35:1 syntax. Sorry, will be adding that to the OP.
    Not sure... That's supposed to be the result of you having bad or missing parameters in your command. I'd double check you typed everything in properly. Try this: "/shophelp" (no quotes). That should at the very least (assuming you have the BetterShop.user.* permission) show you a list of the commands and their usage.
    Not yet, this will be in the next update. Setting a buy or sell price to -1 will disable that function for the item.
    Okay. I really want to see the PriceList.yml files from you two. This could help me fix this problem for the next update. Very strange though.... very strange. The every ninth problem is definitely due to each shoplist page being 9 items long....
    I'll make sure my permission checking works for this as intended if you make sure you've given them (and I'd copy and paste this next bit right into the permissions file to be sure it's totally right) 'BetterShop.user.sell'.
    The suggestions are certainly good ones, all but the alphabetical listing are planned for some point. 1 and 3 will be in the next update and the bug will be fixed too.

    Thanks guys. Have a nice day.
     
  13. Offline

    dragonking

    i just tried installing the latest version and even add every item by ingame commands... sane thing

    <Edit by Moderator: Redacted filesmelt url>
     
    Last edited by a moderator: Feb 23, 2019
  14. Offline

    jjfs85

     
    Last edited by a moderator: Feb 23, 2019
  15. Offline

    dragonking

    umm well we use xenon servers so the bukkit part can be the cause, we also have trouble with worldguard, worldedit and monsterhunt....

    alternatively we can try installing bukkit manually of course :)
     
  16. Offline

    jjfs85

    Hmm. I'd give that a shot then. Sorry your having issues, but I think craftbukkit build 260+ is required.
     
  17. Offline

    dragonking

    i just installed the newest working build, did not fix it...
     
  18. Offline

    mcfreak

    Hey. After I added
    - 'BetterShop.user.*'

    to permissions.yml, console gives a lot of erros, commands doesnt work, my config doesnt want to load full (example i had set mobs to off, they went on), I wasn't admin.

    screen console
    [​IMG]
     
  19. Offline

    Jamie

     
  20. Offline

    jjfs85

    I really want to blame it on Permissions. In fact, the error occurs here:
    Code:
        public void setupPermissions() {
        Plugin test = this.getServer().getPluginManager().getPlugin("Permissions");
    
        if(this.Permissions == null) {
            if(test != null) {
            this.Permissions = ((Permissions)test).getHandler();
            } else {
            >>>>> log.info(Messaging.bracketize(name) + " Permission system not enabled. Disabling plugin.");
            this.getServer().getPluginManager().disablePlugin(this);
            }
        }
        }
    In the code above, the line marked with >>>>> is where the error is occurring. That line should not even be reached if Permissions is properly in place and working. The above code is also exactly what Nijikokun specifies as the suggested method for initializing the Permissions interface. So, I really do think that Permissions is where your problem is right now.

    I'd doublecheck that the indentation in permissions.yml is correct, that you didn't accidentally put a tab character in, that Permissions.jar is properly in the plugins folder, etc. Sorry I can't offer more specific advice, but I don't know what your setup is and can't reproduce the problem (at least on build 303 from yesterday).
    --- merged: Feb 11, 2011 9:36 PM ---
    Can you give me a list of the other plugins on your server? Also, do you see any error messages in your server console?
     
  21. Offline

    dragonking

    bettershop, LWC, epiczones, essentials (all of the essentials) guestbook, guilds, herobounty, heroicdeath, iconomy, levelcraft, monsterhunt, permissions, worldedit, worldguard

    i think essentials has a /sell command
     
  22. Offline

    jjfs85

    I'll try to reproduce your problem. Give me tonight to try it out. Oh, Linux or Windows?
     
  23. Offline

    mcfreak

    config.yml

    Code:
    # Supports "Default" and "GroupUsers"
    plugin:
    permissions:
    system: default
    
    ##
    # Groups can contain inheritance.
    # To make a group inherit the permissions from another
    # group simply place the groups name in the "inheritance:"
    # field seperated by commas.
    #
    # Example: inheritance: Default,Admins,
    ##
    # All permissions including the asterisks must be placed in single quotes.
    # like so:
    #
    # - 'general.spawn'
    #
    # Otherwise errors will happen!
    ##
    # Globalized Permission settings:
    #
    # If a permission contains periods (.) you can denote a globalized parameter:
    #
    # - 'general.*'
    #
    # This will allow you to use all general commands.
    #
    ##
    #
    # Single Asterisk denotes all commands:
    #
    # - '*'
    ##
    groups:
    Default:
    default: true
    info:
    prefix:
    suffix:
    build: true
    inheritance:
    permissions:
    - 'essentials.help'
    - 'essentials.spawn'
    - 'essentials.sethome'
    - 'essentials.home'
    - 'essentials.whois'
    - 'essentials.tpa'
    - 'essentials.tpaccept'
    - 'essentials.tpdeny'
    - 'essentials.tptoggle'
    - 'essentials.warp'
    - 'essentials.mail'
    - 'essentials.getpos'
    - 'essentials.msg'
    - 'essentials.afk'
    - 'essentials.rules'
    - 'essentials.compass'
    - 'essentials.helpop'
    - 'BetterShop.user.*'
    Admins:
    default: false
    info:
    prefix:
    suffix:
    build: true
    inheritance:
    permissions:
    - '*'
    I have only error when I add - 'BetterShop.user.*' line to config.yml. Same thing with LWC plugin
     
  24. Offline

    dragonking

     
  25. Offline

    jjfs85

    You need indentation, man. Look at this example:
    Code:
    # Supports "Default" and "GroupUsers"
    plugin:
        permissions:
            system: default
    
    ##
    # Groups can contain inheritance.
    #   To make a group inherit the permissions from another
    #   group simply place the groups name in the "inheritance:"
    #   field seperated by commas.
    #
    #   Example: inheritance: Default,Admins,
    ##
    #   All permissions including the asterisks must be placed in single quotes.
    #   like so:
    #
    #       - 'general.spawn'
    #
    #   Otherwise errors will happen!
    ##
    #   Globalized Permission settings:
    #
    #       If a permission contains periods (.) you can denote a globalized parameter:
    #
    #           - 'general.*'
    #
    #       This will allow you to use all general commands.
    #
    ##
    #
    #   Single Asterisk denotes all commands:
    #
    #       - '*'
    ##
    groups:
        Default:
            default: true
            info:
                prefix:
                suffix:
                build: true
            inheritance:
            permissions:
                - 'general.spawn'
        Admins:
            default: false
            info:
                prefix:
                suffix:
                build: true
            inheritance:
                - Default
            permissions:
                - '*'
    
    ##
    # DarkGrave has control over all general commands.
    # sk89q can use /spawn & /setspawn
    ##
    users:
        darkgrave:
            group: Default
            permissions:
            - 'general.*'
        sk89q:
            group: Default
            permissions:
            - 'general.spawn.set'
    --- merged: Feb 13, 2011 3:08 PM ---
    Two things, first: I couldn't reproduce your issue... second: I assumed linux.
     
  26. Offline

    dragonking

    windows, can you make items unsellable but still buyable?
     
  27. Offline

    ShotgunWizard

    Hey, I love your plugin, but I can't get it to work with permissions for whatever reason. Using Craftbukkit 313, BetterShop 1.3, and Windows.

    It works for addmins, but BetterShop.user.* doesn't work for users. I even added the commands individually, and it still didn't work. Any help? I'd much rather use this plugin.
     
  28. Offline

    jjfs85

    Not yet, next update.
    And I'll doublecheck this issue. Can you post a screenshot of any console errors and your config.yml file? Rapidshare or pastebin or CODE tags is fine
     
  29. Offline

    ShotgunWizard

    That's the thing, there's no error message, there's no console errors. Just 'Oi! You don't have permission for that!'.

    Here's the group affected:
    I know it's not the typical Permission layout, it's what essentials changes it to using /modgrp. Works with everything else though, so BetterShop should be working.
     
  30. Offline

    jjfs85

    Strange! Checking it out now.

    Edit - it is proper YAML, so no issue there. I'm going to make sure this works with the next update I release. Sorry for the inconvenience.

    Edit 2 - Maybe this is the cause: go to http://yaml-online-parser.appspot.com/ and type in this code and hit Ctrl-enter.
    Code:
    groups:
        Default:
            default: true
            info:
                prefix:
                suffix:
                build: true
            inheritance:
            permissions:
                - 'BetterShop.user.*'
    Notice how the parsed output on the right has nicely nested nodes? compare that to the output of your code,
    Code:
    Default:
    default: true
    info: {prefix: '', suffix: '', build: true}
    inheritance: []
    permissions: [general.spawn, essentials.list, essentials.sethome, essentials.mail,
    essentials.helpop, essentials.clearinventory, essentials.whois, essentials.spawn,
    essentials.help, essentials.motd, essentials.afk, essentials.msg,
    essentials.getpos, essentials.tpahere, essentials.tpaccept, iConomy.payment,
    iConomy.rank, iConomy.list, iConomy.withdraw, iConomy.deposit, essentials.tpa,
    essentials.tpdeny, BetterShop.user.*]
    And you'll notice that it's not all nested. I think that may be the issue. More testing and hopefully a way around this is coming for the next update.
     
  31. Offline

    ShotgunWizard

    Yea, I thought that as well. It works for all the other commands so I don't think that's it. My code WAS nicely nested until the Essentials plugin rewrote it.

    Thank you for the parser though, that's a great link for me to get it back in the original nice and neat nested format.

    Testing now, will let you know!
     

Share This Page