Checking if command has been executed

Hi guys, I need hlpe with somehing.
I need to check if a command has been executed and I have no idea how, I tried using bot CommandPreProcessEvent and PlayerChatEvent, but none of the work...

 

@beatcomet
Use onCommand. it goes in your main class (the one with onEnable and onDisable)

PHP:

public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {

In one of my plugins I use it like this:

PHP:

    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        Player player = (Player)sender;
        if (command.getName().equalsIgnoreCase("teletab")) {
            if (canSet(player)) {
                if (player.getItemInHand().getType().equals(Material.GREEN_RECORD)) {
                    green = player.getLocation();
                    player.sendMessage(ChatColor.GREEN+"Green Teletab set!");
                } else if (player.getItemInHand().getType().equals(Material.GOLD_RECORD)) {
                    gold = player.getLocation();
                    player.sendMessage(ChatColor.GOLD+"Gold Teletab set!");
                }
                return true;
            } else {
                return true;
            }
        }
        return false;
    }

 

What do you mean with has been executed?
You mean a command from a different plugin? Or a plugin that toggles something?

 

It will workd with other plugins?
I need to check if a command like /god has been executed and then write it on a config file (it's not a problem)

 

@beatcomet What he posted is not what you asked.

You basically want to know if the user has typed /god ?
For that, make a HashMap and store a boolean when the user types /god

 

The CommandPreProcessEvent will work. If it didn't, it means you did it wrong.

 

Use PlayerCommandPreprocessEvent. It's basically executed everytime a player uses a command BEFORE it is handed to onCommand.
So check if the label is god and do whatever you want with it.

 

Can you give me an example?
I don't really know how to check the label of other plugin's commands....

 

Code:java

    @Override
    public void onPlayerCommandPreprocess(PlayerCommandPreprocessEvent event){
        String cmd = event.getMessage();
        Player ply = event.getPlayer();
        ply.sendMessage("You performed the following command: "+cmd);
    }

cmd would now contain the command the player typed.

 

tried it, but it does nothing...
I will check it, mybe I did something wrong ...

Edit:

Here is what I did with your help

Code:java

 
public void onPlayerCommandPreprocess(PlayerCommandPreprocessEvent event){
        String cmd = event.getMessage();
        Player ply = event.getPlayer();
        String name = ply.getName();
        ply.sendMessage("You performed the following command: "+cmd);
        if((Boolean)plugin.config.getProperty(name) == true){
        	plugin.config.setProperty(name, false);
        	plugin.config.save();
        }if((Boolean) plugin.config.getProperty(name) == false){
        	plugin.config.setProperty(name, true);
        	plugin.config.save();
        }
    }
 

I hope it will work ..

 

The sendMessage thingy is of course just for debugging. If it doesn't shows up, you either didn't register your listener or failed to put it in the correct class because of the missing @Override.

And for god's sake, stop using getProperty(...) on the configuration and casting it to the expected value. Just take getBoolean(String root, boolean default), and it will always give you the expected result.
Same for every other data type that you store.


And you should still check if the given cmd is the one you want, because right now it would execute for every single command that the player types ...

 

it's ok, it works.
Here is the main class :

Code:java

 
package me.beatcomet.GM;
 
import java.io.File;
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Event;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.util.config.Configuration;
 
public class GM extends JavaPlugin{
	Logger log = Logger.getLogger("Minecraft");
	public PListener playerListener = new PListener (this);
	File configFile = new File("plugins/" + "GM" + "/log.txt");
	Configuration config = new Configuration(configFile);
	public void onEnable(){
		log.info("GM version 1.0 has been ENABLED!");
		PluginManager pm = this.getServer().getPluginManager();
		pm.registerEvent(Event.Type.PLAYER_JOIN, playerListener, Event.Priority.Normal, this);
		pm.registerEvent(Event.Type.PLAYER_COMMAND_PREPROCESS, playerListener, Event.Priority.Normal, this);
		new File("plugins/" + "GM").mkdir();
		if (!configFile.exists()) {
			try {
				configFile.createNewFile();
 
			} catch (Exception e) {
				// sending console message in case the data file could not be
				// created
				log.info("[GM] Error when creating data file.");
			}
		}
		// Loading data file
		config.load();
	}
 
	public void onDisable(){
		log.info("GM version 1.0 has been DISABLED!");
	}
	public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
		if(sender instanceof Player){
			Player player = (Player) sender;
			if(player.isOp()){
				if(commandLabel.equalsIgnoreCase("stt")){
					if(args.length == 0){
						String name = player.getName();
						boolean pl = (Boolean) config.getProperty(name);
						String construct = null;
						for (Player p : getServer().getOnlinePlayers()) {
							if (pl == true) {
								this.config.setProperty(p.getName()+" status", ": God");
							}
							if (pl == false) {
								this.config.setProperty(p.getName()+" status", ": Not God");
							}
							construct = ChatColor.GOLD + p.getName() + ChatColor.AQUA
									+ this.config.getProperty(p.getName()+ " status")
									+ ChatColor.BLACK + " | ";
						}
						sender.sendMessage(construct);
 
					}
				}
			}return true;
		}
		return false;
	}
}
 

Here is the player Listener :

Code:java

 
package me.beatcomet.GM;
 
import org.bukkit.entity.Player;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerListener;
 
public class PListener extends PlayerListener{
	GM plugin;
	public PListener(GM instance){
		plugin = instance;
	}
	public void onPlayerJoin(PlayerJoinEvent event){
		Player player = event.getPlayer();
		String name = player.getName();
		if(plugin.config.getProperty(name) == null)
		{
			plugin.config.setProperty(name, false);
			plugin.config.save();
		}	
	}
	public void onPlayerCommandPreprocess(PlayerCommandPreprocessEvent event){
        String cmd = event.getMessage();
        Player ply = event.getPlayer();
        String name = ply.getName();
        boolean player = (Boolean)plugin.config.getProperty(name);
        if(cmd.equalsIgnoreCase("/god")){
        	if(player == true){
        	plugin.config.setProperty(name, false);
        	plugin.config.save();
        	}if(player == false){
        	plugin.config.setProperty(name, true);
        	plugin.config.save();
        	}
        }
    }
}
 

People my want to use it as an example