[FUN] Citizens v2.0.11 - Human NPCs for Bukkit [1.7.2]

Discussion in 'Archived: Plugin Releases' started by Citizens, Mar 5, 2011.

  1. Offline

    Citizens

    Citizens - Human NPCs for Bukkit
    Version: 2.0.11
    Authors: @fullwall and @aPunch
    Source: Citizens on GitHub

    Citizens is now on BukkitDev

    This thread will no longer be updated. We encourage you to use our page on BukkitDev. You can find information, links to our wiki and website, and the download page there.

    Showing Your Support

    We work hard to maintain Citizens. We've been working on Citizens2 around the clock on new and exciting features. A little motivation never hurts, so feel free to donate to us - fullwall and aPunch.

    If you can't donate, we appreciate a "hello" every now and then. Stop by the IRC channel #citizens on irc.esper.net to discuss Citizens and give thanks!
     
  2. Sorry if this has already been brought up. My NPCs always turn in their position whenever I restart the server.
     
  3. Offline

    Sharpie-o

    I've got that too....
     
  4. Offline

    Liger_XT5

    Not sure if this was requested or not, but could setting up a max number of NPC Mobs per player be added? There's times the server is pretty inactive and if 1 player is on for a little while, he has more than enough mobs around that it gets annoying.
    They like to bump into you and push you.
     
  5. No matter what I set the trader to sell or buy for, it will always be "1.00 Coins" (My currency is coins). EX: "/trader sell bread 1 5" would make it sell for 1 coin. And "/trader sell bread:1 5" would also make it sell for 1 coin. Same for buying. Also, whenever I restart the server or reload the plugin, it recreates some removed npc's. And some of my friends which is OP on the server, does not even get a reaction from the npc trader.
     
  6. Offline

    Insanehero

    Before I installed 1.0.9b I wiped my old citizens file and replaced it with 1.0.9b. I made about 30ish NPC's with 1.0.9b and then 3 days later all of them are gone. I had done restarts and such during that time so I know thats not the problem. Infact, my npc-profiles and empty :confused:. Someone please help me solve this problem.
     
  7. Offline

    ZNickel

    I experienced something weird a week ago. An npc I created called Little told me "I'm Bored" and sarted flying upwards. Has anyone else experienced this?
     
  8. Offline

    Sygnus

    Can't wait for a fix :D
     
  9. Offline

    gameswereus

    How do you limit NPCs for each group, for permissions? I just can't figure it out.
     
  10. Offline

    Sharpie-o

    Depends on the limitation you want. The Wiki has a really easy way to show you how.
     
  11. Offline

    Draconicus

    I get this too. It happens randomly, possibly from timeouts but in any case the trader container is behaving like a chest.
     
  12. Offline

    sssss465

    Tell what is wrong, then read the FAQ. [creeper]
     
  13. Offline

    masasuka

    looks like it's still bouncing NPC's around a lot, this is an image of a server generated specifically to test this, it was logged in to twice, and up for no more than 5 mins, it was giving lots of errors saying 'server can't keep up' and gave errors when trying to test out that 'quest.yml' file you had in the zip.

    here's a render of what it looked like after being online for 5 mins. (only plugin used was this citizens version)
    [​IMG]
     
  14. Offline

    xxdilbertxx

    I second that!
     
  15. Offline

    jor956

    Will a fix be coming anytime soon? Because this is more trouble than it's worth currently.
     
  16. Offline

    AllenMarx

    When I create an npc, I can put items and armor on them, But they do nothing. None of the commands seem to work exept for /npc item and /npc armor.
    Help?
     
  17. Offline

    dominichello

    @AllenMarx

    Its far safer NOT to use this mod atm, there is a serious Chunk generation error with it. So just wait untill it gets updated.
     
  18. Offline

    Blackswordsman

    This is true, my world went from 80mb to over 300mb when using this plugin. By doing a carto I could see various chunks loaded outside our world border.
     
  19. Offline

    fullwall

    How do these chunks get loaded? Do the npcs tp there or something? This is necessary to help me fix this issue.
     
  20. Offline

    mbsuperstar1

    I did some personal testing... These chunks get loaded without creating any NPC's normally, and the generated chunks have no npc's in them, with evil npc's off.

    Is it possible that creaturetask or one of the evilnpc's causes the generating of loaded chunks before deciding to not spawn?
    I'm nowhere near 100% sure on this.
     
  21. Masasuka's image above should be a goldmine of clues. The generated chunks are in a grid pattern about 48 blocks apart. There must be some code that maybe randomly thinks about making random mobs appear but is calculating the coordinates wrong, or turning coords into chunk-coords and getting that wrong. In fact, the "grid" looks like an exploded view of the mainland, so maybe its simply somehow taking the area it actually wants and multiplying the coords by 3 - which moves it way off map and gens chunks in a 3x3 grid ignoring the middle ones. This looks like whats happening in the image... "what are the 9 chunks around this npc here?" (chunks end up 3x what they should be) (gens 9 chunks which are too far away and spread out)

    Anyway I'm just here because my own server keeps crashing with Java Heap Out Of Memory errors in Citizens, and I only made one new npc whilst waiting on a fix.
     
  22. Offline

    Bhikku

    Same here, 100% CPU usage after 2-3 min Serverrun =>shut down. Tryed without and with NPCs, first i thought its logblock but logblock just detect that the world become too big after some time if i run citizens with it. Hope for fix :p
     
  23. Offline

    fullwall

    OK, thank you, very helpful :). I will look into my gen code.
     
  24. I was gonna say the 3 thing is even a clue, so look for a "for x=1 to 3" loop and see if it could accidentally become "for x=3 to 6" which could cause this exact chunk loading issue.. looking at the code, I see code which loops from 1 to 3 right there in the chunk gen code, so I think I'm onto something.
    Show Spoiler

    public ChunkCache(World world, int x, int y, int z, int offsetX, int offsetZ) {
    this.chunkX = x >> 4;
    this.chunkZ = z >> 4;
    int offsetChunkX = offsetX >> 4;
    int offsetChunkZ = offsetZ >> 4;

    this.chunks = new ChunkSnapshot[offsetChunkX - this.chunkX + 1][offsetChunkZ
    - this.chunkZ + 1];

    for (int newX = this.chunkX; newX <= offsetChunkX; ++newX) {
    for (int newY = this.chunkZ; newY <= offsetChunkZ; ++newY) {
    this.chunks[newX - this.chunkX][newY - this.chunkZ] = world
    .getChunkAt(newX, newY).getChunkSnapshot();
    }
     
  25. Offline

    fullwall

  26. Offline

    fullwall

    @CorumAnime - that code is not used, it was for pathfinding things. The actual problem was in CreatureTask (calling world.getChunkAt actually loads the chunk if not loaded).
     
  27. Offline

    Yuushi

    I really couldn't figure out why my server map was looking so.. uhg. (http://minecraft.qribble.com:8123/) It's set to render chunks as they are generated and I would see them randomly popping up before the server would crash after about 5 minutes each time. Figured out after lots of narrowing down that Citizens was the cause, as it stopped after I removed the plugin.

    Great plugin! Me and my players love it, and were all excited and starting using it to create full NPC towns for people to visit on our new maps. :) Good to hear the bug is being fixed! :)
     
  28. Offline

    Maskur

  29. Offline

    aimbotxx

    Here is the test i've run. I used the dropbox you provided, and Ran my Server for About 5 minutes

    Results:

    [​IMG]
     
  30. Offline

    Sharpie-o

    This is the FIXED fixed version? xD It's still chunking.
    And what do you mean when you say the CreatureTask? Do you mean something that's disabled and it's like stuck or something? can you give more info? xD if it is that, ill switch it on right away.
     
  31. Offline

    Chekkaa

    Citizens, fullwall, aPunch, or whoever cares: This plugin is a mess. Sorry, but it is. I remember back when this plugin had only basic NPCs. And it actually worked. And it didn't totally mess everything up. And it didn't have a huge and confusing config.

    Seriously, is there any way you can go back to that, instead of bloating it with broken features, and not providing any way to disable them? I really miss this plugin, I do, but right now, it's just more trouble than it's worth.

    All I want are basic NPCs that have names, have skins, hold stuff, say stuff when you hit them or get close, look at you when you get close, and cost money to create, just like in the good old days. But it seems right now that I can't have that without also having weird new mobs spawning outside the map, or players attempting to create broken NPCs that haven't been disabled for some reason, or having my server crash randomly.

    I'm not trying to be rude or ungrateful, I'd just like to see you guys organize yourselves a bit more efficiently, and perhaps add a way to disable unneeded/broken features. :)
     
    ThijmenDF and prote1n like this.

Share This Page