Inactive [FUN/MISC] Giant Trees v0.4.3 - Make Massive Trees in Minecraft [1.1-R6]

Giant Trees: Connor Mahaffey
Version: 0.4.3

Downloads:
Jar Standalone
Zip Folder with Config
Note: If you download just the .jar, the config will be created on startup
Source (GitHub)

All new information will be posted on BukkitDev: http://dev.bukkit.org/server-mods/giant-trees/

 

What I mean by that is that when using a command you can start it with /gt, /gtree, or /gianttree - all the examples use /gt but you could use /gtree, etc.

 

ah okay, like /gt help, /gtree help etc..?

 

Your server probably overloaded. Try slowing down the time in the config. Hence why there are limits my friend

Yep or to make a tree, something like /gt 30 6

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

if i make a small tree the same error appears its your turn not my turn

 

Have you tried slowing down the time in the config?

 

its in progress but it takes "some" time

 

Well let me know if that solves your problem. I'll be trying to make some speed improvements in the next update, so that this time can be even slower, but it won't take as long. Sorry for the inconvenience, but since Minecraft is in beta, and really, bukkit too, these things happen.

 

ok if i make it faster server is down in few seconds config set to 10
and if i make it slower it only needs more time before the crash
tested with 10 and 300

edit:
there is no difference between the size from x and y server is down so or so
First tree worked so well

 

i've tried twice now
/gt 50 8

but at about what looks like 2/3 the way through i get

Code:

2011-06-14 11:59:31 [SEVERE] java.lang.NullPointerException
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.World.a(World.java:1544)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.World.a(World.java:1509)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.World.a(World.java:556)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.MetadataChunkBlock.a(SourceFile:103)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.World.doLighting(World.java:1496)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:391)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
2011-06-14 11:59:31 [SEVERE]     at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
2011-06-14 11:59:31 [SEVERE] Unexpected exception
java.lang.NullPointerException
    at net.minecraft.server.World.a(World.java:1544)
    at net.minecraft.server.World.a(World.java:1509)
    at net.minecraft.server.World.a(World.java:556)
    at net.minecraft.server.MetadataChunkBlock.a(SourceFile:103)
    at net.minecraft.server.World.doLighting(World.java:1496)
    at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:391)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

and it crashes the server

if you need more info from me, let me know.

my server version and plugin list is in the link in my sig

 

I was thinking different wood types, like the birch and such, but huge pines would be amazing. Redwoods!

 

My server can definitely handle at least 1 tree growing. I put the delay time down to 30 and it spawned it so much quicker with hardly any lag on the server. Granted, it is a powerful machine and minecraft is just about the only thing running on it. I would put a configurable number of trees that you can grow simultaneously in the config file with a big huge warning over it about possible server crashes, etc.

 

No you're right. Didn't think about a list. That would be huge!

EDIT: Oh one more thing concerning the list. Maybe a command like "/gt add [height] [width]", so every added tree can have it's own properties.

 

could you post the error? Maybe its not the typical doLighting error. Or maybe your server specs are really low?

Good to know. I figured that if I can run it on my dual core 1.9 ghz laptop with Netbeans, the client, and the server running MOST people should be able to turn it down quite a bit. Next update will put longer breaks in-between chunks, as opposed to block by block. This should make it build even faster.

Yes that's definitely coming. The list will be stored on file as well, so that an admin can tell the tree list to stop building after the next tree is completed, the server can be shutdown, and then the trees will start building again when it comes back up.

Oh sorry, to clarify, that's how it works you do all the commands like normal, but if a tree is being built, it adds the new tree to the cache.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

EPIC!!!

 

Code:

2011-06-14 22:30:04 [SEVERE] java.lang.NullPointerException
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.World.a(World.java:1544)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.World.a(World.java:1509)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.World.a(World.java:556)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.MetadataChunkBlock.a(SourceFile:104)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.World.doLighting(World.java:1496)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:391)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
2011-06-14 22:30:04 [SEVERE]    at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
2011-06-14 22:30:04 [SEVERE] Unexpected exception
java.lang.NullPointerException
        at net.minecraft.server.World.a(World.java:1544)
        at net.minecraft.server.World.a(World.java:1509)
        at net.minecraft.server.World.a(World.java:556)
        at net.minecraft.server.MetadataChunkBlock.a(SourceFile:104)
        at net.minecraft.server.World.doLighting(World.java:1496)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:391)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

Ive had a couple server crashes tonight since using this plugin, i was in the process of running a /gt 70 10, other times i get the infamous Read Time Out, this time i got that, although it doesnt specifically point to your plugin, thought i'd share.

 

Well, I haven't gotten any of the errors yet, but the algorithm could definitely use a bit of work:

I usually have to do a tree within a tree for the large ones to look decent. Otherwise it looks like 4 huge columns of leaves on skinny, spotty, branches.

 

It is my plugin, and I do apologize. Have you tried slowing down the time in the config? This error occurs when bukkit gets caught up doing the lighting. I'm thinking about submitting a bug report because it shouldn't take down the entire server.

The next update should improve both build times and possibly help with these lighting issues.

Also, I thought I'd let you know that the /gt undo feature you requested is coming along nicely. A user can only undo the trees they created, unless they have the .undoall permission, and trees can be undone at any time, even after a server restart. Just walk up to the tree in question and type /gt undo

Ouch, is that picture really the final version of the tree? It looks like one that half spawned. Huh. I'll take a look at it. I'll admit I haven't tested too many trees above 30 height. May need more leave reps.

Just out of curiosity, what is the height and width of the tree in your picture?

 

So, I think this is really awesome. Great work!

However, I was looking at your code, and it looks like you're creating your own thread to do block updates. From what I understand, the minecraft server is not thread safe, and doing this could cause errors. This may actually partly be responsible for some of the errors people are getting. You really should use Bukkit's scheduler with a sync task to do block updates.

My suggestion would be to use your own thread to do all the calculations without actually doing anything with blocks. Just create a queue of locations (you wouldn't want to use a queue of blocks, since that would require running getBlockAt, which you wouldn't want to do). Then when that's done, use a sync task to run through the queue, updating blocks several at a time. I obviously haven't tested it, but it seems like it would work better.

Edit: I did some playing around, and I've sent you a PM with my results.

 

thanks connor for makeing this im testing now

 

Love this plugin, my buddies 8 yr old son was thrilled when he logged in and I had made large trees all around is plot for him to play with lol.

 

so back from school and this is the same error i got all the time. Chancing the build speed doesn't help there it the tree takes more time to build it takes only longer before the server send this error

and on the picture is a unfinished tree look into your server

 

I'm curious what your server specs are, because its runs fine on my computer which is definitely slower than most servers.

Regardless, if you are continually having issues, please wait till version 0.2 - I'm trying to improve things.

 

I tried with speed 60,45,35 same results
Core I5 2500k, 16gig ram, 1 gig ethernet connection.. Server is way more than capable of performing these tasks I can do some insane worldedits nearly instant.

 

how to delete a tree?!

 

Look below.

Coming in the next update, until then, ummmm fire

UPDATE:
A fix by @nisovin is coming ASAP and should stop the crashing problems some of you are having (why some and not others I have no idea). I do apologize. If you are having problems I suggest disabling the plugin until version 0.2 is released. Version 0.2 will also add a /undo option.

 

Something else I thought of... this plugin is the only one with a space in the name. Not that it should matter, but for consistency, remove the space like the other plugins

 

Well, just out of curiosity I ran another test with LyTreeHelper disabled. I did get more leaves on 1/2 of the tree, but the other side looked the same. I was standing at 117, 440 and ran /gt 70 16. There were no errors in the console and it did say "Tree Completed!" before I did my final evaluation. Also, here are the specs of my server and all the plugins I had installed at the time I ran this one:
OS: Ubuntu 10.04 64bit
RAM: 3GB dedicated to minecraft out of a max of 6GB
CPU: Core2duo 2.33GHz
Java version: OpenJDK Runtime Environment (IcedTea6 1.9.4) (6b20-1.9.4-0ubuntu1~10.04.1)
OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode)
Bukkit version: 860
Plugins list:
AntiXray
BigBrother
BlastControl
FlowControl
ButtonWarp
ChairCraft
ClayGen
GiantTrees
HeroicDeath
ICoLand
iConomy
LocalShops
LWC
MapClone
McMyAdmin
mcMMO
all of Minecart Mania
Minequery
MonsterBox
MultiVerse
NSCommand
Permissions
Realshop
ShelfSpeak
SimpleCensor
SpongeRestore
ThunderTower
Turnstile
WeatherRestrictions
And a screenshot of the tree I built:

 

Was in the chat a message like Tree Finished or something like that in green ? If not the tree is still in build process

 

Yup, I edited my post to include that just as you were posting that. But yes, I did wait for the green "Tree Completed!"

 

does a forest create lag?