Filled CitizensNoteEffect

Discussion in 'Plugin Requests' started by madtomic, Jun 18, 2018.

Thread Status:
Not open for further replies.
  1. Offline

    madtomic

    Minecraft version: 1.12.2

    Suggested name: CitizensNoteEffect

    What I want: I like to request a simple plugin that would play a note effect over Citizens. Thank you for reading.

    Citizens
    <Edit by Moderator: Redacted not allowed paid resource url>

    config.yml to track all placed note effect.

    Ideas for commands
    :

    /note set (Citizens ID) or left/right click the Citizens to set the effect.

    Ideas for permissions: None

    When I'd like it by: As soon as you can, please!
     
  2. Offline

    Gosintary

    Don't quite understand what you mean by "note effect." Do you mean like a note block sound?
     
  3. Offline

    madtomic

    [​IMG]

    This note effect over the citizens head.
     
  4. Offline

    Gosintary

    I'll check to be sure but I don't think that's possible.
     
  5. Offline

    madtomic

  6. Offline

    Gosintary

    Hm, I just noticed you have developed 9 plugins. Why are you now making requests?
     
  7. Offline

    madtomic

    @Gosintary

    I am merely a tester for all the plugins that I was once involved on bukkit. I would love to develop my own plugins but I only understand the spigot api enough to make requests. I wished I have the time to learn and write my own plugins. :)
     
  8. Offline

    crysis992

    I've done the request.
    Download: Click here
    Requirements: CT-Core and of course Citizens and spigot 1.10.* (or the version that added the new particle api)

    The effect is only displayed on spawned NPCs and if the chunk from the NPC is loaded.
    The NPC check // Chunk check and sending the particle is done in an async task, if there are any problems, please report. But that "should" be threadsafe.

    The plugin will be uploaded in a couple of days to dev.bukkit and/or spigotmc.

    Commands:
    /cne set <NPC ID> - Add the NPC to the effect list
    /cne remove <NPC ID> - Removes an NPC from the effects list
    /cne list - To list all NPCs with effects above
    /cne reload - Reload the configuration.

    All commands require the permission node: cne.admin

    The configuration (config.yml) should be self-explanatory.
     
  9. Offline

    MightyOne

    @crysis992 why would you use an async task to do that?
     
  10. @crysis992 You can run an instant sync task using the scheduler once your async task is elapsed. That way the waiting is done async and the actual processing is done in sync. You won't regret doing it like that.
     
  11. Offline

    crysis992

    There's no need to run it sync? All the methods used should be safe to access from an async task.
     
  12. Offline

    madtomic

    @crysis992

    Thank you for doing this request.

    There is an issue with saving in data.yml

    start sever
    set an npc
    remove the npc just set
    and set the same npc again
    stop server

    check data.yml

    You will find the ids are not remove when it suppose to and it would duplicate when set again.
     
  13. Offline

    crysis992

    Re-Download the plugin from the link above and try it again. That issue should be fixed now.
    NPCs will now be properly be removed when doing /cne remove and are also auto-removed when deleting the NPC via /npc remove.

    (There's no need to re-download the CT-Core API)
     
  14. Offline

    madtomic

    Thank you for fixing it. I have a final request. Is there a way to use more than one note effect? Seems like only one color of Note is being used. I think there are many other colors. Let me know if this would be a performance issue if more than one color of note is used.
     
  15. Offline

    madtomic

    @crysis992

    I figured that I would tag you about my last message. Maybe you didn't get a notification about it.
     
  16. Offline

    crysis992

    It is the same color because that's the default behavior of that particle, I guess. And I have no clue how to change the color of the note particle while keeping the particle effect changeable via the config (at least with low effort).

    I've updated the download link above and the .jar includes now the source files in case anyone wants to add that feature.
     
  17. Offline

    madtomic

    @crysis992

    Thank you again for filling this request.
     
  18. Offline

    madtomic

Thread Status:
Not open for further replies.

Share This Page