Development Assistance SignChangeEvent plz help!

OK. im trying to make a sign plugin.and i researched and i found out that i should use OnSignChange method.
but my problem is its not workin.even most simple things wont work.

Code:

package com.Dara.Sign;

import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.plugin.java.JavaPlugin;


public class Main extends JavaPlugin {
   
    public void OnEnable(){
        System.out.println("enabled");
       
    }
        @EventHandler
    public void onSignChange(SignChangeEvent event){
       
        Player p =event.getPlayer();
            p.sendMessage("yoohoo");
           
           
               
    }
   
   
}

this is just a simple code . i wrote that to check if even my OnSignChange works or not!!!

and it didnt work.
plz help me im a begginer in these stuff.
i already learned VB,c#,C++ and javascript but i just started java .
plz help!

and i forgot to say . i use 1.8.3 bukkit api.is that the problem?

EDIT by Timtower: merged posts

 

Use code/syntax tags to make your code better readable:

Code:

[syntax=java]

Your code

[/syntax]

.
You didn't register the Listener.
Don't print out "enabled". Bukkit already does that for every plugin!

 

how to register listener?

Code:java

 
package com.Dara.Sign;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Main extends JavaPlugin {
 
public void OnEnable(){
System.out.println("enabled");
 
}
@EventHandler
public void onSignChange(SignChangeEvent event){
 
Player p =event.getPlayer();
p.sendMessage("yoohoo");
 
 
 
}
 
 
}
 

implements Listener?
if u mean that i actually tried it before but didnt work

 

you need to implement Listener and register the events.
http://wiki.bukkit.org/Event_API_Reference

 

tnx but the wiki i just showing the code. can u guys explain why i should do this. i mean something about it and what exactly i should do.
tnx for ur help.

 

http://wiki.bukkit.org/Event_API_Reference#Registering_Events
To make events work, you need 4 things:

1. A class which implements Listener
2. Registering the events in onEnable()
3. @EventHandler over the event
4. The event itself

 

tnx dude i did that this is my code but it still wont working . i place a sign but nothing happens.

SignListener class :

Code:java

 
package com.Dara.Sign;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.SignChangeEvent;
 
public class SignListener implements Listener{
 
    @EventHandler
    public void OnSignChange(SignChangeEvent event){
 
        event.getPlayer().sendMessage("You have finaly done it");
 
    }
 
}
 

my main class:

Code:java

 
package com.Dara.Sign;
 
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Main extends JavaPlugin{
 
    public void OnEnable(){
 
        getServer().getPluginManager().registerEvents(new SignListener(), this);
 
    }
 
 
 
}
 

 

lol thats strange. Are there any errors in the console?

 

no there isnt
could there be a problem with my imports or 1.8.3 api?
i mean its a simple code but it wont work

 

SignChangeEvent fires, if you press the Done button after changing the text on the sign...

 

do you mean i should another method?
can u tell what it is.
and tnx for ur fast answering .

 

If you want to detect, if a block(sign) is placed, use the BlockPlaceEvent.
If you want to detect, if sign text is changed, use the SignChangeEvent

 

im going to make a sing XpShop plugin.its a shop but uses xp .which method u guys think i should use?
btw i wrote a code with BlockPlaceEvent but its not working.

listener class:

Code:java

 
package com.Dara.Sign;
 
import org.bukkit.Material;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockPlaceEvent;
 
public class SignListener implements Listener{
 
    @EventHandler
    public void OnBlockPlace(BlockPlaceEvent event){
 
        if (event.getBlockPlaced().getType().equals(Material.TNT)) {
           event.getBlockPlaced().setType(Material.AIR);
        }
 
    }
 
}
 
 

main class:

Code:java

 
package com.Dara.Sign;
 
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Main extends JavaPlugin{
 
    public void OnEnable(){
 
        getServer().getPluginManager().registerEvents(new SignListener(), this);
 
    }
 
 
 
}
 

 

Thats strange. I tested your code and it worked. Do you have a correct plugin.yml?

 

yes i think so.

plugin yml:
name: Sign
main: com.Dara.Sign.Main
version: 1.0


after i export this in plugin folder i run my 1.8.3 server.then i launch 1.8optfine and join the server.after i place a tnt i expect to it change to air(nothing) but like always it not works.it just stay like that.can be problem because of the version i play with?can this be because im oped in server?

 

Dara try doing this

Code:

@EventHandler
public void onSignChangeEvent(SignChangeEvent event) {
Player player = event.getPlayer();
if(event.getLine(0).contains("Hello")) {
player.sendMessage(ChatColor.GREEN + "You did it!");
}

 

it wont work.

 

@Dara007
In your onEnable method, put the following line of code to register events:

Code:

getServer().getPluginManager().registerEvents(this, this);

The final onEnable method in your case should be:

Code:

@Override
public void onEnable(){
    getServer().getPluginManager().registerEvents(this, this);
}

And also, something else you'll definitely need:

Code:

public class Main extends JavaPlugin implements Listener{

As a whole, your entire main class should look like this:

Code:

package com.Dara.Sign;

import org.bukkit.plugin.java.JavaPlugin;

public class Main extends JavaPlugin implements Listener{

    @Override
    public void OnEnable(){
        getServer().getPluginManager().registerEvents(this, this);
    }
}

Try and mess around with the Bukkit API. If you can't register events, you should read up in the JavaDocs:
hub.spigotmc.org/javadocs/bukkit
Or you can also read up on.. well... at this rate... all of the wiki page on Bukkit Documentation. Don't get me wrong, I'm still new too, but this is pretty basic stuff.

 

I have found why its not working. You wrote the method like this:
OnEnable
it should start with a lowercased o:
onEnable

 

thank u very much . i cant believe but its actually workin.thank u very much.Luv Ya

 

I was making a xpshop as i said so this is my listener codebut i have a problem.if i click air or other things and stuff there will be an error in comsole.why?

listener:

Code:java

 
package com.Dara.Sign;
 
 
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.block.Sign;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
 
 
public class SignListener implements Listener{
 
    @EventHandler
    public void OnSignChange(SignChangeEvent event){
 
        if(event.getLine(0).equalsIgnoreCase("[SCWSHOP]")){
            if(event.getPlayer().hasPermission("scw.creatsign")){
            event.setLine(0,"§2[§6SCW§4SHOP§2]");
            }
 
        }
 
    return ;
 
}
         @EventHandler
         public void OnPlayerInteract(PlayerInteractEvent e){
           Action action=e.getAction();
          Block block=e.getClickedBlock();
          if(block.getType().equals(Material.SIGN_POST ) || block.getType().equals(Material.WALL_SIGN ) ){
            if(action==Action.RIGHT_CLICK_BLOCK){
                Sign sign=(Sign) block.getState();
                if(sign.getLine(0).equalsIgnoreCase("§2[§6SCW§4SHOP§2]")){
                    if(sign.getLine(1).equals("")){
                          e.getPlayer().sendMessage("§6Please Enter Enchantment Level");
                        }
                         int lvl = Integer.parseInt(sign.getLine(1));
                            if(sign.getLine(2).equalsIgnoreCase("")){   
                              e.getPlayer().sendMessage("§6lease Enter Enchantment ID");
 
                              }
                                Enchantment id = Enchantment.getByName(sign.getLine(2));
                             if(sign.getLine(3).equals("")){
                                e.getPlayer().sendMessage("§6Please Enter Xp Price(Level)");
                                }
                                int xp = Integer.parseInt(sign.getLine(3));
                                int playerxp= e.getPlayer().getLevel();
                                if(playerxp==xp || playerxp>xp){
                                  int newxp= playerxp-xp;
                                  e.getPlayer().setLevel(newxp);
                                  e.getPlayer().getInventory().getItemInHand().addEnchantment(id,lvl);
 
                                  }
                                  else{
                                  e.getPlayer().sendMessage("§6You Dont Have Enough Experience");
                                    }
                                  }
                              }
                             }
                           return ;
                         }
}
 
 

the error is"could not pass PlayerInteractEvent to Sign v1.0"
my plugin name is sign and version is 1.0 but what is wrong with player interact event . imean everything is working fine except this error.

 

@Dara007 You put

Code:

            if(action==Action.RIGHT_CLICK_BLOCK){

which is right, but I don't see an else. What happens if it ISN'T a right click event.

Put this as an else for the if statement above:

Code:

else{
    return;
}

That should fix it

 

It seems like you have no idea what youre doing
return; cancels a method, not an event.
If it ISN'T a right click, then nothing happens because he only checks IF it is a right click

 

Aha it was only a guess, @FisheyLP xD Worth a shot I suppose, amirite?