Solved EntityDamageByEntityEvent not called

This is the code:

Code:java

    public void onAttack(EntityDamageByEntityEvent event){
        Entity victim = event.getEntity();
        Entity e = event.getDamager();
        if(e instanceof Player){
            Player p = (Player) e;
            if(plugin.skill.getInt(p.getName()) == 3){
                p.sendMessage("You're a wizard harry.");
                if(hasStaff(p)){
                    double truedamage = Math.floor(1 + plugin.config.getInt(p.getName()) / 3);
                    double heal = Math.floor(plugin.config.getInt(p.getName()) / 5);
                    double currhealth = p.getHealth();
 
                    double victimhp = ((LivingEntity) victim).getHealth();
                    ((LivingEntity) victim).setHealth(victimhp - truedamage);   
                    if(currhealth + heal < 21){
                    p.setHealth(currhealth + heal);
                    p.sendMessage(ChatColor.BLUE + "Healed for " + heal + " health");
                    }else{
                        p.setHealth(20.0);
                        p.sendMessage(ChatColor.BLUE + "Healed for " + heal + " health");
                    }
 
                }else {
                    p.sendMessage("You should get a staff");
                }
            }
        }
    }

The messages, "you're a wizard harry" and "You should get a staff" do not display. I'm assuming the code isn't even called at all. But I can't find out why.

 

Did you put @EventHandler above the event? Did you registered in the main?

 

Hex_27 as JordyPwner said, make sure to register it in the main class (which extends JavaPlugin) and add the @EventHandler annotation.
Also, make sure you cast safely, as victim is not recognized as a LivingEntity as it may be an Item, EnderCrystal, a vehicle (minecart/boat), or a HangingEntity (item frame/painting).

 

Make sure you are also implementing listener

 

@FabeGabeMC
was just removing the casts temporarily so see if there was even an error...
This is my new (whole) code.

Code:java

package me.leothepro555.random;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.LivingEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
 
public class Mage implements Listener {
 
    public Main plugin;
 
    public Mage(Main plugin) {
        this.plugin = plugin;
    }
 
    public boolean hasStaff(Player p){
        Material item = p.getItemInHand().getType();
        if(item != null){
        if(item == Material.WOOD_HOE){
            return true;
        }else if(item == Material.STONE_HOE){
            return true;
        }else if(item == Material.IRON_HOE){
            return true;
        }else if(item == Material.GOLD_HOE){
            return true;
        }else if(item == Material.DIAMOND_HOE){
            return true;
        }else {
            return false;
        }
    }
        return false;
 
    }
    @EventHandler
    public void onAttack(EntityDamageByEntityEvent event){
        Entity victim = event.getEntity();
        Entity e = event.getDamager();
        if(e instanceof Player){
            Player p = (Player) e;
            if(plugin.skill.getInt(p.getName()) == 3){
                if(hasStaff(p)){
                    double truedamage = Math.floor(1 + plugin.config.getInt(p.getName()) / 3);
                    double heal = Math.floor(plugin.config.getInt(p.getName()) / 5);
                    double currhealth = p.getHealth();
 
                    double victimhp = ((LivingEntity) victim).getHealth();
                    if(victim instanceof LivingEntity){
                    ((LivingEntity) victim).setHealth(victimhp - truedamage);   
                    if(currhealth + heal < 21){
                    p.setHealth(currhealth + heal);
                    p.sendMessage(ChatColor.BLUE + "Healed for " + heal + " health");
                    }else{
                        p.setHealth(20.0);
                        p.sendMessage(ChatColor.BLUE + "Healed for " + heal + " health");
                    }
                }
                }else {
                }
            }
        }
    }
 
}
 

My console says theres an error at line 54.... but I did check if victim was a living entity. What error is it?

 

Instead of doing (LivingEntity) victim, you should do
if(event.getEntity() instanceof LivingEntity){
LivingEntity victim = event.getEntity();
victim.setHealth(victim.getHealth() - truedamage);

 

You do not register the events.. Please add the following code.

Code:

getServer().getPluginManager().registerEvents(this, this);

Add that to your onEnable() method.

 

This isn't the main class. I already added that to the main

 

You have to register events in all used classes

 

tommyhoogstra

No. You register it once per instance.

 

In any instance in which you intend on using events.

Hex_27
In your Mage classes constructor, add
Bukkit.getPluginManager().registerEvents(this, plugin (Your main class with the onEnable in it));

 

tommyhoogstra

He already said he registered this class in the class that extends JavaPlugin, what in the world are you on about?

 

Nobody has seen his class that extends javaplugin, so for all I know, he hasnt registered the listener for the mage class there. So he should do so in the constructor

Take this class for example

Code:java

public class Main extends JavaPlugin{
    private static Main instance;
    @Override
    public void onEnable(){
        instance = this;
 
        ConfigManager.save();
        ConfigManager.check("MineResetInterval", 1);
        new TreeRegen();
        new MineManager();
        MineCreation mc = new MineCreation();
        getCommand("setup").setExecutor(mc);
        getCommand("CreateMine").setExecutor(mc);
        initializeMines(classes);
    }}

This is the main class for a plugin I am currently working on, but it has no listeners.
So if we goto a class such as TreeRegen,

Code:java

public class TreeRegen implements Listener{
    public TreeRegen(){
        Bukkit.getPluginManager().registerEvents(this, Main.getInstance());
    }

I don't know about you, but this is the way I have always done it.

 

tommyhoogstra Thats wrong. You should be registering all Listener classes via the onEnable in the main class.

Code:java

public void onEnable()
{
          getServer().getPluginManager().registerEvents(new YourRandomListener(), this);
}

 

acer5999 tommyhoogstra

Honestly guys, it's completely and utterly irrelevant where you do it, as long as you do it exactly once when the plugin is loaded.

 

mythbusterma
On enable is the best place to do it just saying...

 

Not for one plugin I was making. I registered the listeners if they weren't already by using a command and when I was done listening for the certain events, I just unregistered them. Thought I would try that route instead of relying on booleans to either skip the event or not. Either way, most plugins want to listen for events ASAP so registering them when the plugin enables is the way to go of coarse.

 

It honestly doesn't make a difference.
Thats just the way I do it

 

The plugin works already... I just forgot to set it to solved..... turns out im just too dumb to realise I forgot @EventHandler