Solved Player location changes help!

Hi, I have been pondering over this for a few hours now, I am looking for a way to get the players location, then (Given time later) check if it is the same or not. Essentially this will be used to check if the player has moved.

It also cannot use PlayerMoveEvent because i am allowing people to move their heads etc. But not themselves.

Any help is greatly appreciated.

 

Player#getLocation, at some point. Then, later, check if Player#getLocation is the same?

Code:java

public boolean isInSameLocation(Location oldLoc, Location curLoc) {
    return oldLoc.getX() == curLoc.getX()
            && oldLoc.getY() == curLoc.getY()
            && oldLoc.getZ() == curLoc.getZ();
}

 

fierchecer

As FerusGrim said.. To compare you can use getLocation().distance(otherlocation) which returns a double. If they haven't moved it will be 0.0

 

Ha. I forgot that Location#distance existed.

 

FerusGrim

I've seen people comparing X to X, Y to Y and Z to Z too often

 

Yes, Umm, Okay I think my explanation to this was slightly lacking, I have a particle plugin that for various different effects that will spawn the particles in a circle around the player, I am attempting to (while the player is standing still (no co ordinate change)) spawn one type of particle and then when a player is moving spawn and play a different particle. FerusGrim Watto

If need be I can re-direct you to where I have seen this.

 

If you need to check if the player is moving, then you should really use PlayerMoveEvent...

 

But is it not possible to use a runnable to every tick: get the players location and then for the next tick get the location and compare it to the location from tick 1?

 

It's... possible, ye.

So is stabbing yourself in the leg.

Just use PlayerMoveEvent. Trust me.

 

fierchecer

Yeah it is.. If you only need the previous block location you could store the last location in a HashMap called something like 'lastBlockLocation' and then compare it to the current block.

Although i'm not sure if that's the most efficient way.

 

I guess something like this could be used?

Code:java

Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
              public void run() {
                      for(Player player : Bukkit.getOnlinePlayers()){
                          Location Current = player.getLocation();
                          if(player.getLocation() != Current){
                              //Player is moving / has moved
                          }else{
                              //Player is in the same spot
 
                              //Could use a Hashmap / Array to store players who are moving for example.
                          }
                      }
 
              }
            }, 1, 1);

I can see that it is possible because in this video I am able to move my head (etc.) and the particles still stay the same, but when I actually move the particle will change to a different one.

 

FerusGrim Watto use distanceSquared, saves you a sqrt (which is expensive to compute).

 

fierchecer

Hm.. noo. It looks to me like you're comparing two of the same Locations to eachother which means that if statement will always be true, tell me if i'm wrong on that one..

I'm assuming you don't want to use PlayerMoveEvent because you also need to run code when they aren't moving too.

Code:java

HashMap<UUID, Location> lastBlockLocation = new HashMap<UUID, Location>(); 
Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
    public void run() {
    for(Player player : Bukkit.getOnlinePlayers()){
 
    Location Current = player.getLocation();
    Location Last = lastBlockLocation.get(player.getUniqueID()); 
 
    if(Last != Current){
    //Player is moving / has moved
    }else{
    //Player is in the same spot
 
    //Could use a Hashmap / Array to store players who are moving for example.
    }
    }
 
    }
    }, 1, 1);

Something like that should work (Wrote through the browser so might be some errors, using your previous example code) however you'll have to find the appropriate place to use 'lastBlockLocation.put' and actually store the last block location which is the easiest part.

fireblast709
Oh and thank you :3

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@Watto
So the 'lastBlockLocation.put' needs to go where the location is updated, I'm guessing, I have never really used hashmaps so i am slightly confused.

By no means do I want you to do it for me, I will never learn that way

 

fierchecer

The HashMap needs to be updated every tick, and just make sure to call it after the 'Last' variable or you'll assign your current position to the HashMap which would result in problems obviously.

It will be easier to understand what to do if you know how a HashMap works.

 

Watto
Got it working
I just wanna say thanks, you really figured it out all on your own, and just told me to add 1 extra line of code, It now works perfectly.

So once again, thank you soo much

 

Glad i could help, remember to mark this as solved too :3