Tell me what i am doing wrong

So i what a command when i do /duty it gives me and then if i do /duty again it removes item from the plugin tell me what i am dong wrong here is the code
I am just pasteing the command not the public boolean onCommand stuff

Code:java

 } else if (cmd.getName().equalsIgnoreCase("duty")) {
 
//message
Bukkit.broadcastMessage(prefix + ChatColor.RED + sender.getName() + " Now on Duty");
//ItemStack
ItemStack iron_sword = new ItemStack(Material.IRON_SWORD, 1);
ItemStack chain_helmet = new ItemStack(Material.CHAINMAIL_HELMET, 1);
ItemStack chain_chestplate = new ItemStack(Material.CHAINMAIL_CHESTPLATE, 1);
ItemStack chain_legs = new ItemStack(Material.CHAINMAIL_LEGGINGS, 1);
ItemStack chain_boots = new ItemStack(Material.CHAINMAIL_BOOTS, 1);
ItemStack steak = new ItemStack(Material.COOKED_BEEF, 64);
ItemStack golden_apple = new ItemStack(Material.GOLDEN_APPLE, 5);
//Enchantment
iron_sword.addEnchantment(Enchantment.DAMAGE_ALL, 4);
iron_sword.addEnchantment(Enchantment.FIRE_ASPECT, 2);
//chain_helmet
chain_helmet.addEnchantment(Enchantment.PROTECTION_ENVIRONMENTAL, 3);
//chain_chestplate
chain_chestplate.addEnchantment(Enchantment.PROTECTION_ENVIRONMENTAL, 3);
//chain_legs
chain_legs.addEnchantment(Enchantment.PROTECTION_ENVIRONMENTAL, 3);
//chain_boots
chain_boots.addEnchantment(Enchantment.PROTECTION_ENVIRONMENTAL, 3);
//ItemeMeta
ItemMeta iron_sowrdmeta = iron_sword.getItemMeta();
ItemMeta chain_helmetmeta = chain_chestplate.getItemMeta();
ItemMeta chain_chestplatemeta = chain_chestplate.getItemMeta();
ItemMeta chain_legsmeta = chain_legs.getItemMeta();
ItemMeta chain_bootsmeta = chain_boots.getItemMeta();
//display
iron_sowrdmeta.setDisplayName(ChatColor.GOLD + "Guard Sword");
chain_helmetmeta.setDisplayName(ChatColor.GOLD + "Guard Helmet");
chain_chestplatemeta.setDisplayName(ChatColor.GOLD + "Guard Chestplate");
chain_legsmeta.setDisplayName(ChatColor.GOLD + "Guard Legs");
chain_bootsmeta.setDisplayName(ChatColor.GOLD + "Guard Boots");
//ArrayList
ArrayList<String> iron_sword1 = new ArrayList<String>();
ArrayList<String> chain_helmet1 = new ArrayList<String>();
ArrayList<String> chain_chestplate1 = new ArrayList<String>();
ArrayList<String> chain_legs1 = new ArrayList<String>();
ArrayList<String> chain_boots1 = new ArrayList<String>();
//Lore Message
iron_sword1.add(ChatColor.GOLD + "Guard Sword");
chain_helmet1.add(ChatColor.GOLD + "Guard Helmet");
chain_chestplate1.add(ChatColor.GOLD + "Guard Chestplate");
chain_legs1.add(ChatColor.GOLD + "Guard Legs");
chain_boots1.add(ChatColor.GOLD + "Guard Boots");
//SetLore
iron_sowrdmeta.setLore(iron_sword1);
chain_helmetmeta.setLore(chain_helmet1);
chain_chestplatemeta.setLore(chain_chestplate1);
chain_legsmeta.setLore(chain_legs1);
chain_bootsmeta.setLore(chain_boots1);
//set Itememta
iron_sword.setItemMeta(iron_sowrdmeta);
chain_helmet.setItemMeta(chain_helmetmeta);
chain_legs.setItemMeta(chain_legsmeta);
chain_boots.setItemMeta(chain_bootsmeta);
//pi
pi.addItem(iron_sword);
pi.addItem(chain_helmet);
pi.addItem(chain_chestplate);
pi.addItem(chain_legs);
pi.addItem(chain_boots);
pi.addItem(steak);
pi.addItem(golden_apple);
}
else
{
player.getInventory().clear();
sender.getServer().broadcastMessage(this.prefix + getName() + " now off duty.");
player.getInventory().setHelmet(null);
player.getInventory().setChestplate(null);
player.getInventory().setLeggings(null);
player.getInventory().setBoots(null);
return true;

 

Learn how to use if statements.

 

Anyone else ?

 

I'll give you the logic and you give me the code. When someone types /duty, check if they already have the stuff. If they do, take it away. If they don't (else), give it to them.

 

Really, learn how to use your else statements correctly.
Since you didn't put your full class, I can only infer that

Code:java

} else if (cmd.getName().equalsIgnoreCase("duty")) {

was an else if from a cmd.getName().
But do you notice what you've put under it?
Without your code, this is what I see.

Code:

} else if (cmd.getName().equalsIgnoreCase("duty")) {
// Code
}else{
return true;

So if the command doesn't equal duty, they're off duty? What?... That's a lot of commands... Don't think that what you wanted to do.