Solved Killing mobs with a custom name (help)

tommyhoogstra bukkit API is Java. You can't learn bukkit API but not know Java. Its like saying you know how to write in English, but not understand any word in English.

 

And you can't make bukkit plugins without knowing the bukkit API, I know enough Java to make plugins, and me throwing lines of code at him is a win for me, as I'm learning more about the API at the same time. Any who, we can stop arguing now, its not helping anyone.


Edit: Thread solved.

 

tommyhoogstra maybe a win for you, but an issue for him, as you practically just confused him.
If you wish to learn Java and bukkit API, dont do so by harming others.

 

tommyhoogstra I'm not getting the message that I put before the if statement.

Updated code:

Code:java

        @EventHandler
        public void onDespawnDonkey(PlayerInteractEvent e) {
            Player player = e.getPlayer();
            Action a = e.getAction();
            if (a.equals(Action.RIGHT_CLICK_AIR)){
 
                Location loc = player.getLocation();
                Material m = player.getItemInHand().getType();
                if (m == Material.SADDLE) {
                    player.playSound(loc, Sound.HORSE_SADDLE, 1, 0);
                    player.sendMessage(ChatColor.BLUE + "Mounts>" + ChatColor.GRAY + " Despawning Your Mount Donkey...");
                    for (LivingEntity ent : e.getPlayer().getWorld().getLivingEntities()) {
                        player.sendMessage("Testing...");
                        if(!(ent instanceof Horse)) return;
                        if(ent.getCustomName().contains(player.getName() + "'s" + " Mount Donkey")) {
                        ent.setHealth(0D);
                        }
                        }
 
                }
            }
        }

Necrodoom Please don't start an argument on my thread!

 

123ang
1) You are storing Action & Material, why?
2) You are never checking if the entity does not have a name which will end up giving you an NPE.
3) ent.setHealth(0);? Why not just ent.remove();

 

DevRosemberg ent.remove(); doesn't work either. I am also storing action & material because I want it to delete the donkey by right clicking the saddle

 

No need to check if it has a custom name, just check if the owner of the tamed animal is the player

 

tommyhoogstra Helped me solve this !

Here is the code he told me:

Code:java

  @EventHandler
        public void onDespawnDonkey(PlayerInteractEvent e) {
        Player player = e.getPlayer();
        Action a = e.getAction();
        if (a.equals(Action.RIGHT_CLICK_AIR)){
 
        Location loc = player.getLocation();
        Material m = player.getItemInHand().getType();
        if (m == Material.SADDLE) {
        player.playSound(loc, Sound.HORSE_SADDLE, 1, 0);
        player.sendMessage(ChatColor.BLUE + "Mounts>" + ChatColor.GRAY + " Despawning Your Mount");
 
        for (LivingEntity ent : e.getPlayer().getWorld().getLivingEntities()) {
        if(ent instanceof Tameable){ // Checks if its a tameable entity, in this case it is.
        if(((Tameable) ent).isTamed()){ // Checks if the animal has been tamed, otherwise itl skip the rest of the code.
 
 
        if(((Tameable) ent).getOwner().equals(player)){ // Checks if the owner of the animal is the person right clicking with the saddle
 
        ent.remove();
        }
        }
        }
        }
        }
        }
        }

 

tommyhoogstra you are still feeding him code though PM, aren't you?

 

I sent him 3 commented lines of code.
Get over it.

 

tommyhoogstra you just cant let him actually learn Java first, don't you? You have to act selfish and give him junk code just so you somehow understand bukkit API better even though you help no one like this.

 

If you're so good yourself Necrodoom why don't you teach him.
So far, you haven't even made an effort in this thread, shows me your all talk and nothing but an attention seeker.

He provided code, he wanted to know how to fix it, so I did.

 

tommyhoogstra you haven't gave anyone a chance because you kept feeding him code.
You didn't tell him how to fix it, you told him "here is the fix, copy-paste it". There's a vast amount of difference, being that it doesn't help anyone.

The plugin development forums are here to help you LEARN how to code plugins, not for coding plugins for you. Please read http://www.javaprogrammingforums.com/content/45-problem-spoon-feeding.html for why spoon feeding is bad.

In conclusion, stop thinking you know how to help if you don't actually know the subject. All you are doing is telling people that copy-pasting someone else's code is the solution, when it isn't.

In this current point, your spoonfed code may appear to do what you thought it should do, but fact is, it doesn't. It takes every single tameable mob, including wolves and cats, and removes them too, even if they don't have a custom name. You just made this thread into a scrapyard of confusion and showed everyone why exactly spoonfeeding is so bad.

 

Whether the spoonfed guy wants to hurt himself by accepting spoonfed code without trying to understand it is up to him. Anybody can spoonfeed code even if it works and is relevant or not. Try figuring this code out: http://pastebin.com/V2YUYbZD.
What if I told you that the code shown was needed to take control and change a players location? A guy who actually looked up on how the code worked would eventually find out that the posted code has nothing to do with Bukkit. xD. In fact, if I ever spoonfeed code to anybody, I might just hide

Code:java

Bukkit.shutdown();

in it. Just to make a point that spoonfeeding isn't worth taking in.

 

You're quoting things I haven't even said, and besides, if you actually read the front page you would understand 90% of it is his own code. He hasn't asked me to write his entire plugin, because he wants to do it himself, even by putting the pieces together helps to develop his logic. I practically transitioned straight from C to bukkit, because java is C based.

I am proud of what I've done here, because if you haven't noticed, the plugin request section only produces plugins for about 10% of the plugins requested. So at the same time as me "spoon feeding" him 3 explained lines of code, which can be adjusted using an instanceof snippet i previously provided, potentially creates another developer, which is something we should all want in the bukkit community.

You say

, but what is this supported by, who HAS learnt java? It is an evolving language with thousands of new possibilities.

 

tommyhoogstra except, he just copy-pastes your code, he hasn't learnt anything, and he couldn't learn anything from copying lines that don't actually do what he wants, because he doesn't understand variable types.

You haven't creates another developer, you created a person who expects the solution to problems always comes from spoon feeding, which means, he won't actually be able to solve the problem himself and adjust it, if he doesn't actually learn Java.

And you perfectly know that when I say learn Java, I mean learn its syntax and how to work with Java logic. You, for some reason, thing that this is unneeded, and think all that is needed is knowing an API that uses Java is all that is needed. This is false, and simply teaches people to copy-paste code. Ive seen this a lot, and you aren't helping anyone. You are just creating problems for the future.

 

Necrodoom I never said all you need to know is the API, of course you need to understand basic syntax and logic in order to apply it. I said I was helping him, as I was interested in how to work with Tameable mobs as well.

Lets just stop the arguing here, if you want to be crowned victor, fine.
If he wants to be spoon fed, its his mistake for taking it in.

 

Oh god no.
So now you blame the user for your unhelping?

 

Necrodoom No, I'm saying we can stop arguing now because this issue has been resolved.
Ok yes, I spoon fed him code, welcome to the bukkit development section. Now people in the future who
google how to kill all of a players tamed mobs will have a result lying at there feet.

 

tommyhoogstra You say that like it's a good thing.

 

The amount of times ive googled things to solve a problem, 98% of the time there is a result there for me to look at, as a large snippet as well

 

tommyhoogstra and learn nothing in the process, i presume.
What happened to actually learning logic of programming languages?

 

I've learnt plenty, who are you to judge?

 

Locked. This is the plugin development subforum not the plugin copy/paste forum or the drama forum.