Solved Cant get this to work(playerInteract event)

Hey, iv been testing this code forever but i cant seem to get it to work. Everything seems just fine but this is what i get.
(When a player interacts with a sand block, it should send them a message)



Here is my code.
(Main class)

Code:

package me.xXRobbie21Xx.TcEssentials;
 
import org.bukkit.Bukkit;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class TcEssentials extends JavaPlugin {
   
 
    @Override
    public void onEnable() {
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(new PlayerListener(), this);
   
 
       
    }
   
    @Override
    public void onDisable() {
       
    }
}

Here is my player listener class.

Code:

package me.xXRobbie21Xx.TcEssentials;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class PlayerListener implements Listener {
 
 
    @EventHandler
    public void onPlayerInteractEvent(PlayerInteractEvent event) {
        Player p = event.getPlayer();
        if (p.getItemInHand().getItemMeta().getDisplayName().startsWith("Sand"))
            p.sendMessage("Hey");
    }
}

I made this as simple as possible for testing reasons.

 

Sorry about that, here it looks a bit clearer

 

I can't even read the error... I even squinted my eyes.

I'm guessing it's because you are not checking if them item has meta but your code
presumes it does. Just add a check if it has an item meta.

Also, you should do p.getItemInHand().getItemMeta().getDisplayName().equals("Sand") - I hope that it's a custom item that you named.

If it's Normal sand you should do p.getItemInHand().getItemStack() == Material.SAND;

 

Konkz Allrighty, thanks for the advice, it means alot. I posted a clearer error message if you want to take a look btw.

Edit: It says that there is something wrong with line 13 on the listener class. This is confusing me because i personally dont see something wrong. By any chance do you see the problem?

Line 13 is Player p = event.getPlayer();

 

I believe the code is throwing a NullPointerException because you are assuming that the ItemStack has an ItemMeta and a display name. To solve this problem simply add two more if statements checking whether the ItemStack has an ItemMeta or a display name.

ItemMeta check:

Code:java

if(p.getItemInHand().hasItemMeta())
{
// Your Code
}

Display Name check (after item meta check):

Code:java

if(p.getItemInHand().getItemMeta().hasDisplayName())
{
// Your Code
}

 

aninsanellama ok thank you so much for the advice, however it seems like line 13 (Player p = event.getPlayer(); ) is giving me some trouble. Its really strange, did i do something wrong with that?

 

I can't see a reason that would be causing an error. Did you try the other solutions that were given?

 

aninsanellama yeah absolutely, thats why im so stuck on this. Thanks for your time btw.

 

xXRobbie21Xx Line 13 in your PlayerListener.

 

Xyplo
The error refers to line 13 of the class "PlayerListenerHandler" not his main class..

 

TGRHavoc Xyplo line 13 in my player listener (not main class) is Player p = event.getPlayer(); and i have no clue why that is giving me problems. If you see the problem please let me know, it would be extremely appreciated.

 

xXRobbie21Xx
Is it throwing an error in the console?

 

TGRHavoc yeah here it is

for the whole error i posted an image above.

 

xXRobbie21Xx
Above where you declared the player, put:

Code:java

Bukkit.broadcastMessage(event.getPlayer().getName() + " has triggered the event");

and see if the message gets broadcasted.. It seems that the player is null for some reason...

 

TGRHavoc hmm, that is extremely wierd, i carefully took everyones advice and changed a fiew things and somehow i got it to work correctly. Thanks for your time, its people like you that inspire people to do things like this.
Appreciate it.

 

xXRobbie21Xx
How did you get it to work?
And thanks, I appreciate it

 

TGRHavoc i changed it back to the first code i had (where it checked for the meta data) and then i changed the name of the block it will check for, and it worked!

 

xXRobbie21Xx
Nice! Don't forget to mark this thread as "Solved"

 

It was his code to begin with... Line 13 was HIS code...