Running Cooldown Help

Drkmaster83
I implemented that into my code like this:

Code:java

package me.maxben34.runner;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class runner extends JavaPlugin implements Listener{
    //jackson runner array... if player is in runner array then...
 
    public void onEnable(){
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
//this part is supposed to see if a player is running and lower their saturation every second
    @EventHandler
    public void onPlayerMove(final PlayerMoveEvent e){
    Bukkit.getScheduler().runTaskTimer(this, new Runnable(){
      @Override
      public void run(){
          int i = 0;
          Player player = (Player) e.getPlayer();
          if(i >= 3){
          player.setFoodLevel(player.getFoodLevel() + 1);
        }
        if(player.isSprinting()){
          i = 0;
          player.setFoodLevel(player.getFoodLevel() - 1);
        }
        else if(!(player.isSprinting())){
          i++;
        }
      }
    }, 0L, 20L);
}
}
 

When I go into survival now, it sets my hunger automatically at 0 and never regens

PogoStick29

No. But it only takes hunger away until there is 16 hungerlevel then it stops taking it and doesn't refill the hunger either. Hopefully that is kinda helpful

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Because every time you run it (every second), it sets i to 0 and 0 is not greater than or equal to 3, so it exits out. There's a reason I put the "i" outside the timer. You need to have a number for each player specifically, so you might have to do some HashMap work.

You're scheduling a running task every time a player moves. Within seconds of moving, you may have maybe 20 timers running at once. Not good. Run that from start up (onEnable()), and do some HashMap work.

 

Drkmaster83

That's true. I'm wondering if there's another way of going about this, I'm trying not to use hash maps, as I have like 20 already within the plugin and it's getting confusing.

PogoStick29

Okay

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Once again true. I think this is similar to making an xp timer... I might b able to use a for loop with Bukkit.getonlineplayers or something like that and set a variable that works with it. Then BukkitRunnable for scheduling?

 

Code:java

public class GameplayListener {
  private final Plugin plugin;
 
  public GameplayListener(Plugin plugin) {
    this.plugin = plugin;
    Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, new BukkitRunnable() {
      @Override
      public void run() {
        for(Player player : Bukkit.getOnlinePlayers()) {
          if(!player.isSprinting()) {
            if(player.getFoodLevel() != 20) {
              player.setFoodLevel(player.getFoodLevel() + 1);
            }
          }
        }
      }
    }, 0L, 20L);
  }
 
  @EventHandler(priority = EventPriority.HIGH, ignoreCancelled = true)
  public void onPlayerMovement(PlayerMoveEvent event) {
    final Player player = (Player) event.getPlayer();
    if(player.isSprinting()) {
      Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new BukkitRunnable() {
        @Override
        public void run() {
          if(player.getFoodLevel() != 0) {
            player.setFoodLevel(player.getFoodLevel() - 1);
          }
        }
      }, 20L);
    }
  }
 
}

This should create a basic run cooldown. Although I would of course recommend changing it to suit your needs more so. This should help provide a working example, albeit this is very different from other ways of doing it. Since this is movement based it's simple to just check if someone is sprinting; if you were to instead do skill cooldowns or command cooldowns you could do something involving collection(s). If you would like an example of that please let me know.

Also, if you have any questions at all about the code above please don't hesitate to ask/question. This was written quickly, as well as not tested. I can comment and explain all reasoning if needed.

Make sure to tag me if you would like me to see, comment, or reply to a post.

Resources (Bukkit Related)
Scheduler Programming
Event API Reference
Bukkit JavaDocs/Doxygen

 

Wingzzz
I have some code here that seems to be a good option on how to do this

Code:java

 @EventHandler
public void onPlayerMove(final PlayerMoveEvent e){
new BukkitRunnable()
{
int timer = 360;
public void run()
{
if((e.getPlayer().isSprinting())){
for (Player p : Bukkit.getOnlinePlayers()){
p.setFoodLevel(p.getFoodLevel() - 1); // increase all levels by 1
}
timer--;
}
 
if (timer >= 0 && !e.getPlayer().isSprinting()){
for(Player p : Bukkit.getOnlinePlayers()){
p.setFoodLevel(p.getFoodLevel() + 1);
 
}
timer --;
}
}
public void cancel()
{
}
 
// timer has reached 0, do stuff here
 
 
}.runTaskTimer(this, 0L, 20L);
}
}
 

Right now though, nothing happens when a player is sprinting.

I changed my code drastically now. It isn't completely working and it does some weird things.

1. Only works for one player since it sets the other players hunger at 0
2. hunger levels come in instantly... not one at a time after a 5 second delay.

Code:java

package me.maxben34.runner;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.Sound;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scheduler.BukkitRunnable;
 
public class runner extends JavaPlugin implements Listener{
    //jackson runner array... if player is in runner array then...
    List <Player> running = new ArrayList<Player>();
    List <Player> notrunning = new ArrayList<Player>();
    public void onEnable(){
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
//this part is supposed to see if a player is running and lower their saturation every second
    @EventHandler
    public void onPlayerMove(final PlayerMoveEvent e){
        new BukkitRunnable(){
            int timer = 20;
            public void run() {
                if(e.getPlayer().isSprinting()){
                    running.add(e.getPlayer());
                    notrunning.remove(e.getPlayer());
                for (Player p : running){
                    p.setFoodLevel(p.getFoodLevel() - 1); // increase all levels by 1
 
                    }
                timer--;
                if (timer == 0){
 
                }
                cancel();
                }               
            }   
                    // timer has reached 0, do stuff here
 
 
        }.runTaskTimer(this, 0L, 100L);
 
        new BukkitRunnable(){
        int timer1 = 20;
        public void run(){
            if(!(e.getPlayer().isSprinting())){
                notrunning.add(e.getPlayer());
                running.remove(e.getPlayer());
                for(Player p : Bukkit.getOnlinePlayers()){
                    p.setFoodLevel(p.getFoodLevel() + 1);
 
                    }
                timer1--;
                if (timer1 == 0){
            }
            cancel();
            }
        }
 
    }.runTaskTimer(this, 0L, 100L);
}
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

line 38 has nothing inside the {}. That's about all I can do to help

 

Fixed that but the problem still occurs (I knew that wouldn't fix it )