Solved Hide player plugin

Okay so i am trying to make a command to hide the certain player. But when i type /hide it keeps saying you are now hidden.

Main class:

Code:java

package net.bc.minecraft;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Hide extends JavaPlugin {
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
          Player player = (Player) sender;
          if(cmd.getName().equalsIgnoreCase("hide")){
            Player p = null;
            if (sender.hasPermission("bc.hide")){
            player.hidePlayer(player);
              for(Player ps : Bukkit.getOnlinePlayers()){
              p = ps;
              p.hidePlayer(player);
              }
              player.sendMessage(ChatColor.GRAY +"You are now hidden!");
            } else if(player.canSee(player)) {
              for(Player ps : Bukkit.getOnlinePlayers()){
              p = ps;
              p.showPlayer(player);
              }
              player.sendMessage(ChatColor.GRAY +"You are now unhidden!");
            }
 
            }
        return false;
 
          }
}

 

PolarCraft
Is: player.sendMessage(ChatColor.GRAY +"You are now hidden!"); inside the loop?

 

Sweatyyyy What loop?

 

PolarCraft
Uhm the for loop

 

Sweatyyyy Do you know how to read my main file?? Or did you just skip over it?? It is not.. And when i put it in the loop it still says it.

 

PolarCraft
No need to get mad , I'm only trying to help... At least I was trying -_- I'm not good at this stuff, just trying to learn

 

Then why are trying to help people on plugin developing if you still learning??

 

PolarCraft

Hello,

Here is what I can see is wrong:

1) (This is unconfirmed, because I don't use commandexecutors in my main class) Don't you need to implement CommandExecutor?

2) Check if the sender is a player before casting

3) Just use the player in the for each loop. No need to do 'p = ps;'

4) Why return false? It'll make Bukkit assume the command didn't go through

5) In that statement where you check if the player doesn't have the permission, the else goes straight into un-hiding them. Perhaps a message saying they don't have permission?

Do you mean that the player is spammed with the message "You are now hidden"? It shouldn't be doing that, from what I can tell (then again, who knows).

Perhaps some other opinions?

 

One the return false statement is for the ending not to do with the actual command.
Two i never do check if sender is a player. And my plugins work. All ready have commandexecutors...

 

line 17 you are trying to hide the player from them self

Code:java

player.hidePlayer(player);

Line 15, 19 & 25 are not required its just cluttered code

Code:java

/* 15 */ Player p = null;
/* 19 */ p = ps;
/* 25 */ p = ps;

Change line 20 & 26 to

Code:java

/* 20 */ps.hidePlayer(player);
/* 26 */ ps.showPlayer(player);

line 30 add

Code:java

return true;

------------------------------------------------------------------------------------------------------------------------

That will fix your current code that you have posted. Which incidentally only hides/unhides the player that runs the command, it will not hide a player your specify.

If you wish to hide a certain player that is not yourself (eg: /hide Goblom) you will need to add some args statements in there and check if Goblom is a player and if Goblom is online etc...

 

It is doing it because your plugin currently has the structure of:
Does player have permissions?

Yes: Hide player to all online​

No: Can the player see them self?​

Yes: Show player to all online​

You need to add another if after checking if they have permissions which checks if they can't see them self.

 

Goblom Now for the player.hidePlayer(player) what would i put instead?

 

You pretty much need to swap

Code:java

            player.hidePlayer(player);
              for(Player ps : Bukkit.getOnlinePlayers()){
              p = ps;
              p.hidePlayer(player);
              }
              player.sendMessage(ChatColor.GRAY +"You are now hidden!");

with

Code:java

 if(player.canSee(player)) {
              for(Player ps : Bukkit.getOnlinePlayers()){
              p = ps;
              p.showPlayer(player);
              }
              player.sendMessage(ChatColor.GRAY +"You are now unhidden!");

 

PolarCraft remove it.. Its not required and you are just trying to hide the player from them self which shouldnt work anyways.

 

Goblom Still doesn't work.
Current code:

Code:java

package net.bc.minecraft;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Hide extends JavaPlugin {
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
          Player player = (Player) sender;
          if(cmd.getName().equalsIgnoreCase("hide")){
            if (sender.hasPermission("bc.hide")){
              for(Player ps : Bukkit.getOnlinePlayers()){
              ps.hidePlayer(player);
              }
              player.sendMessage(ChatColor.GRAY +"You are now hidden!");
            } else if(player.canSee(player)) {
              for(Player ps : Bukkit.getOnlinePlayers()){
              ps.showPlayer(player);
              player.sendMessage(ChatColor.GRAY +"You are now unhidden!");
              }
            }
 
            }
        return false;
 
          }
}

 

PolarCraft ok. How are you testing this plugin ? Do you have another account to see if its not working ?

------------------------------------------------------------------------------------------------------------------------

Found another problem... line 20 (Player is checking if he can see himself..)

Code:java

} else if (player.canSee(player) { 

Ima re-write some of this plugin for you...

Code:java

private List<String> hiddenPlayers = new ArrayList<String>();
//onCommand
 
if (label.equalsIgnoreCase("hide")) {
    if (sender instanceof Player) {
        Player player = (Player) sender;
        if (player.hasPermission("bc.hide")) {
            if (hiddenPlayers.contains(player.getName())) {
                hiddenPlayers.remove(player.getName());
                for (Player otherPlayer : Bukkit.getOnlinePlayers()) {
                     if (!otherPlayer.canSee(player)) otherPlayer.showPlayer(player);
                }
            } else {
                for (Player otherPlayer : Bukkit.getOnlinePlayers()) {
                    otherPlayer.hidePlayer(player);
                    hiddenPlayers.add(player.getName());
                }
            }
        }
        return true;
    } else sender.sendMessage("Only players can use this");
}
return false;

 

Goblom now it multiples by how many people are online... And does not make me invisible...

[EDIT] I have friends join...

 

Here..

Code:java

package net.bc.minecraft;
 
import org.bukkit.ChatColor;
import org.bukkit.metadata.FixedMetadataValue;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class Hide extends JavaPlugin implements CommandExecutor {
 
    @Override
    public void onEnable() {
        getCommand("hide").setExecutor(this);
    }
 
    @Override
    public void onDisable() {
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("hide")){
            if (sender.hasPermission("bc.hide") && !player.hasMetadata("---HIDDEN---")){
                for(Player ps : Bukkit.getOnlinePlayers()){
                    ps.hidePlayer(player);
                }
                player.setMetadata("---HIDDEN---", new FixedMetadataValue(this, null));
                player.sendMessage(ChatColor.GRAY +"You are now hidden!");
                return true;
            } else if (sender.hasPermission("bc.hide")) {
                for(Player ps : Bukkit.getOnlinePlayers()){
                    ps.showPlayer(player);
                }
                player.removeMetadata("---HIDDEN---", this);
                player.sendMessage(ChatColor.GRAY +"You are now unhidden!");
                return true;
            }
        }
        return false;
    }
}

In case your plugin.yml is wrong too:

Code:

main: net.bc.minecraft.Hide
name: Hide
description: Toggle your visibility.
author: PolarCraft
version: 1.0
commands:
    hide:
        usage: Syntax error! /hide is the proper syntax.
        description: Hides you
permissions:
    bc.hide:
        default: op
        description: Allows you to hide yourself from other players.

 

whitehooder Following error.

Code:

15:28:59 [INFO] tripps41 issued server command: /hide
15:28:59 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'hide
' in plugin BasicCommands v10.22.2013
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:19
2)
        at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServe
r.java:523)
        at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerCon
nection.java:959)
        at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.j
ava:877)
        at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java
:834)
        at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49)
        at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296
)
        at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java
:116)
        at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
        at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:3
0)
        at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:5
92)
        at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:2
27)
        at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:4
88)
        at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java
:421)
        at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:5
83)
Caused by: java.lang.NullPointerException
        at org.bukkit.plugin.PluginBase.getName(PluginBase.java:29)
        at org.bukkit.plugin.PluginBase.hashCode(PluginBase.java:11)
        at java.util.WeakHashMap.hash(Unknown Source)
        at java.util.WeakHashMap.remove(Unknown Source)
        at org.bukkit.metadata.MetadataStoreBase.removeMetadata(MetadataStoreBas
e.java:88)
        at org.bukkit.craftbukkit.v1_6_R3.entity.CraftPlayer.removeMetadata(Craf
tPlayer.java:895)
        at net.bc.minecraft.Hide.onCommand(Hide.java:38)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
        ... 15 more
>

 

Did you use the exact code I provided you? If not, do you have multiple classes?

 

Yes i did. It is the following lines:
player.setMetadata("---HIDDEN---", new FixedMetadataValue(this, null));

and:
player.removeMetadata("---HIDDEN---", this);

And yes i have multiple classes.

 

Try with this jar file.

I suspect you don't have the permission, cause nothing is wrong with the code.

 

whitehooder i do have permission nodes.

[EDIT] Hmm. When i try yours it works... But when i do mine it does not work. I can not use the on enable or onDisable due to the fact i have a main class using that. But i have the commandexecutor on there.

 

bump.

 

Alright. Look, if you do return false; it is not going to return anything. I never use return false in any of my plugins. Change all return false's to return true;

 

kk. I will test it now.

 

Decided to recode it all from scratch.

Code:java

package me.negative_codezZ.playerhider;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    private ArrayList<String> HiddenPlayers = new ArrayList<String>();
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLable, String[] args) {
 
        if(!(sender instanceof Player)) {
            sender.sendMessage(ChatColor.RED +"Silly console... You can't hide!");
            return true;
        }
 
        Player p = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("hide")) {
            if(p.hasPermission("bc.hide")) {
                if(HiddenPlayers.contains(p.getName())) {
                    HiddenPlayers.remove(p.getName());
                    for (Player pls : Bukkit.getOnlinePlayers()) {
                        if (!pls.canSee(p)) {
                            pls.showPlayer(p);
                            return true;
                        }
                        return true;
                    }
                    return true;
                }
                if(!(HiddenPlayers.contains(p.getName()))) {
                    HiddenPlayers.add(p.getName());
                    for (Player pls : Bukkit.getOnlinePlayers()) {
                        pls.hidePlayer(p);
                        return true;
                    }
                    return true;
                }
            } else {
                p.sendMessage(ChatColor.RED +"You do not have access to that command!");
                return true;
            }
        }
        return true;
    }
 
}
 

If what I told you before doesn't work, try this.

 

negative_codezZ Does not work

 

That's odd... I don't know what to tell you then... Sorry!

 

zombiekiller753 whitehooder
Omg you guys. I don't mean to be offensive but for zombie killer, number one. You inherit onCommand from JavaPlugin so the main class does not need to be a command executer in order to execute the command.