Help with this NPE?

I keep getting a Null Pointer Exception from this command:

Code:java

if (cmd.getName().equalsIgnoreCase("jointeam")) {
            Team team = th.smallerTeam();
            th.addPlayer(player, team);
            player.sendMessage("yay");
        }

th is my Team Handler, and it's at line 85, which is the "smallerTeam" method, which is:

Code:java

public Team smallerTeam() {
        if (redTeam.getSize() > blueTeam.getSize()) {
            return redTeam;
        } else {
            return blueTeam;
        }
    }

And the addPlayer method:

Code:java

public void addPlayer(Player player, Team team) {
        Team teamCheck = getTeam(player);
        if (team != null && teamCheck != null) {
            if (team == blueTeam) {
                blueTeam.addPlayer(player);
                if (teamCheck.equals(redTeam)) {
                    removePlayer(player, redTeam);
                } else if (teamCheck.equals(observers)) {
                    removePlayer(player, observers);
                }
            } else if (team == redTeam) {
                redTeam.addPlayer(player);
                if (teamCheck.equals(observers)) {
                    removePlayer(player, observers);
                } else if (teamCheck.equals(blueTeam)) {
                    removePlayer(player, blueTeam);
                }
            } else if (team == observers) {
                observers.addPlayer(player);
                if (teamCheck.equals(redTeam)) {
                    removePlayer(player, redTeam);
                } else if (teamCheck.equals(blueTeam)) {
                    removePlayer(player, blueTeam);
                }
            }
        }
    }

As you can see from the addPlayer method, there's also removePlayer and getTeam. If you need those, let me know and I'll post them.

Thanks!

 

I'd need to see your Team class to fix this issue.

Also, do you have the error message I could see? Surely bukkit has printed out the line number where the error occurred.

 

The error

Code:

2013-10-23 22:46:26 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'jointeam' in plugin Sample Plugin v0.1
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
    at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:523)
    at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:959)
    at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:877)
    at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:834)
    at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49)
    at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296)
    at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116)
    at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
    at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30)
    at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
    at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
    at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
    at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
    at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.NullPointerException
    at me.Ranil.pvp.commands.AdminCommands.onCommand(AdminCommands.java:85)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
    ... 15 more

Line 85:

Code:java

Team team = th.smallerTeam();

That is inside of the 'jointeam' command.
The TeamHandler class:
Here.

 

What's likely is that getSize() is returning null, but I don't know why without seeing your Team class.

 

Everything pertaining to teams is that TeamHandler class that is at the bottom of my last post.

If you didn't see it, here.

 

@Ranil: did you initialize th with TeamHandler th = new TeamHandler(); before calling it?

 

Well, now I feel stupid. I did initialize it so there were no errors, but I didn't do it correctly. Thanks