[INACTIVE][ECON] BetterShop 1.6.5- iConomy Global Command-based Shop [602 & 677]

Discussion in 'Inactive/Unsupported Plugins' started by jjfs85, Feb 4, 2011.

  1. Offline

    jjfs85

    BetterShop - The "better" global command-based shop that ties into iConomy:
    Version: v1.6.5 (1.6.5.3)
    Download: (static jar) BetterShop.jar
    (older, 602 compatible) BetterShop_1.6.2.8.jar
    (older, 556 compatible) BetterShop_1.6.2.5.jar
    (older versions are not supported, sorry)
    Authors: jascotty2, and jjfs85, with a little help from lologarithm.

    Webpage coming soon.

    Want the most up-to-date info on usage, features, the changelog, and more?
    Read the README!

    Plugin Information (as of v1.6.5.3 - 4/11/11)

    Commands (open)

    • /shop
      • for those used to a plugin having one command, this is another way to get to the following commands
    • /shophelp (shelp) [command]
      • shows you all the commands you can use
      • can show specific help for a command
    • /shoplist (sl,slist) [pagenum]
      • shows a listing of items for sale
      • (if -1, all, or full given, will show full list. (mainly for console use))
    • /shopitems (sitems)
      • show full listing of items in shop, without prices
    • /shopcheck (sc,scheck) <item>
      • lookup a specific item so you don't have to read through pages of prices
    • /shopbuy (buy,sbuy) <item> [amount]
      • buy an item for the price in the shopshop ("all" is accepted as an amount)
    • /shopbuyall (buyall,sbuyall) <item>
      • buy all of an item that you can hold
    • /shopsell (sell,ssell) <item> [amount]
      • sell an item for the price in the shop
    • /shopadd (sadd): <item> <buy> [sell]
      • add an item to or update an item in the price list
    • /shopremove (sremove): <item>
      • remove an item from the price list
    • /shopload (sload):
      • reload prices from pricelist database
    • /shopsellall (sellall): [inv] [item [...]]
      • Sell all of item from your inventory (alias to command /shop sell all)
      • (inv will not search lower 9 slots)
    • /shopbuystack (buystack): <item> [item | amount]
      • buy a stack of an item (usually 64)
    • /shopsellstack (sellstack) <item> [amount]
      • sell a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba):
      • repeat last buy action
    • /shopsellagain (sellagain,ssa):
      • repeat last sell action
    • /shopkits (skits):
      • show a listing of avalliable kits (will be elaborated later)


    Dependencies (open)

    BetterShop's dependencies:

    Economy plugins supported:


    iConomy
    - or
    BOSeconomy

    Supported Plugins:

    • Permissions v2.5.0+ by people - permissions and groups plugin
    or​
    • GroupManager by not Zenexer after all- a replacement for Permissions that is fully compatible with plugins that require it (using FakePermissions)
    • Help 0.2+
    • MinecraftIM


    Features (open)

    Features:
    configurable
    • Fully configurable colors and message text in config.yml file
    • shoplist can have text alignment (read config for more info): <item> <l(eft-aligned)> <buy and sell info>
      • - uses minecraft font character spacing, so is very close to perfectly aligned in chat
    • shoplist can optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • Items can be colored in the new itemsdb.yml file
    • also in itemsdb.yml: kits!
      • - define your own kits that the shop can sell
      • - three examples provided, edit and add to your liking
    • Configurable Options:
      • -max pagesize when printing shoplist
      • -whether to broadcast all transactions publicly
      • -name of the pricelist file/table
      • -customsort: a custom sorting order, so you can have items at the top of the shop list
      • -allowbuyillegal: if someone without BetterShop.admin.illegal can buy illegal items
      • -whether maxstack should be honored
      • -if used tools can be bought back
      • -default color for items
    shop flexibility
    • shopcheck will run a name comparison check, and return all matching items
    • Item sub-type support for dye colors, cloth colors, etc: magentacloth = 35:2 = cloth:magenta
    • "all" is a valid amount when buying or selling: "/sell cobblestone all" or "/sell all cobblestone"
    • damaged tools can be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    • buystack can be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • not just items can be bought anymore: can now buy LivingEntities, like dogs (wolf)
    • signs can be used for buying & selling
      • Code:
         [*][BetterShop]
         [*]buy [amt], buyall, buystack, sell [amt], sellall, sellstack
         [*]item name (recommended) or id:data, or for sellall: onhand, inv
         [*](unused line)
         [*]
      • to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • left-click for price check (or activate), right-click to buy/sell
      • if a unauthorized player destroys a block a sign is on, is canceled
      • can scan for uxexpected sign destruction (tnt) & replace it
    administration
    • Every item and subtype can be priced differently
    • Disable buying or selling of an item by giving it a price of -1 (0 makes it free)
    • command aliases to stop carpal tunnel
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • MySQL pricelist support
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
      • (flatfile is cached until manually updated)
    • Transaction records (MySQL or flatfile as .csv)
    • Downloads mysql-bin.jar dependency automatically
    • buy/sell cap in program set to 999,999,999 (not that you'd be using that much, but the cap is to prevent other errors)
    • if encounters errors while editing a player's account, will attempt to reload iConomy (i've had issuses with it before)
    • can backup the current pricelist: /shop backup
    • on start, can check the download page to see if there is an update available
    • /shop ver[sion] shows version # and if is up-to-date
    • shop can be given a finite stock from which to buy & sell
    • /shop ver[sion] to check the current version & see if there's an update
    • MinecraftIM support: forward errors or all messages
    • checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • help main page integration can be disabled
    • global shop can be disabled & only allow signs to be used


    Installing (open)

    Installation instructions:

    New Installation?
    Upgrading?

    • lots more added to config.yml all the time..
    • to 1.6.3+ ? Itemsdb.yml has been expanded to include entities
    • from before v1.6.1.3 ? Itemsdb.yml has been expanded:
      • not required to update, but recommended
      • if you've already edited yours, you can look here and see what i've added
        • mainly: leaves, charcoal, tools & armor damage, some more aliases
    • from version 1.5.9b - 1.6.1.0 and use MySQL transaction logging?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
      • ALTER TABLE BetterShopMarketActivity CHANGE COLUMN SOLD SOLD TINYINT;
        • optional, but useful for php
    • from version between 1.5.5 - 1.5.9 and use MySQL pricelist?
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN BUY BUY DECIMAL(11,2);
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN SELL SELL DECIMAL(11,2);
    • from an earlier version?
      • Will import your old pricelist.yml into the db you have setup in the config :)
      • Items.db is no longer used - delete it :)
    Permissions:

    Just add the following nodes to Permissions' world.yml file (or data.yml file for GroupManager):


    - 'BetterShop.user.*'
    ^ Allows the user to use the list, sell, buy, and help commands
    - 'BetterShop.admin.*'
    ^ Allows the user to use the add, remove, and load commands

    Alright, so you have the plugins in place and set up, and permissions nodes added to the Permissions' config.yml. Now just place the BetterShop.jar file in the server's plugins directory. Then just start the server and add things to the shop. That's all!

    Adding Items:
    There are two ways to add things to the shop:
    1. Recommended, but slow: use /shopadd [item] [buy-price] [sell-price]
    2. Faster: use a text editor or spreadsheet program to edit the pricelist.csv


    TODO (open)

    features listed here may already be in the works, or may be on the back burner
    if you want a new feature, or want something sooner, ask :)

    • calculated/derived item prices
    • /shopvalue item[@amount] item to show the current trade value for two items
    • discount system: users or groups can be charged less/more for an item or all items (sell prices also affected)
    • dynamic market pricing, based off of logged market activity
    • region shops (items added while in a region defined as a shop are only added to that shop)
    • add option for amount in stock for surplus decreases how much item is worth to the shop
    • /shop alias <item> - show the itemname, with a list of aliases
    • add pages for /shopitems
    • more descriptive kit listing, similar to shoplist:
      • - pages
      • - show what makes up a kit
      • - enable admin.add to see avaliable kits
    • SQLite support?
    • tie item prices to stock quotes?
    • craftables' stock is tied to source material stock (if using sell craftables)
    • make LivingEntities follow the owner around?
    • change buystock if itemStock is enabled so that if trying to buy multiple stacks (buystack item 20) and stock runs out to stop buying (stop showing "out of stock")
    • individually-customizable restock stock values per-item
    • chest shop interface ?
    • automatically add missing config nodes (preserving comments)
    • add a simple builtin economy system, if none found?
    • add categories to items
      • - can search, buy, & sell with category
    • user-owned shops (signs, linked to chests)
    • 4th line for configurable prices or shop profit owner


    Changelog (open)

    Changelog:
    (the (?) means plugin didn't report that as the version.. sorry :))

    Version 1.6.5.3 - 4/11/11 - jascotty2
    • added option to disable sign protection
    • added sign action wait, to prevent sign click spamming
    • fixed a nullpointer error when selling
    Version 1.6.5.2 - 4/11/11 - jascotty2
    • removed spawnwolf debugging line
    • wolves bought have correct health
    Version 1.6.5.1 - 4/10/11 - jascotty2
    • removed a debugging line
    • wolfs bought have their owner already set (need to increase health)
    Version 1.6.5.0 - 4/10/11 - jascotty2
    • corrected new settings (missed some previously)
    • fixed default sign pricecheck showing wrong one
    • fixed messenger formatting error
    • misc. null fixes
    • BOSEconomy support added
    • changed block protection from scan to save (should improve performance)
    • added tnt protection, in the form of a scanner that routinely checks that all shop signs & their anchors still exist
    • added syntax check for /buy & /sell # [item] (like the sign syntax)
    • allowbuyillegal now defaults to true
    • fixed color set (hidden logic error)
    • signs can have the item name colored according to the defined item color
    Version 1.6.4.2 - 4/9/11 - jascotty2
    • fixed sign destroy permission check to only check bettershop signs
    Version 1.6.4.1 - 4/8/11 - jascotty2
    • "inhand" and "inv" added as valid sellall/buyall items (signs only)
      • - "in hand" buys/sells all of the type of item in the player's hand
    • sign destroy protection algorithm improved (still can't check for explosions :( )
    Version 1.6.4.0 (?) - 4/8/11 - jascotty2
    • stock message error fixed when selling too much
    • fixed <curr> causing a server freeze
    • added amount to pricecheck, so can check the result buy/sell price
    • fixed a buying error when already has some of the item
    • added a sign interface
      • - first line: [BetterShop] (not case-sensitive)
      • - second line: action: buy [amt], buyall, buystack, sell [amt], sellall, sellstack
      • - third line: item (name, id, etc)
      • - fourth line: unused (was going to make price, but decided on pricecheck instead)
      • - to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • - left-click to pricecheck
      • - right-click to run action
    • if a unauthorized player destroys a block a sign is on, is canceled
    • fixed column check for table updating
    • updated for 670
    • configuration nodes are moved to more organised parent nodes (easier to edit if using an intelligent text editor)
      • - older nodes are still supported (for now)
    Version 1.6.3.6 - 4/6/11 - jascotty2
    • again, previously forgot to update the date in last version
    • - added additional checks to prevent future false-positives
    • -- (also checks if comment on download matches plugin, not if plugin >= comment version)
    • figured out the integrity check errors :)
    • now runs checks on changed tables to check if needs updating (and adds columns as necessary)
    • - just transaction log table for now (only table with added columns)
    • another option added: AutoUpdate
      • - if a new update is found, will download & install
      • - can also run manually with /shop updade (OP-only, since forces update & restarts server plugins)
    Version 1.6.3.5 - 4/4/11 - jascotty2
    • fixed a rare null exception in integretycheck?
    • fixed saving errors when transaction logging disabled
    • implemented infinite stock (setting stock to -1 makes infinite)
    • # 1,000+ downloads in one day!
    Version 1.6.3.4 - 4/3/11 - jascotty2
    • fixed a rare invalid function signature error
    • fixed if a player tries to buy/sell air
    • OPs now completely bypass security checks
    • more changes to error reporting format: added a custom message
    • # 10,000+ lines of code :)
    Version 1.6.3.3 - 4/2/11 - jascotty2
    • renamed monstertamer package, to avoid conflicts if you're using the monstertamer plugin
    • should have a reported bug in integrety check taken care of.. not sure of the cause, though
    Version 1.6.3.2 - 4/2/11 - jascotty2
    • fixed more error reporting bugs (still can't find one stupid stock flatfile bug)
    • added stock messages to config
    Version 1.6.3.1 - 4/1/11 - jascotty2
    • fixed chickens & buying more than one animal
    • updated error reporting(again)
    • rand libary update for my (jascotty2's) version of CookieMonster
    Version 1.6.3 - 4/1/11 - jascotty2
    • fixed buy/sell == 0 ? no (in shoplist, 0 incorrectly showed as no)
    • updated for 612 (and 600+ .. had accidently been using the wrong libary)
    • LivingEntities can now be purchased! :D
      • special thanks to fullwall for the MonsterTamer plugin, from which this ability comes from (1.3)
      • if capable, will attack the anything attacking the purchaser (if nearby)
    Version 1.6.2.8 - 3/31/11 - jascotty2

    • nullpointer fixed if running 602 with old groupmanager
    • other misc. null fixes
    • removed redundant reload points for iConomy
    • repaired a mysql totalTransactionLog format error
    • error reporting now begins with a portion of the date, so i can see them listed in order
    • more info added to error reports.. still can't figure out the stock flatfile save bug
    Version 1.6.2.7 - 3/30/11 - jascotty2

    • improved error reporting format & removed a few unnecessary send triggers
    Version 1.6.2.6 - 3/30/11 - jascotty2

    • now checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • now compatible with bukkit 602
    • help main page integration can be disabled
    • hidden changes to get one step closer to dynamic pricing
    Version 1.6.2.5 - 3/28/11 - jascotty2

    • forgot to update the date in the last release, so a false 'newer release' was showing up
    • fixed help support when help loaded before bettershop
    Version 1.6.2.4 - 3/25/11 - jascotty2

    • Added support for my new plugin: MinecraftIM :)
    • removed a stock debugging line i forgot to remove
    • manually set locale for updating date format.. should fix non-us countries?
    Version 1.6.2.3 - 3/23/11 - jascotty2

    • added stock db to reload
    • fixed a stock update on sell
    • updated plugin commands to include sellstack (oops :oops:)
    Version 1.6.2.2 - 3/23/11 - jascotty2

    • more commands added to register with help
    • fixed a MySQL update syntax error for stock
    Version 1.6.2.1 - 3/23/11 - jascotty2

    • fixed a plural search bug
    • added /sellstack (much like buystack)
    • fixed a buyagain logic error
    • /shop import <file> - insert values from file in plugin folder
    • /shop restore <file> - clear shop & load from saved backup file
    • flatfile itemstock repaired
    Version 1.6.2 - 3/23/11 - jascotty2

    • stock option - items can have a finite amount
      • selling to the shop increases the stock, buying decreases
      • can have a minimum update interval: time before will reset stock to initial amounts
      • maximum stock: most will hold
      • noOverStock: will not allow selling if item stock is full
    • note on stock: does not track each item's damage values (if tools)
      • (selling a damaged good allows 1 intact to be bought)
    • /shop restock (permission BetterShop.admin.restock) to update how much stock the shop has
    • permission node BetterShop.admin.backup added for backing up the pricelist
    • added Help plugin integration: will automatically register commands with help
    • added some more MySQL db connection reconnect points (autoReconnect=true not working is becomming irritating)
    • more checking for iConomy account editing failures (i've had more problems with it)
    • fixed a format error if using a replacement char in listing (like <l.>)
    • retructured sellall inventory editing
    • # passed 7500 lines of code! (430KB)
    Version 1.6.1.4 - 3/21/11 - jascotty2

    • (hopefully) fixed MySQL region formatting errors (such as europe where the decimal is a comma)
    • addto/updated help menu
    • added [command] to help: lookup a specific command (also accepts aliases)
    • fixed flatfile total transactions log
    • shop ver[sion] also shows if the plugin is up-to-date
    Version 1.6.1.3 - 3/20/11 - jascotty2

    • default color for items
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • fixed transaction log insert missing the price
    • was having problems reading bit from php, so shanged SOLD column from bit to tinyint
      • alter table BetterShopMarketActivity change column SOLD SOLD TINYINT;
    • finished flatfile support for transaction logging
    Version 1.6.1.2 - 3/20/11 - jascotty2

    • runs MySQL connection check before executing database queries, and manually attempts reload if not connected
      • (still trying to iron out MySQL connection bugs, but this should end those errors)
    • removed list debugging lines i forgot to remove earlier
    Version 1.6.1.1 - 3/19/11 - jascotty2

    • removed double negative add check.. can add an item for -1, -1
    • fixed some Item errors: color and .equals(ItemStack).. fixes itemdb colors and sellall
    • fixed page numbering for when there are hidden items
    • fixed sell for 0: a <= instead of < .. thought i'd fixed that, but apparently not all of those.
    Version 1.6.1 - 3/19/11 - jascotty2

    • update check is optional (in config)
    • /shop backup to save pricelist to a backup csv file
    • updates itemsdb on shopload, in case the admin wanted to update colors/kits and such
    • added price column in marketHistory table
      • upgrading from older version?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
    • added flatfile support for transaction logging (uses csv)
    • removed pricelist save file on close (is already saved on edit)
    • if an item is marked as no buy, no sell, don't show on shoplist
    • itemsdb names can be saved (and outputted) with title formatting (eg RedstoneTorch)
    • - included itemsdb also expanded & names formatted
    • case-insensitive item matching
    Version 1.6.1 alpha - 3/18/11 - jascotty2

    • Checks git to see if there is a newer version avaliable
    • fixed price = 0 to be free
    • fixed null in sellall if selling all sellable
    Version 1.6.0f - 3/18/11 - jascotty2

    • better error check for config & importing old yml pricelist
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
    • fixed sell bug (selling one would credit for amount in the first stack)
    Version 1.6.0e - 3/17/11 - jascotty2

    • fixed a removal error - there was a typecast exception previously
    Version 1.6.0d - 3/17/11 - jascotty2

    • if the old PriceList.yml file exists, will import into whatever db is enabled, then rename the file
    • fixed public message bug - would send broadcast (num_players-1) times
    Version 1.6.0c (?) - 3/17/11 - jascotty2

    • added more options: allowbuyillegal, usemaxstack, buybacktools
    • fixed buystack history
    • major buystack logic error repaired - previously didn't work correctly
    • buystack can now be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • damaged tools can now be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    Version 1.6.0b (?) - 3/16/11 - jascotty2

    • fixed a minor buy error if tried to buy more than they can hold, and could hold 0 more
    • major MySQL problem fixed - pricelist table wasn't being created
    Version 1.6.0 - 3/16/11 - jascotty2

    • major code restructure & reorganization
    • changed item db to a more descriptive yml file
      • can define what items make an item (for calculated/dynamic costs)
      • can change what color it will be outputted as in the listing
      • define kits (sold.. store won't buy them)
    • MySQL buy & sell fields increased to decimal(11,2), and cap in program set to 999,999,999
    • shoplist can now optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • removed value check - can now "sell" items that sell for 0
    • added /shop command alias - for if a user is more used to "/shop help" than "/shophelp"
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • now does pre-check for if user can hold as much as they're trying to buy
      • and "all" to try to buy as many as they can hold
    • items can be marked as illegal, and can only be purchased by a select few (using permissions)
      • also not shown to users who cannot buy them, except with pricecheck
    • option in config to make transactions publicly broadcasted
    • option in config to have a custom sort order
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • now shows what items were sold when using shopsellall
    • fixed bug where single sell parameter would == sell [item] all
    • all, full, -1 added as a pricelist pagenumber: will print the full list (intended for console use)
    • marketactivity table truncate logic repaired..
    • marketactivity MySQL table changed with primary key(DATE, USER, ID) (instead of DATE, USER) to resolve conflicts with sellall
    • items can be marked as 'legal: false', and only those with permissions can buy them (can still sell)
    • if encounters errors while editing a player's account, will attempt to reload iConomy
    • sellall can be given "inv" as first parameter to only sell from inventory (not in quick access slots)
    • shopcheck given partial name matching: "/shopcheck wool" (not "shopcheck 35") will show all colored wool prices :)
    • fixed sellall bug when an item not for sale
    • /shopbuystack (buystack): buy a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba): repeat last buy action
    • /shopsellagain (sellagain,ssa): repeat last sell action
    • /shopkits (skits): show a listing of avalliable kits (will be elaborated later)
    • can now buy kits :)
    • /add now has sell as an optional parameter.. will set to -1 if not given (or if is a kit)
    Version 1.5.9b - 3/11/11 - jascotty2

    • width outputting in minecraft chat (for /shoplist): now can have item (or listing) right-align, left-align, or centered
    • implemented transaction log and total transactions record
    • no longer dependent on permissions: if missing, ops have .admin.* & everyone has .user.*
    • bugs: MySQL buy & sell is decimal(6,2), limiting price to 9,999 (plus a nondescriptive error)
      • to fix (db minecraft, table BetterShop):
      • alter table minecraft.BetterShop change column buy buy decimal(11,2);
      • alter table minecraft.BetterShop change column sell sell decimal(11,2);
    • unknown error: MySQL connection seems to get dropped & won't connect until restart plugin
      • seems to stem from iConomy (v4.4 (Arcadia)) or v0.2 [Coelho].. i only have 4.4, but .2 is being logged
      • shopload should fix this, but iconomy will still be down.. if you have a plugin like hotswap, reload iConomy
    • not a bug, but forgot to remove: debug output of select statements being executed
    Version 1.5.8(?) - 3/10/11 - jascotty2

    • fixed a sell error for one parameter
    • major-ish code restructure - removed data redundancy
    • / shopsell all [item] (alias to /shopsell [item] all)
    Version 1.5.7(?) - 3/10/11 - jascotty2

    • / shopsell [item] all added: sell all of an item that you have
    • fixed total sell value min to .01 instead of 1 (if your server uses low prices)
      • before this fix, one could get around this check by trying to sell alot of an item
    • now automatically downloads mysql dependency (zip from mysql mirror & unzip or from iConomy mirror)
    Version 1.5.5(?) - 3/9/11 - jascotty2

    • Pricelist can now be in a MySQL database
    Version 1.5.4 - 3/2/11

    Fixed some lingering bugs with lologarithm's help.


    Version 1.5.3
    Fixed sell 0 < sellprice < 1 bug.


    Version 1.5.2
    Now it'll convert your old pricelist.yml to the new 1.5.x format automagically!


    Version 1.5.1
    Fixed the bug where setting a price to -1 didn't disable it
    Fixed the "LOLWTFDOESN'TWORK" bug.
    Made price-list listing configurable in config.yml. The way it was 'sposta be.

    (older versions not shown..)

     
  2. Offline

    Beaverbeliever

    Code:
    2011-03-31 22:19:36 [SEVERE] Nag author: 'jjfs85, lologarithm, and jascotty2' of 'BetterShop' about the following: onPluginEnable has been replaced with a new signature, (PluginEnableEvent)
    Nag nag nag :p
     
  3. Yes please fix this the sooner its fixed the sooner MCG can go back up.
     
  4. Offline

    jascotty2

    Version 1.6.3 - an april fool's release :)
    fixed buy/sell == 0 ? no (in shoplist, 0 incorrectly showed as no)
    updated for 612 (and 600+ .. had accidently been using the wrong libary)
    LivingEntities can now be purchased! :D
    - special thanks to fullwall for the MonsterTamer plugin, from which this ability comes from (1.3)
    - if capable, will attack the anything attacking the purchaser (if nearby)
    (added since i couldn't find any wolves, and really wanted one :))

    (make sure to update your itemsdb.yml to include the entities section)

    Version 1.6.3.1
    fixed chickens & buying more than one animal
    updated error reporting(again)
    rand libary fixes for my version of CookieMonster

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 8, 2016
  5. Offline

    serenewaffles

    The link that CraftBukkituptoDate has for BetterShop points to version 1.5.2. Any chance you could send them the new static .jar link?
     
  6. Offline

    jascotty2

    i'm thinking of implementing an auto-update feature, if you'd prefer
     
  7. Offline

    JaredKey

    Craftbukkit: 617
    iConomy: v4.65 (Kenzi)
    Permissions: [2.5.5] (Phoenix)
    Bettershop: v1.6.3 (1.6.3.0)


     
  8. Offline

    jascotty2

    Version 1.6.3.3
    renamed monstertamer package, to avoid conflicts if you're using the monstertamer plugin
    should have a that bug in integrety check taken care of.. not sure of the cause, though :(
     
  9. Offline

    DigitalTyrant

    When we use various commands for the shop we get:
    It seems the coloring is not functioning as intended. Is this an issue on my side or something that is fudged because of the update?

    CB RB 617 and BS 1.6.3.3

    FIXED: Looked like the updated BetterShop couldn't parse my existing config.yml
     
  10. Offline

    Privatepartshax

    how come even tho im op its saying i dont have permission for that command?
     
  11. Offline

    jascotty2

    not sure.. must be how your permissions is running
    OPs will bypass security checks in the next release
     
  12. Offline

    Ch0b0

    There is one error I'm seeing almost every time I stop my server.

    This is with build 617 and iConomy 4.6.5

    Code:
    15:03:26  [SEVERE] java.lang.IllegalAccessError: tried to access class  com.mysql.jdbc.EscapeProcessor from class com.mysql.jdbc.StatementImpl
    15:03:26 [SEVERE]       at com.mysql.jdbc.StatementImpl.executeUpdate(StatementImpl.java:1505)
    15:03:26 [SEVERE]       at com.mysql.jdbc.StatementImpl.executeUpdate(StatementImpl.java:1485)
    15:03:26 [SEVERE]       at com.jascotty2.MySQL.MySQL.commit(MySQL.java:238)
    15:03:26 [SEVERE]       at com.jascotty2.MySQL.MySQLPriceList.commit(MySQLPriceList.java:81)
    15:03:26 [SEVERE]       at com.jascotty2.Shop.PriceList.close(PriceList.java:236)
    15:03:26 [SEVERE]       at com.nhksos.jjfs85.BetterShop.BetterShop.onDisable(BetterShop.java:212)
    15:03:26 [SEVERE]       at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:120)
    15:03:26 [SEVERE]       at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:525)
    15:03:26 [SEVERE]       at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:228)
    15:03:26 [SEVERE]       at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:222)
    15:03:26 [SEVERE]       at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:83)
    15:03:26 [SEVERE]       at net.minecraft.server.MinecraftServer.g(MinecraftServer.java:238)
    15:03:26 [SEVERE]       at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:313)
    15:03:26 [SEVERE]       at net.minecraft.server.ThreadServerApplication.run(SourceFile:375)
    15:03:26 [INFO] Stopping server
    
     
  13. Offline

    jascotty2

    Version 1.6.3.4
    fixed a rare invalid function signature error
    fixed if a player tries to buy/sell air
    OPs now completely bypass security checks
    more changes to error reporting format: added a custom message

    i get that, too.
    that's an error in the MySQL library... (i didn't write that)
    hopefully it's not being unloaded before bettershop is unloaded :confused:
    a commit shouldn't be fully necessary, anyway

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 8, 2016
  14. Offline

    pvtv3ga

    I downloaded an example BetterShopItemStock.csv file and replaced it with the blank one that comes downloaded with the plugin. However, Bettershop.csv is still blank.....do I really have to go in and fill every value? Is there an example one somewhere I can download?
     
  15. Offline

    Ch0b0

    Ok, it doesn't seem to cause any actual problems as far as I've noticed.

    I got another one for ya :p There seems to be a warning whenever someone buys something from the shop. Logging is disabled in the config file. Here is the output:

    Code:
    17:53:21 [WARNING] Error saving activity log: undefined or is directory
     
  16. Offline

    jascotty2

    the itemstock file is to keep track of the individual stock of each item in the shoplist
    i don't have it checking if the items exist, so nothing is removed (didn't expect people to share those :p), so nothing is removed from that db, but if you don't have those items in the shop they aren't tracked (and adding them will reset the value to what you have set in the config)
    if you want to use the stock with the items, you'll need the pricelist that was linked to that file
     
  17. Offline

    pvtv3ga

    My apologies, but I don't understand what you're trying to tell me. Is there a setup video somewhere? You're saying I don't need to edit the ItemStock file, but the BetterShop.csv file instead? I seriously have to manually type every item in?
     
  18. Offline

    Harrowed

    Forgive me if this is a dumb question, but could you show me an example of the line in BeterShop.csv file you'd use for a living entity? I see in the DB they have entity numbers but I'm not sure as to what exactly you'd type in for the ID and Subdata columns in the csv.
     
  19. Offline

    lenocinor

    EDIT: ^^^ @Harrowed I read your mind, apparently. :) Use 4000 for the first one (the final entity, Wolf, should be 4014).

    Finally got to upgrade to the new version of the shop, since I was stuck on the old version of Bukkit for a while due to Stats. :) Seems to work great. Hooray for buying animals (though you should mention for CSV types like me that you have to start their IDs at 4000...)

    Only one funny thing I keep seeing in the console when I buy stuff:

    22:45:03 [INFO] [BetterShop] (public announcement) someuser sold 2 LightGrayWool for 33.32 Gold
    22:45:03 [SEVERE] Error saving activity log: undefined

    Is this a BetterShop error? And if so, is it because of something stupid I'm doing in the config file? It doesn't seem to do anything bad on the server but I was curious.
     
  20. Offline

    jascotty2

    iv'e been finding errors like that.. i can't replicate them though :(
    nothing serious, just means you're not using transaction logging & it's still trying to save
    i'll go over the code again once i get some sleep.. been looking for it for too long today
     
  21. Offline

    Harrowed

    That's some Miss Cleo stuff :confused:
    Thanks a lot lenocinor. :]
     
  22. Offline

    lokiman72

    I use this, but the colors fail. I see a bunch of numbers and letters and signs. (Obviously to make text have a color) but it does not work. This also makes it very difficult to read, the console throws no errors, its just the text doesn't come with a color, and you can see the things that try to make it have a color.

    Here is an example:

    &f SHOP: &2/shopadd <item> <$buy> [$sell] - Add/update an item.
    For /shopadd's line.

    Its not client side, other users have this same problem. Also I am not blocking colors, because other plugins I have still use colors and work without showing stuff like &f.

    Hope you can fix this.​
     
  23. Offline

    huadianz

    Love the plugin, looks much better than DynamicMarket that I use right now, but the thing I really need is dynamic pricing support in accordance to stock. I see it in the TODO list, but just would like to know whether it's being implemented or not.

    Thanks
     
  24. Offline

    lenocinor

    Colors work fine for me on latest BetterShop and recommended build (#617), including user-defined colors in the shop listing. I specifically checked the help line in your example and it looks fine on mine. What other plugins are you running? Maybe one of them is conflicting?
     
  25. Offline

    looklee

    how to don't buy ???
    i did
    /shop add 1 0 3
    0 is free
    i want don't buy
    how to do??
     
  26. Offline

    jascotty2

    finally figured out the activity log errors.. was a dumb error, as i suspected it would be

    Version 1.6.3.5
    fixed a rare null exception in integretycheck (i hope ;))
    fixed saving errors when transaction logging disabled
    implemented infinite stock (setting stock to -1 makes infinite)
     
  27. Offline

    lenocinor

    Try -1.
     
  28. Offline

    serenewaffles

    It would depend on how it is done. I'm not sure I would like it if it auto-updated the .jar and then loaded the new one without any input. Aside from that, I'm not all that picky about who grabs the updates. It is just a pain to open the server log or check the forums to see if there are updates.
     
  29. Offline

    koneko

    I'm having an issue with the shop database presently. Specifically, there are two parts.

    a) Updated to a newer BetterShop and all instances in-world of the prices and such were lost. I verified that the spreadsheet file with all the data (items, pricing, etc) was present, copying over a new file to be sure. I double-checked anything I could think of. Even tried a clean install of the plugin with the excel spreadsheet file brought in afterwards. No go.
    b) I have also renamed my world now. While the plugin can pickup the MySQL database, it still isn't seeing any of the previous pricing information.

    I'm guessing my issues are somehow related to the database and renaming the world. However, I'm not familiar with how to access/open the MySQL database to adjust values within it, nor how to get BetterShop to read from the spreadsheet file.

    Suggestions? Thanks in advance.
     
  30. Offline

    jascotty2

    @koneko
    very curious problem.
    renaming the world shouldn't have anything to do with it, since it's designed to be global
    if you're using linux, double-check that the user bukkit is running as can access those files (i'm assuming you can, since it's loading MySQL)
    also in linux, you can use the MySQL client on the commandline:
    • mysql --user=username --password=password -h hostname databasename
    • (can leave out "-h hostname" if on the same machine)
    • then "show tables;" to see what's in that database, and "select * from BetterShop;" to see what's in that table (tablename is case-sensitive)
    not sure what you'd use in windows but i'm sure there are tools for that
    this site is amusing :)

    to load the pricelist from a csv file: /shop restore filename
    (file should be in the BetterShop plugin folder)
    (can use import to overwrite without removing what's in the table)
     
  31. Offline

    koneko

    @jascotty2

    I figured everything was intended to be global, but heck if I know! XD What I have found is that everytime we have a major MC update, my database stuff is messed up for iConomy and BetterShop. I actually had to completely remove the previous iConomy folder in order to update it this time as it also was acting wonky as can be (multiple instances of players, etc.). Sadly, this seems to have caused me to lose the previous data, which is upsetting. iConomy now uses H2SQL by default in place of MySQL, as well. Not sure if renaming the world has anything to do with anything.. but of course, it would be my luck.

    I'm going to go ahead and try your suggestion for the commandline access. Not sure how really to change/adjust things, though.. or get it to just read the CVS file other than what you suggested. I attempted the /shop restore option, and it confirmed that it loaded, but nothing is updated. x.X blarg.

    Alright, the restore option loaded, but didn't update anything. I've confirmed the MySQL database information and reload within world via BetterShop confirms it's loading from the correct database. However! When I pull up the MySQL client, the table listed is "bettershop" rather than "BetterShop." Either one works to bring up the tables. The previous data appears to be there! For whatever reason, it's just not reading/loading it in world? I'm not sure why...

    Suggestions?
     

Share This Page