Better saving and retrieving location from config

finalblade1234 recently posted a way that he sets and gets locations from a config, but it didn't support yaw or pitch. This is the way I do it:
Save:

Code:java

public void saveLoc(Location loc) {
    String location = loc.getWorld().getName() + "," + loc.getX() + "," + loc.getY() + "," + loc.getZ() + "," + loc.getYaw() + "," + loc.getPitch();
    plugin.getConfig().set("location", location);
    plugin.saveConfig();
}

Get:

Code:java

    public Location getLocation() {
        String[] loc = plugin.getConfig().getString("location").split("\\,");
        World w = Bukkit.getWorld(loc[0]);
        Double x = Double.parseDouble(loc[1]);
        Double y = Double.parseDouble(loc[2]);
        Double z = Double.parseDouble(loc[3]);
        float yaw = Float.parseFloat(loc[4]);
        float pitch = Float.parseFloat(loc[5]);
        Location location = new Location(w, x, y, z, yaw, pitch);
        return location;
    }

 

Thanks man, this will be useful for my plugin!

 

Make sure to check that the world isn't null and that all the values you're parsing are actually what you expect.

Also check the length of that string array.

 

If you store it, it will never be null.

 

Sure it can. What if stupid user decides to delete the world in between it being stored and being retrieved?

Assume users will mess up the config and change your stored values, too.

 

lol768

Code:

    public void setLocation(ConfigurationSection section, String path, Location location) {
        section.set(path, String.format("%s,%s,%s,%s,%s,%s",
                location.getWorld(), location.getX(), location.getY(), location.getZ(), location.getYaw(), location.getPitch()
            ));
    }
   
    public Location getLocation(ConfigurationSection section, String path) {
        if (section.contains(path) && section.isString(path)) {
            try {
                String[] location = section.getString(path).split(",");
                if (location.length == 6 && Bukkit.getWorld(location[0]) != null) {
                    return new Location(
                            Bukkit.getWorld(location[0]),
                            Double.parseDouble(location[1]),
                            Double.parseDouble(location[2]),
                            Double.parseDouble(location[3]),
                            Float.parseFloat(location[4]),
                            Float.parseFloat(location[5])
                        );
                }
            } catch (Exception error) {
               
            }
        }
        return null;
    }

Something probably like this?

 

That'd work. My only concern is what characters can be included in a world name? If they can put commas in the name they'll screw up your string splitting. Maybe something like this would work better.
{"world" : "hungergames", "x" : 5, "y": 65, "z": 255, "yaw": 1.748, "pitch": 1.489}

 

Maybe using '|' instead of a ','? It's pretty much impossible to set a file containing '|' in it.

 

I know it's not as compact, but you could also just use a configuration section for each location and have world, x, y, z, pitch, yaw sub-values in it.

 

like location:
x: 0
y: 0...
Yeah, I like this due to it only taking up one line.
Sample output:

1. lobby_spawn: world,922.0388790007195,84.0,779.5382056660741,0,0

 

You might be able to just round the coordinates off to the third digit, since there isn't a huge noticeable difference with a .0001 change

 

I do.